note that due to (seemingly) the lack of codec driver support there still is no audio support in the guest
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.
## 📋 Pull Request Information
**Original PR:** https://github.com/sickcodes/Docker-OSX/pull/82
**Author:** [@jimdigriz](https://github.com/jimdigriz)
**Created:** 9/20/2020
**Status:** ✅ Merged
**Merged:** 9/24/2020
**Merged by:** [@sickcodes](https://github.com/sickcodes)
**Base:** `master` ← **Head:** `tweaks`
---
### 📝 Commits (9)
- [`07b9c8b`](https://github.com/sickcodes/Docker-OSX/commit/07b9c8b80def9e6dc82ee821c466cbe1df20481e) empty pkg cache
- [`02564cb`](https://github.com/sickcodes/Docker-OSX/commit/02564cba09c0b531ad83dc6d455ff48989e58e99) use shell expansions for defaults
- [`a07da08`](https://github.com/sickcodes/Docker-OSX/commit/a07da08cfd134fcce841985ecf06b3786ab4d6ff) use shell exec/set-eu
- [`de9b319`](https://github.com/sickcodes/Docker-OSX/commit/de9b31923c4d829361df36598cd7a1d97226d608) support fallback to tcg from kvm
- [`96302c6`](https://github.com/sickcodes/Docker-OSX/commit/96302c6f6d64795a27541e3a295131bedf8bae84) remove need for DISPLAY
- [`41dee4b`](https://github.com/sickcodes/Docker-OSX/commit/41dee4b3212f761819b2781a43347cda48649f79) remove need for privileged
- [`bb7de1b`](https://github.com/sickcodes/Docker-OSX/commit/bb7de1bfea259e37b08d92014a4e948cb260dfad) make audio driver configurable but defaults to alsa
- [`812c4a2`](https://github.com/sickcodes/Docker-OSX/commit/812c4a2e0971b48953e54b9086c0b0f70c2dd7d5) pulseaudio example
- [`34757eb`](https://github.com/sickcodes/Docker-OSX/commit/34757eb7543f3dc846b50d9220d4279c8a86ce0e) improve handling of BaseSystem.dmg to reduce image by 2.5GB (from 6GB)
### 📊 Changes
**2 files changed** (+45 additions, -50 deletions)
<details>
<summary>View changed files</summary>
📝 `Dockerfile` (+31 -39)
📝 `README.md` (+14 -11)
</details>
### 📄 Description
Several proposed improvements:
* remove the need for `privileged`
* reduce final image by ~2.5GB (from 6GB)
* support fallback from kvm to tcg
* use shell expansions and push `DISPLAY` into `ENV` so it does not need to be supplied
* provide example on how to use PulseAudio
* partly resolves https://github.com/sickcodes/Docker-OSX/issues/71
* note that due to (seemingly) the lack of codec driver support there still is no audio support in the guest
---
<sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
📋 Pull Request Information
Original PR: https://github.com/sickcodes/Docker-OSX/pull/82
Author: @jimdigriz
Created: 9/20/2020
Status: ✅ Merged
Merged: 9/24/2020
Merged by: @sickcodes
Base:
master← Head:tweaks📝 Commits (9)
07b9c8bempty pkg cache02564cbuse shell expansions for defaultsa07da08use shell exec/set-eude9b319support fallback to tcg from kvm96302c6remove need for DISPLAY41dee4bremove need for privilegedbb7de1bmake audio driver configurable but defaults to alsa812c4a2pulseaudio example34757ebimprove handling of BaseSystem.dmg to reduce image by 2.5GB (from 6GB)📊 Changes
2 files changed (+45 additions, -50 deletions)
View changed files
📝
Dockerfile(+31 -39)📝
README.md(+14 -11)📄 Description
Several proposed improvements:
privilegedDISPLAYintoENVso it does not need to be supplied🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.