[PR #422] Fix SPM install + Add secure #503

New Issue

Open

opened 2025-12-29 15:32:44 +01:00 by adam · 0 comments

adam commented 2025-12-29 15:32:44 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/422
Author: @matteocrippa
Created: 4/29/2021
Status: 🔄 Open

Base: develop ← Head: feature/spm-fix-secure

---

📝 Commits (10+)

• 3e68be4 Update Package.swift
• 19df321 Update Package.swift
• 619f2b7 introduce secure storage
• 0d3928c Update SQLiteStore.swift
• 6eac860 Update SQLiteStore.swift
• e7314ee add infoplist to excluded to silent error on spm
• 5370f39 Merge branch 'JohnEstropia:develop' into feature/spm-fix-secure
• 02156db avoid force cast
• 5ab5fd2 remove force try!
• cf636f2 rollback

📊 Changes

3 files changed (+11 additions, -5 deletions)

View changed files

📝 Package.swift (+2 -2)
📝 Sources/From.swift (+2 -1)
📝 Sources/SQLiteStore.swift (+7 -2)

📄 Description

This PR aims to fix one issue for SPM install:

• fix warning for Info.plist as unhandled resource
• remove the Combine extension because raise error and make the lib not working at all

Also it introduces and extra init param that will force the sqlite file to be encrypted ( I took as reference #145 )

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/422 **Author:** [@matteocrippa](https://github.com/matteocrippa) **Created:** 4/29/2021 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `feature/spm-fix-secure` --- ### 📝 Commits (10+) - [`3e68be4`](https://github.com/JohnEstropia/CoreStore/commit/3e68be406673d30f14cb8957f66835f0e9d786c0) Update Package.swift - [`19df321`](https://github.com/JohnEstropia/CoreStore/commit/19df3218c3b68b643608f292fc85036a4dafd4e8) Update Package.swift - [`619f2b7`](https://github.com/JohnEstropia/CoreStore/commit/619f2b75af20f07adc230abbf75cbeec08713e62) introduce secure storage - [`0d3928c`](https://github.com/JohnEstropia/CoreStore/commit/0d3928c43d480a20382d2bbbbf2a8af7f06bd8a7) Update SQLiteStore.swift - [`6eac860`](https://github.com/JohnEstropia/CoreStore/commit/6eac8601fc3f5d5c6483fd97c8617ea3797d3b9d) Update SQLiteStore.swift - [`e7314ee`](https://github.com/JohnEstropia/CoreStore/commit/e7314eeaa417cbad908fd1820d2c21af14a6b955) add infoplist to excluded to silent error on spm - [`5370f39`](https://github.com/JohnEstropia/CoreStore/commit/5370f395a1b13bcd101e6a7343b1f791b4d2bd8b) Merge branch 'JohnEstropia:develop' into feature/spm-fix-secure - [`02156db`](https://github.com/JohnEstropia/CoreStore/commit/02156dbfab2fe39624a564e24a0b72f4963c5404) avoid force cast - [`5ab5fd2`](https://github.com/JohnEstropia/CoreStore/commit/5ab5fd20d477a8f9c1b41a63d5e2b1c34a2435d5) remove force try! - [`cf636f2`](https://github.com/JohnEstropia/CoreStore/commit/cf636f26b964ae67812a5f3e7f784e16b68a04a8) rollback ### 📊 Changes **3 files changed** (+11 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `Package.swift` (+2 -2) 📝 `Sources/From.swift` (+2 -1) 📝 `Sources/SQLiteStore.swift` (+7 -2) </details> ### 📄 Description This PR aims to fix one issue for SPM install: - fix warning for Info.plist as unhandled resource - remove the Combine extension because raise error and make the lib not working at all Also it introduces and extra init param that will force the sqlite file to be encrypted ( I took as reference #145 ) --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 15:32:44 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#503