[PR #308] Improve custom schema mapping provider #492

New Issue

Open

opened 2025-12-29 15:32:36 +01:00 by adam · 0 comments

adam commented 2025-12-29 15:32:36 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/308
Author: @iby
Created: 3/16/2019
Status: 🔄 Open

Base: develop ← Head: develop

---

📝 Commits (6)

• caa26bc Fix source model typos
• b609cdd Add migration unit test for CustomSchemaMappingProvider
• 242a1fa Simplify migration mapping model creation
• 790378f Remove try from asynchronous add storage example
• 4790053 Remove source expression for deleted entities
• 6c7778f Improve custom schema mapping provider

📊 Changes

12 files changed (+376 additions, -179 deletions)

View changed files

📝 CoreStore.xcodeproj/project.pbxproj (+8 -0)
➕ CoreStoreTests/MigrationTests.swift (+235 -0)
📝 CoreStoreTests/SetupTests.swift (+4 -4)
📝 README.md (+2 -2)
📝 Sources/CSSQliteStore.swift (+2 -2)
📝 Sources/CSStorageInterface.swift (+1 -1)
📝 Sources/CustomSchemaMappingProvider.swift (+80 -133)
📝 Sources/DataStack+Migration.swift (+5 -5)
📝 Sources/DataStack.swift (+2 -2)
📝 Sources/NSEntityDescription+Migration.swift (+29 -22)
📝 Sources/SQLiteStore.swift (+5 -5)
📝 Sources/StorageInterface.swift (+3 -3)

📄 Description

1. Improve property and relationship mapping.
2. Throw errors when property or relationship cannot be mapped, don't explicitly unwrap.
3. Add extensive schema mapping and migration tests.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/308 **Author:** [@iby](https://github.com/iby) **Created:** 3/16/2019 **Status:** 🔄 Open **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (6) - [`caa26bc`](https://github.com/JohnEstropia/CoreStore/commit/caa26bca702f18d60afc58ccba129b8422035579) Fix source model typos - [`b609cdd`](https://github.com/JohnEstropia/CoreStore/commit/b609cdd47dd197ec9f1c31d119f93bfc72d8b832) Add migration unit test for CustomSchemaMappingProvider - [`242a1fa`](https://github.com/JohnEstropia/CoreStore/commit/242a1fa0440297c49b95e1f5765b4b55b4d2648e) Simplify migration mapping model creation - [`790378f`](https://github.com/JohnEstropia/CoreStore/commit/790378f7dc63e30da30f801dfd35ee02020a5129) Remove try from asynchronous add storage example - [`4790053`](https://github.com/JohnEstropia/CoreStore/commit/4790053475cbdd26c9c52609ea84b9c8259e82ef) Remove source expression for deleted entities - [`6c7778f`](https://github.com/JohnEstropia/CoreStore/commit/6c7778f32e02182e46debb7ef79d7b167fb0c84d) Improve custom schema mapping provider ### 📊 Changes **12 files changed** (+376 additions, -179 deletions) <details> <summary>View changed files</summary> 📝 `CoreStore.xcodeproj/project.pbxproj` (+8 -0) ➕ `CoreStoreTests/MigrationTests.swift` (+235 -0) 📝 `CoreStoreTests/SetupTests.swift` (+4 -4) 📝 `README.md` (+2 -2) 📝 `Sources/CSSQliteStore.swift` (+2 -2) 📝 `Sources/CSStorageInterface.swift` (+1 -1) 📝 `Sources/CustomSchemaMappingProvider.swift` (+80 -133) 📝 `Sources/DataStack+Migration.swift` (+5 -5) 📝 `Sources/DataStack.swift` (+2 -2) 📝 `Sources/NSEntityDescription+Migration.swift` (+29 -22) 📝 `Sources/SQLiteStore.swift` (+5 -5) 📝 `Sources/StorageInterface.swift` (+3 -3) </details> ### 📄 Description 1. Improve property and relationship mapping. 2. Throw errors when property or relationship cannot be mapped, don't explicitly unwrap. 3. Add extensive schema mapping and migration tests. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 15:32:36 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#492