starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-09-03 08:27:31 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

[PR #301] [MERGED] Resolve source entity and managed object attributes by name #488

New Issue
Closed
opened 2025-12-29 15:32:35 +01:00 by adam · 0 comments
adam commented 2025-12-29 15:32:35 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/301
Author: @iby
Created: 1/13/2019
Status: ✅ Merged
Merged: 1/16/2019
Merged by: @JohnEstropia

Base: develop ← Head: develop

📝 Commits (2)

  • ac8304f Resolve source entity and managed object attributes by name
  • 46ab70b Update TravisCI base image to Xcode 10

📊 Changes

4 files changed (+93 additions, -85 deletions)

View changed files

📝 .travis.yml (+14 -14)
📝 Sources/CustomSchemaMappingProvider.swift (+46 -47)
📝 Sources/NSEntityDescription+Migration.swift (+22 -16)
📝 Sources/NSManagedObjectModel+Migration.swift (+11 -8)

📄 Description

Fixes #300 – see it for details. Also improves the use of whitespace consistency across the CustomSchemaMappingProvider.swift and uses method names for cs_resolve… over cs_resolved… for better alignment with Swift API Design Guidelines.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/301 **Author:** [@iby](https://github.com/iby) **Created:** 1/13/2019 **Status:** ✅ Merged **Merged:** 1/16/2019 **Merged by:** [@JohnEstropia](https://github.com/JohnEstropia) **Base:** `develop` ← **Head:** `develop` --- ### 📝 Commits (2) - [`ac8304f`](https://github.com/JohnEstropia/CoreStore/commit/ac8304f97786cadaca8e3c6846e06d8beab5d728) Resolve source entity and managed object attributes by name - [`46ab70b`](https://github.com/JohnEstropia/CoreStore/commit/46ab70b839f06123cfcfdc3763786946900d1f97) Update TravisCI base image to Xcode 10 ### 📊 Changes **4 files changed** (+93 additions, -85 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+14 -14) 📝 `Sources/CustomSchemaMappingProvider.swift` (+46 -47) 📝 `Sources/NSEntityDescription+Migration.swift` (+22 -16) 📝 `Sources/NSManagedObjectModel+Migration.swift` (+11 -8) </details> ### 📄 Description Fixes #300 – see it for details. Also improves the use of whitespace consistency across the `CustomSchemaMappingProvider.swift` and uses method names for `cs_resolve…` over `cs_resolved…` for better alignment with [Swift API Design Guidelines](https://swift.org/documentation/api-design-guidelines). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 15:32:35 +01:00
adam closed this issue 2025-12-29 15:32:35 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#488