starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-01-11 20:00:30 +01:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

[PR #287] [MERGED] [ListMonitor] Fix performance of subscript(safeSectionIndex:safeItemIndex:). #486

New Issue
Closed
opened 2025-12-29 15:32:34 +01:00 by adam · 0 comments
adam commented 2025-12-29 15:32:34 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/287
Author: @ruslanskorb
Created: 11/24/2018
Status: ✅ Merged
Merged: 12/6/2018
Merged by: @JohnEstropia

Base: develop ← Head: list-monitor-subscript-performance

📝 Commits (1)

  • ff8fbae [ListMonitor] [subscript(safeSectionIndex:safeItemIndex:)] Use subscript(indexPath:) after the validation of sectionIndex and itemIndex to get an object.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Sources/ListMonitor.swift (+1 -1)

📄 Description

There is a performance problem in Swift when getting an object from the Objective-C array with a large number of objects using subscript. It requires casting the array between Objective-C and Swift, that is pretty slow.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/287 **Author:** [@ruslanskorb](https://github.com/ruslanskorb) **Created:** 11/24/2018 **Status:** ✅ Merged **Merged:** 12/6/2018 **Merged by:** [@JohnEstropia](https://github.com/JohnEstropia) **Base:** `develop` ← **Head:** `list-monitor-subscript-performance` --- ### 📝 Commits (1) - [`ff8fbae`](https://github.com/JohnEstropia/CoreStore/commit/ff8fbae5682b992dae28d6e46bd8267b447880ca) [ListMonitor] [subscript(safeSectionIndex:safeItemIndex:)] Use `subscript(indexPath:)` after the validation of `sectionIndex` and `itemIndex` to get an object. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Sources/ListMonitor.swift` (+1 -1) </details> ### 📄 Description There is a performance problem in Swift when getting an object from the Objective-C array with a large number of objects using subscript. It requires casting the array between Objective-C and Swift, that is pretty slow. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 15:32:34 +01:00
adam closed this issue 2025-12-29 15:32:34 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#486
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?