[PR #115] [MERGED] Import unique objects in the same order as the array of import sources (with fix for potential duplicates) #463

New Issue

Closed

opened 2025-12-29 15:32:17 +01:00 by adam · 0 comments

adam commented 2025-12-29 15:32:17 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/115
Author: @andriichernenko
Created: 10/23/2016
Status: ✅ Merged
Merged: 11/11/2016
Merged by: @JohnEstropia

Base: swift3_develop ← Head: import-unique-objects-order

---

📝 Commits (3)

• 4c3bec2 fix duplication when using importUniqueObjects with non-unique import sources
• 970957c Merge branch 'duplicate-import-fix' into import-unique-objects-order
• d2e78a7 add test for the order of unique object import

📊 Changes

2 files changed (+152 additions, -36 deletions)

View changed files

📝 CoreStoreTests/ImportTests.swift (+117 -0)
📝 Sources/Importing/BaseDataTransaction+Importing.swift (+35 -36)

📄 Description

Currently according to the documentation import of unique objects occurs in arbitrary order.

This behavior is different from the import of non-unique objects which might be unexpected. Furthermore, maintaining the order might be useful in some cases.

This pull request modifies importUniqueObjects(...) method to ensure that the order of import sources, order of import method calls and the order of imported objects in the returned array are the same.

This pull request is #109 combined with #111 which fixes the problem when duplicate objects are created if the array of input sources contains multiple items with the same ID.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/115 **Author:** [@andriichernenko](https://github.com/andriichernenko) **Created:** 10/23/2016 **Status:** ✅ Merged **Merged:** 11/11/2016 **Merged by:** [@JohnEstropia](https://github.com/JohnEstropia) **Base:** `swift3_develop` ← **Head:** `import-unique-objects-order` --- ### 📝 Commits (3) - [`4c3bec2`](https://github.com/JohnEstropia/CoreStore/commit/4c3bec287c0789407522ef9417fbdf6be260f2e9) fix duplication when using importUniqueObjects with non-unique import sources - [`970957c`](https://github.com/JohnEstropia/CoreStore/commit/970957cbc2ffa979b07c4bbedb80a67eb473f8d1) Merge branch 'duplicate-import-fix' into import-unique-objects-order - [`d2e78a7`](https://github.com/JohnEstropia/CoreStore/commit/d2e78a70e1757515b91f659e6bba1b63988f4981) add test for the order of unique object import ### 📊 Changes **2 files changed** (+152 additions, -36 deletions) <details> <summary>View changed files</summary> 📝 `CoreStoreTests/ImportTests.swift` (+117 -0) 📝 `Sources/Importing/BaseDataTransaction+Importing.swift` (+35 -36) </details> ### 📄 Description Currently according to the documentation import of unique objects occurs in arbitrary order. This behavior is different from the import of non-unique objects which might be unexpected. Furthermore, maintaining the order might be useful in some cases. This pull request modifies importUniqueObjects(...) method to ensure that the order of import sources, order of import method calls and the order of imported objects in the returned array are the same. This pull request is #109 combined with #111 which fixes the problem when duplicate objects are created if the array of input sources contains multiple items with the same ID. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 15:32:17 +01:00

adam closed this issue 2025-12-29 15:32:17 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#463