starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-01-11 20:00:30 +01:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

[PR #104] [MERGED] Fixes #98 (deadlock when merge happens while main queue is querying) #459

New Issue
Closed
opened 2025-12-29 15:32:15 +01:00 by adam · 0 comments
adam commented 2025-12-29 15:32:15 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/104
Author: @colinmorelli
Created: 9/29/2016
Status: ✅ Merged
Merged: 9/30/2016
Merged by: @JohnEstropia

Base: develop ← Head: feature/sync-transaction-async-merge

📝 Commits (1)

  • 8be2037 Fixes #98 (deadlock when merge happens while main queue is querying)

📊 Changes

3 files changed (+33 additions, -7 deletions)

View changed files

📝 CoreStore.xcodeproj/project.xcworkspace/xcshareddata/CoreStore.xcscmblueprint (+2 -2)
📝 Sources/Internal/NSManagedObjectContext+Transaction.swift (+4 -4)
📝 Sources/Transactions/SynchronousDataTransaction.swift (+27 -1)

📄 Description

Feel free to let me know if you want to accomplish this differently.

Not quite sure how you want to approach tests for this, given that the only way (I can think of) to test the negative case is to intentionally create a deadlock in tests...

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/104 **Author:** [@colinmorelli](https://github.com/colinmorelli) **Created:** 9/29/2016 **Status:** ✅ Merged **Merged:** 9/30/2016 **Merged by:** [@JohnEstropia](https://github.com/JohnEstropia) **Base:** `develop` ← **Head:** `feature/sync-transaction-async-merge` --- ### 📝 Commits (1) - [`8be2037`](https://github.com/JohnEstropia/CoreStore/commit/8be20370d5e4f2cea3dbfec4feafafe8dd488fef) Fixes #98 (deadlock when merge happens while main queue is querying) ### 📊 Changes **3 files changed** (+33 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `CoreStore.xcodeproj/project.xcworkspace/xcshareddata/CoreStore.xcscmblueprint` (+2 -2) 📝 `Sources/Internal/NSManagedObjectContext+Transaction.swift` (+4 -4) 📝 `Sources/Transactions/SynchronousDataTransaction.swift` (+27 -1) </details> ### 📄 Description Feel free to let me know if you want to accomplish this differently. Not quite sure how you want to approach tests for this, given that the only way (I can think of) to test the negative case is to intentionally create a deadlock in tests... --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 15:32:15 +01:00
adam closed this issue 2025-12-29 15:32:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#459
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?