[PR #38] [MERGED] Add support for tvOS #452

New Issue

Closed

opened 2025-12-29 15:32:13 +01:00 by adam · 0 comments

adam commented 2025-12-29 15:32:13 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/38
Author: @Jeehut
Created: 1/17/2016
Status: ✅ Merged
Merged: 1/19/2016
Merged by: @JohnEstropia

Base: master ← Head: feature/tvOS_support

---

📝 Commits (2)

• 9322371 Use tvOS_support feature branch of GCDKit (Carthage + git submodules)
• 9081b36 Add tvOS target + Configure target + Add shared scheme for tvOS

📊 Changes

6 files changed (+447 additions, -5 deletions)

View changed files

📝 .gitmodules (+1 -1)
📝 Cartfile (+1 -1)
📝 Cartfile.resolved (+1 -1)
📝 Carthage/Checkouts/GCDKit (+1 -1)
📝 CoreStore.xcodeproj/project.pbxproj (+344 -1)
➕ CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore tvOS.xcscheme (+99 -0)

📄 Description

I did all steps for this project (and even the dependency GCDKit, see here) to work as a tvOS framework and tried to apply the same structure as with the other targets. It's building fine for me so I think this can be merged after a short review. Shouldn't break anything.

I have experienced an issue with the tvOS test target though. I think it's because on tvOS the document paths are a little different. This should be solved but can also be done after merging this – I suggest merging this first and create an issue afterwards. Maybe this pull request form AERecord helps solving the issue, looks similar to me.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/38 **Author:** [@Jeehut](https://github.com/Jeehut) **Created:** 1/17/2016 **Status:** ✅ Merged **Merged:** 1/19/2016 **Merged by:** [@JohnEstropia](https://github.com/JohnEstropia) **Base:** `master` ← **Head:** `feature/tvOS_support` --- ### 📝 Commits (2) - [`9322371`](https://github.com/JohnEstropia/CoreStore/commit/9322371224a37514bfdb33df4054795443560901) Use tvOS_support feature branch of GCDKit (Carthage + git submodules) - [`9081b36`](https://github.com/JohnEstropia/CoreStore/commit/9081b36cca31a9a164b307221f52e7ea9af643d2) Add tvOS target + Configure target + Add shared scheme for tvOS ### 📊 Changes **6 files changed** (+447 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `.gitmodules` (+1 -1) 📝 `Cartfile` (+1 -1) 📝 `Cartfile.resolved` (+1 -1) 📝 `Carthage/Checkouts/GCDKit` (+1 -1) 📝 `CoreStore.xcodeproj/project.pbxproj` (+344 -1) ➕ `CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore tvOS.xcscheme` (+99 -0) </details> ### 📄 Description I did all steps for this project (and even the dependency GCDKit, see [here](https://github.com/JohnEstropia/GCDKit/pull/8)) to work as a tvOS framework and tried to apply the same structure as with the other targets. It's building fine for me so I think this can be merged after a short review. Shouldn't break anything. I have experienced an issue with the tvOS test target though. I think it's because on tvOS the document paths are a little different. This should be solved but can also be done after merging this – I suggest merging this first and create an issue afterwards. Maybe [this](https://github.com/tadija/AERecord/pull/19) pull request form AERecord helps solving the issue, looks similar to me. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 15:32:13 +01:00

adam closed this issue 2025-12-29 15:32:13 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#452