fetchAll in ListPublisher observer doesnt get new data #417

New Issue

Closed

opened 2025-12-29 15:31:18 +01:00 by adam · 14 comments

adam commented 2025-12-29 15:31:18 +01:00

Owner

Copy Link

Originally created by @imrobbyrc on GitHub (Jul 27, 2023).

hi @JohnEstropia, i have some problem about corestore observer, can you help me?

this my method when fetch data from server and save it into database

try! Omni.dataStack.perform(synchronous: { transaction in
    try! Omni.deactivateAll(transaction: transaction,
                            objects: [Omni.Group.self, Omni.Variant.self, Omni.Product.self,
                                      Omni.Modifier.self, Omni.ModifierGroup.self])

    let groups = try! transaction.importUniqueObjects(Into<Omni.Group>(),
                                                      sourceArray: json["groups"].arrayValue)

    let products = try! transaction.importUniqueObjects(Into<Omni.Product>(),
                                             sourceArray: json["products"].arrayValue)

    let productMapping = products.reduce(into: [Int: Omni.Product]()) { (result, object) in
        result[object.id] = object
    }
    
    let groupMapping = groups.reduce(into: [Int: Omni.Group]()) { (result, object) in
        result[object.id] = object
    }

    _ = try! transaction.importUniqueObjects(
        Into<Omni.Variant>(),
        /**
         json["variants"] represents a list of variant objects obtained from the API.
         JSON Structure:
         [
             {
                "id": Int,
                "code": String,
                "name": String,
                ....
             },
         ]
         Example File: Tests/Resources/JSONFiles/inventories_with_no_modifiers.json
         */
        sourceArray: json["variants"].arrayValue, preProcess: { mapping in
            var variantMapping = [Int: JSON]()
            for (key, variantJSON) in mapping {
                guard var dict = variantJSON.dictionaryObject else { continue }
                if let productId = variantJSON["product_id"].int {
                    dict["product_object"] = productMapping[productId]
                }

                var groupObjects = Set<Omni.Group>()
                for groupId in variantJSON["groups"].arrayValue {
                    if let group = groupMapping[groupId.intValue] {
                        groupObjects.insert(group)
                    }
                }

                dict["group_objects"] = groupObjects
                variantMapping[key] = JSON(dict)
            }
            return variantMapping
        }
    )
})

and i add new observer in viewcontroller to notify when variant get updated, so i will fetch all groups data, but groups data is not get the latest one

variantPublisher.addObserver(self, notifyInitial: true) { [weak self] publisher in
    guard let self else { return }
    let groups = try! Omni.dataStack.fetchAll(
        From<Omni.Group>()
            .where(\.$isActive == true && \.$typeValue == GroupTypes.regular.rawValue)
            .orderBy(.ascending(\.$position))
    )
    self.categories = CategoryViewModel.forDisplay(groups: groups)
}

Originally created by @imrobbyrc on GitHub (Jul 27, 2023). hi @JohnEstropia, i have some problem about corestore observer, can you help me? this my method when fetch data from server and save it into database ```swift try! Omni.dataStack.perform(synchronous: { transaction in try! Omni.deactivateAll(transaction: transaction, objects: [Omni.Group.self, Omni.Variant.self, Omni.Product.self, Omni.Modifier.self, Omni.ModifierGroup.self]) let groups = try! transaction.importUniqueObjects(Into<Omni.Group>(), sourceArray: json["groups"].arrayValue) let products = try! transaction.importUniqueObjects(Into<Omni.Product>(), sourceArray: json["products"].arrayValue) let productMapping = products.reduce(into: [Int: Omni.Product]()) { (result, object) in result[object.id] = object } let groupMapping = groups.reduce(into: [Int: Omni.Group]()) { (result, object) in result[object.id] = object } _ = try! transaction.importUniqueObjects( Into<Omni.Variant>(), /** json["variants"] represents a list of variant objects obtained from the API. JSON Structure: [ { "id": Int, "code": String, "name": String, .... }, ] Example File: Tests/Resources/JSONFiles/inventories_with_no_modifiers.json */ sourceArray: json["variants"].arrayValue, preProcess: { mapping in var variantMapping = [Int: JSON]() for (key, variantJSON) in mapping { guard var dict = variantJSON.dictionaryObject else { continue } if let productId = variantJSON["product_id"].int { dict["product_object"] = productMapping[productId] } var groupObjects = Set<Omni.Group>() for groupId in variantJSON["groups"].arrayValue { if let group = groupMapping[groupId.intValue] { groupObjects.insert(group) } } dict["group_objects"] = groupObjects variantMapping[key] = JSON(dict) } return variantMapping } ) }) ``` and i add new observer in viewcontroller to notify when variant get updated, so i will fetch all groups data, but groups data is not get the latest one ```swift variantPublisher.addObserver(self, notifyInitial: true) { [weak self] publisher in guard let self else { return } let groups = try! Omni.dataStack.fetchAll( From<Omni.Group>() .where(\.$isActive == true && \.$typeValue == GroupTypes.regular.rawValue) .orderBy(.ascending(\.$position)) ) self.categories = CategoryViewModel.forDisplay(groups: groups) }

adam closed this issue 2025-12-29 15:31:18 +01:00

adam commented 2025-12-29 15:31:20 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 27, 2023):

the result between fetchAll between fetchAll+ Where is different, all data should have isActive = true, but when i use where clause it only return 2 data, i have 3 active data with fetchAll only

@imrobbyrc commented on GitHub (Jul 27, 2023): the result between fetchAll between fetchAll+ Where is different, all data should have isActive = true, but when i use where clause it only return 2 data, i have 3 active data with fetchAll only <img width="496" alt="Screen Shot 2023-07-27 at 22 48 54" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/5d9f5abf-1c92-4b79-8928-938efaf8cf2b"> <img width="501" alt="Screen Shot 2023-07-27 at 22 49 08" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/1761cbc9-dae7-4663-b99a-8f3697eaecdb">

adam commented 2025-12-29 15:31:20 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

Why do you observe on variantPublisher but fetch different objects inside the observer handler? Your observer handler will run only on the changes affecting whatever predicate you assigned to variantPublisher, so you should be using the publisher.snapshot passed through the observer closure.

@JohnEstropia commented on GitHub (Jul 28, 2023): Why do you observe on `variantPublisher` but fetch different objects inside the observer handler? Your observer handler will run only on the changes affecting whatever predicate you assigned to `variantPublisher`, so you should be using the `publisher.snapshot` passed through the observer closure.

adam commented 2025-12-29 15:31:21 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

thanks for reply @JohnEstropia, i fetch different objects because variant have relation with groups, i need to know what groups that available for new data. i can use publisher.snapshot, but i need to iterrate all variants to get correct group

@imrobbyrc commented on GitHub (Jul 28, 2023): thanks for reply @JohnEstropia, i fetch different objects because variant have relation with groups, i need to know what groups that available for new data. i can use `publisher.snapshot`, but i need to iterrate all variants to get correct group <img width="539" alt="Screen Shot 2023-07-28 at 09 08 10" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/918e258a-74f1-4307-82aa-1203ca5f6abc">

adam commented 2025-12-29 15:31:21 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

Your Variant publisher will not be notified even if any of their Groups are updated. You need to "ping" something in your Variant properties to update when their Group changes. Something like a lastGroupUpdateDate

@JohnEstropia commented on GitHub (Jul 28, 2023): Your `Variant` publisher will not be notified even if any of their `Group`s are updated. You need to "ping" something in your `Variant` properties to update when their `Group` changes. Something like a `lastGroupUpdateDate`

adam commented 2025-12-29 15:31:21 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

even i update groups in Variant ImportableUniqueObject protocol, my Variant publisher will not be notified?

@imrobbyrc commented on GitHub (Jul 28, 2023): even i update groups in `Variant` `ImportableUniqueObject` protocol, my `Variant` publisher will not be notified? <img width="755" alt="Screen Shot 2023-07-28 at 09 36 25" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/7e98802a-5c5c-40e3-8912-57fb7a1fe5b5">

adam commented 2025-12-29 15:31:22 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

if i change my publisher closure to this, it will get a correct data instead of i use .where(\._isActive == true)

@imrobbyrc commented on GitHub (Jul 28, 2023): if i change my publisher closure to this, it will get a correct data instead of i use `.where(\._isActive == true)` <img width="572" alt="Screen Shot 2023-07-28 at 09 39 55" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/2beb5977-ca74-40bc-ad91-5119390a536c">

adam commented 2025-12-29 15:31:22 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

even i update groups in Variant ImportableUniqueObject protocol, my Variant publisher will not be notified?

Yes, because the Variant.group instances do not change, which means the ListPublisher<Variant> will not have a difference.

I'm not sure how the fetchAll predicate is related to this observer and how it's behaving different depending on the predicate. Can you show what your predicate is for variantPublisher?

@JohnEstropia commented on GitHub (Jul 28, 2023): > even i update groups in Variant ImportableUniqueObject protocol, my Variant publisher will not be notified? Yes, because the `Variant.group` instances do not change, which means the `ListPublisher<Variant>` will not have a difference. I'm not sure how the `fetchAll` predicate is related to this observer and how it's behaving different depending on the predicate. Can you show what your predicate is for `variantPublisher`?

adam commented 2025-12-29 15:31:23 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

You're also using notifyInitial: true which will run the closure immediately. Are you sure that you are looking at the closure after the transaction?

@JohnEstropia commented on GitHub (Jul 28, 2023): You're also using `notifyInitial: true` which will run the closure immediately. Are you sure that you are looking at the closure *after* the transaction?

adam commented 2025-12-29 15:31:23 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

i see, thats why observer doesnt get notified. thankyou

sure, this my variantPublisher code, just fetchAll and sorting it

@imrobbyrc commented on GitHub (Jul 28, 2023): i see, thats why observer doesnt get notified. thankyou sure, this my variantPublisher code, just fetchAll and sorting it <img width="720" alt="Screen Shot 2023-07-28 at 09 54 43" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/d82f10f1-c333-4afb-8114-e50752ac9e6b">

adam commented 2025-12-29 15:31:24 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

You're also using notifyInitial: true which will run the closure immediately. Are you sure that you are looking at the closure after the transaction?

i think the problem is not notifyInitial: true, because in first load i got a correct data, data will be break if i trigger variant update by using pull to refresh

@imrobbyrc commented on GitHub (Jul 28, 2023): > You're also using `notifyInitial: true` which will run the closure immediately. Are you sure that you are looking at the closure _after_ the transaction? i think the problem is not `notifyInitial: true`, because in first load i got a correct data, data will be break if i trigger variant update by using pull to refresh

adam commented 2025-12-29 15:31:24 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

I see. You should also be careful because sorting with relationship keys only work on the initial list, but not on updates. In general you should avoid relying on relationships when it comes to ListPublisher (NSFetchedResultsController) predicates because they are only reevaluated one level from the original Entity type

@JohnEstropia commented on GitHub (Jul 28, 2023): I see. You should also be careful because sorting with relationship keys only work on the initial list, but not on updates. In general you should avoid relying on relationships when it comes to ListPublisher (NSFetchedResultsController) predicates because they are only reevaluated one level from the original Entity type

adam commented 2025-12-29 15:31:24 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

I see. You should also be careful because sorting with relationship keys only work on the initial list, but not on updates. In general you should avoid relying on relationships when it comes to ListPublisher (NSFetchedResultsController) predicates because they are only reevaluated one level from the original Entity type

oke @JohnEstropia thanks for reminded me, do we have utilities for combine two observer in coreStore?

@imrobbyrc commented on GitHub (Jul 28, 2023): > I see. You should also be careful because sorting with relationship keys only work on the initial list, but not on updates. In general you should avoid relying on relationships when it comes to ListPublisher (NSFetchedResultsController) predicates because they are only reevaluated one level from the original Entity type oke @JohnEstropia thanks for reminded me, do we have utilities for combine two observer in coreStore?

adam commented 2025-12-29 15:31:26 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Jul 28, 2023):

There's no performant way to observe on relationships (i.e. foreign table) so my recommended approach would be to add a private field to Variant that your imported entity can update everytime the Group relationship is imported from it.

@JohnEstropia commented on GitHub (Jul 28, 2023): There's no performant way to observe on relationships (i.e. foreign table) so my recommended approach would be to add a private field to `Variant` that your imported entity can update everytime the `Group` relationship is imported from it.

adam commented 2025-12-29 15:31:26 +01:00

Author

Owner

Copy Link

@imrobbyrc commented on GitHub (Jul 28, 2023):

There's no performant way to observe on relationships (i.e. foreign table) so my recommended approach would be to add a private field to Variant that your imported entity can update everytime the Group relationship is imported from it.

i see thankyou @JohnEstropia , i will research new approach before going to use your suggestion

@imrobbyrc commented on GitHub (Jul 28, 2023): > There's no performant way to observe on relationships (i.e. foreign table) so my recommended approach would be to add a private field to `Variant` that your imported entity can update everytime the `Group` relationship is imported from it. i see thankyou @JohnEstropia , i will research new approach before going to use your suggestion

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#417