starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-07-21 20:18:35 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

Supporting static and dynamic linking in Swift package manifests #367

New Issue
Closed
opened 2025-12-29 15:30:09 +01:00 by adam · 3 comments
adam commented 2025-12-29 15:30:09 +01:00
Owner
Copy Link
Copy Source

Originally created by @tackgyu on GitHub (Jul 16, 2021).

In its package manifests, supporting library types are specified as static:

https://github.com/JohnEstropia/CoreStore/blob/9cc616f7208d79c7879bef0b240c94d01b6c6509/Package.swift#L35

From documents Apple provides by unspecifying its type, Xcode can choose whether to link the library statically or dynamically (https://developer.apple.com/documentation/swift_packages/product/2878196-library), so CoreStore can support both linkage types? If so, I'd like to contribute.

Originally created by @tackgyu on GitHub (Jul 16, 2021). In its package manifests, supporting library types are specified as `static`: https://github.com/JohnEstropia/CoreStore/blob/9cc616f7208d79c7879bef0b240c94d01b6c6509/Package.swift#L35 From documents Apple provides by unspecifying its type, Xcode can choose whether to link the library statically or dynamically (https://developer.apple.com/documentation/swift_packages/product/2878196-library), so CoreStore can support both linkage types? If so, I'd like to contribute.
adam closed this issue 2025-12-29 15:30:10 +01:00
adam commented 2025-12-29 15:30:11 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (Jul 19, 2021):

@tackgyu Thank you for looking into it! I think it should be fine to remove it. Do you want to make the PR?

@JohnEstropia commented on GitHub (Jul 19, 2021): @tackgyu Thank you for looking into it! I think it should be fine to remove it. Do you want to make the PR?
adam commented 2025-12-29 15:30:11 +01:00
Author
Owner
Copy Link
Copy Source

@tackgyu commented on GitHub (Jul 19, 2021):

@JohnEstropia Sure, let me post it

@tackgyu commented on GitHub (Jul 19, 2021): @JohnEstropia Sure, let me post it
adam commented 2025-12-29 15:30:12 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (Jul 20, 2021):

merged to develop, thanks!

@JohnEstropia commented on GitHub (Jul 20, 2021): merged to develop, thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#367