Transactions not saving changes #340

New Issue

adam · 2025-12-29T15:29:31+01:00

adam commented

2025-12-29 15:29:31 +01:00

Originally created by @iby on GitHub (Aug 28, 2020).

Either I'm doing something stupid or got a really weird one… The following is performed on the main thread, tried with waitForAllObservers: false and asynchronous. It runs fine, other observers get notified of changes, all goes smoothly. As soon as I reload the app I see models showing old unmodified data.

try CoreStoreDefaults.dataStack.perform(synchronous: { transaction in
    guard let model = transaction.edit(model) else { throw ModelError.cannotEdit }
    Swift.print(">>>", "transaction.hasChanges: \(transaction.hasChanges), model.hasChanges: \(model.hasChanges), equal: \(model.exportURL == newExportURL)")
    model.exportURL = newExportURL
    Swift.print("<<<", "transaction.hasChanges: \(transaction.hasChanges), model.hasChanges: \(model.hasChanges), equal: \(model.exportURL == newExportURL)")
})
// >>> transaction.hasChanges: false, model.hasChanges: false, equal: false
// <<< transaction.hasChanges: false, model.hasChanges: true, equal: true

What's weird is that model reports changes after updating, but transaction isn't. The model object looks as follows:

public final class Model: NSManagedObject {
    @NSManaged public var date: Date
    @NSManaged public var documentURL: URL?
    @NSManaged public var exportURL: URL
}

Can you think of anything what might be causing this?

Originally created by @iby on GitHub (Aug 28, 2020). Either I'm doing something stupid or got a really weird one… The following is performed on the main thread, tried with `waitForAllObservers: false` and asynchronous. It runs fine, other observers get notified of changes, all goes smoothly. As soon as I reload the app I see models showing old unmodified data. ```swift try CoreStoreDefaults.dataStack.perform(synchronous: { transaction in guard let model = transaction.edit(model) else { throw ModelError.cannotEdit } Swift.print(">>>", "transaction.hasChanges: \(transaction.hasChanges), model.hasChanges: \(model.hasChanges), equal: \(model.exportURL == newExportURL)") model.exportURL = newExportURL Swift.print("<<<", "transaction.hasChanges: \(transaction.hasChanges), model.hasChanges: \(model.hasChanges), equal: \(model.exportURL == newExportURL)") }) // >>> transaction.hasChanges: false, model.hasChanges: false, equal: false // <<< transaction.hasChanges: false, model.hasChanges: true, equal: true ``` What's weird is that model reports changes after updating, but transaction isn't. The model object looks as follows: ```swift public final class Model: NSManagedObject { @NSManaged public var date: Date @NSManaged public var documentURL: URL? @NSManaged public var exportURL: URL } ``` Can you think of anything what might be causing this?

adam closed this issue

2025-12-29 15:29:31 +01:00

adam commented

2025-12-29 15:29:32 +01:00

@iby commented on GitHub (Aug 28, 2020):

Ah yes, I'm an epic moron. Never mind me… 🤦‍♂️

@iby commented on GitHub (Aug 28, 2020): Ah yes, I'm an epic moron. Never mind me… 🤦‍♂️

adam commented

2025-12-29 15:29:32 +01:00

@gardyna commented on GitHub (Dec 10, 2020):

@ianbytchek thanks for the helpfull comment. can you please tell me what was wrong?

@gardyna commented on GitHub (Dec 10, 2020): @ianbytchek thanks for the helpfull comment. can you please tell me what was wrong?

adam commented

2025-12-29 15:29:33 +01:00

@iby commented on GitHub (Dec 10, 2020):

To be honest I don't remember, but I think I was editing a model that was not saved.

@iby commented on GitHub (Dec 10, 2020): To be honest I don't remember, but I think I was editing a model that was not saved.

adam referenced this issue

2025-12-29 15:32:40 +01:00

[PR #340] [MERGED] Added Support for Swift 5 #493

Sign in to join this conversation.

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#340