Identifiable <=> UniqueIDType mapping / interaction #331

New Issue

2025-12-29T15:29:17+01:00

adam commented

2025-12-29 15:29:17 +01:00

Originally created by @IdoRabin on GitHub (Jun 2, 2020).

Considering the introduction of identifiable is swift

one can imagine an extension for ImportableUniqueObject leveraging situations where ImportSource is Identifiable, using ImportSource.ID in relation to UniqueIDType, uniqueIDKeyPath and uniqueIDValue

I've implemented a crude base class for a DBTable, but am sure one can create a much better thingie as an extension to the ImportableUniqueObject protocol..

class DBTable<Entity:Codable & Hashable & Identifiable, DBEntity:NSManagedObject & ImportableUniqueObject> {
...
}

Originally created by @IdoRabin on GitHub (Jun 2, 2020). Considering the introduction of `identifiable` is swift one can imagine an extension for `ImportableUniqueObject` leveraging situations where `ImportSource is Identifiable`, using `ImportSource.ID` in relation to `UniqueIDType`, `uniqueIDKeyPath` and `uniqueIDValue` I've implemented a crude base class for a DBTable, but am sure one can create a much better thingie as an extension to the `ImportableUniqueObject` protocol.. ``` class DBTable<Entity:Codable & Hashable & Identifiable, DBEntity:NSManagedObject & ImportableUniqueObject> { ... } ```

adam added the question label 2025-12-29 15:29:17 +01:00

adam commented

2025-12-29 15:29:19 +01:00

@JohnEstropia commented on GitHub (Jun 3, 2020):

@IdoRabin I'm sorry, did you have any question or was there something not working for you?
If you were asking how to do this, you'll have to declare:

extension ImportableUniqueObject where Self: Identifiable {
    var id: UniqueIDType: {
        return self.uniqueIDValue
    }
}

somewhere in your codebase.

@JohnEstropia commented on GitHub (Jun 3, 2020): @IdoRabin I'm sorry, did you have any question or was there something not working for you? If you were asking how to do this, you'll have to declare: ```swift extension ImportableUniqueObject where Self: Identifiable { var id: UniqueIDType: { return self.uniqueIDValue } } ``` somewhere in your codebase.

adam commented

2025-12-29 15:29:19 +01:00

@JohnEstropia commented on GitHub (Jun 3, 2020):

Also to add, CoreStore intentionally does not implement Identifiable by default as it is a use-case dependent semantic.

For example, you are free to use multiple properties as the ID:

class Person: NSManagedObject: Identifiable {
    @NSManaged var firstName: String
    @NSManaged var lastName: String
    // ...

    struct ID: Hashable {
        var firstName: String
        var lastName: String
    }

    var id: ID {
        return ID(firstName: self.firstName, lastName: self.lastName)
    }
}

@JohnEstropia commented on GitHub (Jun 3, 2020): Also to add, CoreStore intentionally does not implement `Identifiable` by default as it is a use-case dependent semantic. For example, you are free to use multiple properties as the ID: ```swift class Person: NSManagedObject: Identifiable { @NSManaged var firstName: String @NSManaged var lastName: String // ... struct ID: Hashable { var firstName: String var lastName: String } var id: ID { return ID(firstName: self.firstName, lastName: self.lastName) } } ```

adam commented

2025-12-29 15:29:20 +01:00

@IdoRabin commented on GitHub (Sep 25, 2020):

thanks.

@IdoRabin commented on GitHub (Sep 25, 2020): thanks.

adam referenced this issue

2025-12-29 15:32:40 +01:00

[PR #331] [MERGED] Fixes #328 by specifying platform requirements in Package.swift #496

Sign in to join this conversation.

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#331