starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-07-21 20:18:35 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

fetchLimit is not working with ListPublisher #295

New Issue
Closed
opened 2025-12-29 15:28:20 +01:00 by adam · 3 comments
adam commented 2025-12-29 15:28:20 +01:00
Owner
Copy Link
Copy Source

Originally created by @EricSKCheng on GitHub (Nov 13, 2019).

First I create a ListPublisher

CoreStoreDefaults.dataStack.publishList(From<Article>()
            .orderBy(.descending(\.publishDate))
            .tweak { $0.fetchLimit = 10 })

and add a addObserver

addObserver(self) { [weak self] (listPublisher) in
            
        }

however if I add a new article to the corestore, the observer will return more than 10 items.

Originally created by @EricSKCheng on GitHub (Nov 13, 2019). First I create a ListPublisher ``` CoreStoreDefaults.dataStack.publishList(From<Article>() .orderBy(.descending(\.publishDate)) .tweak { $0.fetchLimit = 10 }) ``` and add a addObserver ``` addObserver(self) { [weak self] (listPublisher) in } ``` however if I add a new article to the corestore, the observer will return more than 10 items.
adam closed this issue 2025-12-29 15:28:20 +01:00
adam commented 2025-12-29 15:28:20 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (Nov 13, 2019):

This is a limitation of NSFetchedResultsController which also affects ListMonitor.

Fortunately, ListPublishers use diffing instead of relying on FRC update methods, so we can easily simulate the fetch limit by hand.(i.e. just truncate the unwanted items from the snapshot)

I'll post an update soon.

@JohnEstropia commented on GitHub (Nov 13, 2019): This is a limitation of `NSFetchedResultsController` which also affects `ListMonitor`. Fortunately, `ListPublisher`s use diffing instead of relying on FRC update methods, so we can easily simulate the fetch limit by hand.(i.e. just truncate the unwanted items from the snapshot) I'll post an update soon.
adam commented 2025-12-29 15:28:20 +01:00
Author
Owner
Copy Link
Copy Source

@EricSKCheng commented on GitHub (Nov 13, 2019):

Thx.

@EricSKCheng commented on GitHub (Nov 13, 2019): Thx.
adam commented 2025-12-29 15:28:21 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (Nov 14, 2019):

Implemented in develop branch 👍

@JohnEstropia commented on GitHub (Nov 14, 2019): Implemented in `develop` branch 👍
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#295