Cannot create an SQL store with a nil URL #275

New Issue

adam · 2025-12-29T15:28:04+01:00

adam commented

2025-12-29 15:28:04 +01:00

Originally created by @seanliu1 on GitHub (May 29, 2019).

This is my interface looks like

    init <T: StorageInterface>(storage: T, persistenceManager: MediaPersistenceManager) {
        do {
            try dataStack.addStorageAndWait(storage)
        } catch {
            Logger.shared.log(error: error, message: "Failed to setup CoreData")
        }
}

I want to do dependency injection, then for test, I can provide in-memory storage, in production app I can use local storage.

However I start to see once I change it to that way
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Cannot create an SQL store with a nil URL.

It looks like we always pass nil to finalURL if it comes from StorageInterface, should we have factory method based on input type to determine which constructor to use?

 _ = try self.createPersistentStoreFromStorage(
                    storage,
                    finalURL: nil,
                    finalStoreOptions: storage.storeOptions

Originally created by @seanliu1 on GitHub (May 29, 2019). This is my interface looks like ``` init <T: StorageInterface>(storage: T, persistenceManager: MediaPersistenceManager) { do { try dataStack.addStorageAndWait(storage) } catch { Logger.shared.log(error: error, message: "Failed to setup CoreData") } } ``` I want to do dependency injection, then for test, I can provide in-memory storage, in production app I can use local storage. However I start to see once I change it to that way *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Cannot create an SQL store with a nil URL. It looks like we always pass nil to finalURL if it comes from StorageInterface, should we have factory method based on input type to determine which constructor to use? ``` _ = try self.createPersistentStoreFromStorage( storage, finalURL: nil, finalStoreOptions: storage.storeOptions ```

adam added the question label 2025-12-29 15:28:04 +01:00

adam closed this issue

2025-12-29 15:28:04 +01:00

adam commented

2025-12-29 15:28:05 +01:00

@JohnEstropia commented on GitHub (May 29, 2019):

Use <T: LocalStorage> instead of <T: StorageInterface>

@JohnEstropia commented on GitHub (May 29, 2019): Use `<T: LocalStorage>` instead of `<T: StorageInterface>`

adam commented

2025-12-29 15:28:06 +01:00

@seanliu1 commented on GitHub (May 29, 2019):

how to pass InMemoryStore if we wanna to use in memory storage for unit test, since InMemoryStore does not conform to LocalStorage. Both LocalStore and InMemoryStore conforms to StorageInterface.

@seanliu1 commented on GitHub (May 29, 2019): how to pass InMemoryStore if we wanna to use in memory storage for unit test, since InMemoryStore does not conform to LocalStorage. Both LocalStore and InMemoryStore conforms to StorageInterface.

adam commented

2025-12-29 15:28:06 +01:00

@JohnEstropia commented on GitHub (May 29, 2019):

I see. If you need both then you need to implement the overloads for both.

init<T: StorageInterface>(...)
init<T: LocalStorage>(...)

@JohnEstropia commented on GitHub (May 29, 2019): I see. If you need both then you need to implement the overloads for both. ```swift init<T: StorageInterface>(...) init<T: LocalStorage>(...) ```

adam referenced this issue

2025-12-29 15:32:33 +01:00

[PR #275] [MERGED] Fix queue validation for UnsafeDataTransaction #484

Sign in to join this conversation.

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#275