starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-09-03 08:27:31 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

Using DispatchGroup leads to issue with invocation CoreStore success and failure closures. #269

New Issue
Open
opened 2025-12-29 15:28:00 +01:00 by adam · 1 comment
adam commented 2025-12-29 15:28:00 +01:00
Owner
Copy Link
Copy Source

Originally created by @matrosovDev on GitHub (May 4, 2019).

I faced with the issue that I never get code called group.leave() line. Looks like when we use DispatchGroup() waiting for all async calls but it does not call CoreStore success and failure blocks then.

let group = DispatchGroup()
        
        group.enter()
        
        
        if let workoutsDictionaries = serverResponse["other"] as? [[String: Any]] {
            
            CoreStore.perform(
                asynchronous: { (transaction) -> [WorkoutEntity]? in
                    
                    let workouts = self.offlineModeService.mergedWorkouts(from: workoutsDictionaries, transaction: transaction)
                    
                    return workouts
                    
            },
                success: { (transactionWorkouts) in
                    
                    guard let unwrappedTransactionWorkouts = transactionWorkouts else {
                        return
                    }
                    
                    let workouts = CoreStore.fetchExisting(unwrappedTransactionWorkouts)
                    
                    group.leave()
                    
                    //completion(.data(workouts))
            },
                failure: { (error) in
                    //completion(.error(StackedError.coreDataObjectSavingFailed(error: error)))
                    
                    group.leave()
            }
            )
            
        }
        
        group.wait()
Originally created by @matrosovDev on GitHub (May 4, 2019). I faced with the issue that I never get code called group.leave() line. Looks like when we use DispatchGroup() waiting for all async calls but it does not call CoreStore success and failure blocks then. ``` let group = DispatchGroup() group.enter() if let workoutsDictionaries = serverResponse["other"] as? [[String: Any]] { CoreStore.perform( asynchronous: { (transaction) -> [WorkoutEntity]? in let workouts = self.offlineModeService.mergedWorkouts(from: workoutsDictionaries, transaction: transaction) return workouts }, success: { (transactionWorkouts) in guard let unwrappedTransactionWorkouts = transactionWorkouts else { return } let workouts = CoreStore.fetchExisting(unwrappedTransactionWorkouts) group.leave() //completion(.data(workouts)) }, failure: { (error) in //completion(.error(StackedError.coreDataObjectSavingFailed(error: error))) group.leave() } ) } group.wait() ```
adam added the question label 2025-12-29 15:28:00 +01:00
adam commented 2025-12-29 15:28:00 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (May 6, 2019):

You are likely causing a deadlock as perform(asynchronous:) should never be waited on. Try to use perform(synchronous:) instead.

@JohnEstropia commented on GitHub (May 6, 2019): You are likely causing a deadlock as `perform(asynchronous:)` should never be waited on. Try to use `perform(synchronous:)` instead.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels question
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore#269