Standardize list and object observer api #254

New Issue

adam · 2025-12-29T15:27:40+01:00

adam commented

2025-12-29 15:27:40 +01:00

Originally created by @iby on GitHub (Jan 15, 2019).

Would be neat to match method signature style of:

protocol ObjectObserver {
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, willUpdateObject object: Self.ObjectEntityType)
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didUpdateObject object: Self.ObjectEntityType, changedPersistentKeys: Set<KeyPathString>)
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didDeleteObject object: Self.ObjectEntityType)
}

with:

protocol ListObserver {
    func listMonitorWillChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorDidChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorWillRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorDidRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
}

Originally created by @iby on GitHub (Jan 15, 2019). Would be neat to match method signature style of: ```swift protocol ObjectObserver { func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, willUpdateObject object: Self.ObjectEntityType) func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didUpdateObject object: Self.ObjectEntityType, changedPersistentKeys: Set<KeyPathString>) func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didDeleteObject object: Self.ObjectEntityType) } ``` with: ```swift protocol ListObserver { func listMonitorWillChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorDidChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorWillRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorDidRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) } ```

adam closed this issue

2025-12-29 15:27:41 +01:00

adam commented

2025-12-29 15:27:41 +01:00

@iby commented on GitHub (Jan 15, 2019):

Sorry, just realized it doesn't make any sense… 🤦‍♂️ Please delete.

@iby commented on GitHub (Jan 15, 2019): Sorry, just realized it doesn't make any sense… 🤦‍♂️ Please delete.

Sign in to join this conversation.

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#254