Standardize list and object observer api #254

New Issue

Closed

opened 2025-12-29 15:27:40 +01:00 by adam · 1 comment

adam commented 2025-12-29 15:27:40 +01:00

Owner

Copy Link

Copy Source

Originally created by @iby on GitHub (Jan 15, 2019).

Would be neat to match method signature style of:

protocol ObjectObserver {
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, willUpdateObject object: Self.ObjectEntityType)
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didUpdateObject object: Self.ObjectEntityType, changedPersistentKeys: Set<KeyPathString>)
    func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didDeleteObject object: Self.ObjectEntityType)
}

with:

protocol ListObserver {
    func listMonitorWillChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorDidChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorWillRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
    func listMonitorDidRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>)
}

Originally created by @iby on GitHub (Jan 15, 2019). Would be neat to match method signature style of: ```swift protocol ObjectObserver { func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, willUpdateObject object: Self.ObjectEntityType) func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didUpdateObject object: Self.ObjectEntityType, changedPersistentKeys: Set<KeyPathString>) func objectMonitor(_ monitor: CoreStore.ObjectMonitor<Self.ObjectEntityType>, didDeleteObject object: Self.ObjectEntityType) } ``` with: ```swift protocol ListObserver { func listMonitorWillChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorDidChange(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorWillRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) func listMonitorDidRefetch(_ monitor: CoreStore.ListMonitor<Self.ListEntityType>) } ```

adam closed this issue 2025-12-29 15:27:41 +01:00

adam commented 2025-12-29 15:27:41 +01:00

Author

Owner

Copy Link

Copy Source

@iby commented on GitHub (Jan 15, 2019):

Sorry, just realized it doesn't make any sense… 🤦‍♂️ Please delete.

@iby commented on GitHub (Jan 15, 2019): Sorry, just realized it doesn't make any sense… 🤦‍♂️ Please delete.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#254