mirror of
https://github.com/JohnEstropia/CoreStore.git
synced 2026-01-11 20:00:30 +01:00
Unable to submit to app store with library #22
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @demonar on GitHub (Dec 8, 2015).
Originally assigned to: @JohnEstropia on GitHub.
When trying to upload a binary to the app store that contains the library, i'm getting the error ITMS-90206, this is due to the library containing the standard swift files in it, they should be excluded to avoid the issue, if you look at the screenshots i compared this with alamofire and they exclude the libraries.
@demonar commented on GitHub (Dec 8, 2015):
To solve it you'll need to follow this solution: http://stackoverflow.com/questions/25777958/validation-error-invalid-bundle-the-bundle-at-contains-disallowed-file-fr
@JohnEstropia commented on GitHub (Dec 8, 2015):
@demonar Thanks for catching that! I pushed a 1.3.6 tag, hope it works for you now.
We always use Cocoapods for our own projects so apologies if the previous .xcproj settings wasn't stable.
@demonar commented on GitHub (Dec 8, 2015):
no worries, you'll have to add this too:
http://stackoverflow.com/questions/25777958/validation-error-invalid-bundle-the-bundle-at-contains-disallowed-file-fr
@demonar commented on GitHub (Dec 8, 2015):
if you can, revert those changes, after that i started getting an error with the GCDKit, i'll investigate the issue and give you an answer later
The first solution is ok, but it's not removing the standard libraries, we still need GCD and it's being deleted
@demonar commented on GitHub (Dec 8, 2015):
Got 1.3.6 and added GCDKit as another carthage dependency and made the trick, there can't be nested libraries, i think that the only way to make it work is to add it as a carthage dependency instead of being a module
@JohnEstropia commented on GitHub (Dec 8, 2015):
Thanks for the investigation!
I'm not sure how to reconcile Carthage's behavior without breaking builds for submodule users...
According to the discussion here and here, dependencies should be linked in the app level, which the way I understand it is to include all of them in the the main app's Cartfile.
I did try adding a Cartfile to CoreStore that includes GCDKit, but it seems that Carthage ignores it either way. You'll still have to add GCDKit to your app's Cartfile (I'll update the README to indicate this)
So it seems we have two choices,
as a build phase to their app.
I also prefer method 1, so I'll see if there is any way we can make it work without removing the submodule. If you already have a working branch ill be glad to try it out, just send a pull request.
@demonar commented on GitHub (Dec 8, 2015):
On the branch that i created GCD was a carthage dependency and it was working, the problem is that you need to support both, carthage and pods, it seems that currently some developers are having the same issue i had when they have libraries that include libraries, you could try and take a look at ReactiveCocoa, they have a couple of libraries included and there's no issue on submitting that to the app store.
They also include instructions for different kind of users.
@JohnEstropia commented on GitHub (Dec 9, 2015):
@demonar I think I can see how to do this with CoreStore. ReactiveCocoa also avoids nested libraries by linking everything through a workspace. To do the same I might need to update CoreStore's major version as I'm pretty sure it will break builds for current non-Cocoapods, non-Carthage users.
Thanks for looking into this, I really appreciate it! I hope you have your fork working for you for now because I don't know when I'll be able to push a working fix, but I'll try to get it done by next week.
@demonar commented on GitHub (Dec 9, 2015):
No worries, i'm glad to have helped on something, i think i'll be able to help giving some examples on how to integrate CoreStore and Alamofire in the future, i'm currently working on that in a project and got a really neat API class.
For now, the carthage build i have is working and i don't plan on updating it in the near future. i've been submitting test builds to itunes connect without any issues.
@JohnEstropia commented on GitHub (Dec 18, 2015):
@demonar Just to give you a heads up, I updated the project structure to use a workspace instead instead of nested projects. You can check out the 1.4.0 tag. Tell me if you have any problems!
@demonar commented on GitHub (Dec 18, 2015):
Awesome, I'll give it a try, thanks for the heads up!