ImportableUniqueObjects from nested JSON #195

New Issue

Closed

opened 2025-12-29 15:26:29 +01:00 by adam · 3 comments

adam commented 2025-12-29 15:26:29 +01:00

Owner

Copy Link

Originally created by @lepunk on GitHub (Dec 10, 2017).

Hi, this is driving me crazy. Not sure if its a bug in CoreStore or I'm doing something wrong (most likely its me)

I have 2 entities: Coin and Exchange. Coin has an "exchanges" relationship to many Exchange

My json looks something like this:

{
	"coins": [{
		"name": "Aircoin",
		"symbol": "AIR",
		"exchanges": [{
			"id": 26,
			"rank": 34,
			"name": "Yobit"
		}, {
			"id": 66,
			"rank": 75,
			"name": "Novaexchange"
		}],
		"id": 3072
	}]
}

I have the following ImportableUniqueObject extensions

extension Coin: ImportableUniqueObject {

    public typealias UniqueIDType = Int32
    public typealias ImportSource = JSON
    
    public static var uniqueIDKeyPath: String {
        return #keyPath(Coin.id)
    }
    
    public static func uniqueID(from source: JSON, in transaction: BaseDataTransaction) throws -> Int32? {
        return source["id"].int32!
    }
    
    public func update(from source: JSON, in transaction: BaseDataTransaction) throws {
        self.id = source["id"].int32!
        self.symbol = source["symbol"].string!
        self.exchanges = try! NSSet(array: transaction.importUniqueObjects(Into<Exchange>(), sourceArray: source["exchanges"].array!))
    }
}

and

extension Exchange: ImportableUniqueObject {
    
    public typealias UniqueIDType = Int32
    public typealias ImportSource = JSON
    public static var uniqueIDKeyPath: String {
        return #keyPath(Exchange.id)
    }
    
    public static func uniqueID(from source: JSON, in transaction: BaseDataTransaction) throws -> Int32? {
        return source["id"].int32!
    }
    
    public func update(from source: JSON, in transaction: BaseDataTransaction) throws {
        self.id = source["id"].int32!
        self.name = source["name"].string!
    }
}

And finally my import code is

let json = try JSON(data: r.content!)

if let coins = json["coins"].array {
    CoreStore.perform(
        asynchronous: { (transaction) -> Void in
            let _ = try! transaction.importUniqueObjects(
                Into<Coin>(),
                sourceArray: coins // make sure this is of type Array<MyPersonEntity.ImportSource>
            )
        },
        completion: { _ in
            print(self.getCoinCount())
            print(self.getExchangeCount())
            NotificationCenter.default.post(name: Notification.Name("coins_refreshed"), object: nil)
        }
    )
}

...where JSON is a SwiftyJSON object

My problem is that this code is not importing relationships correctly. If I print out the exchanges length in the Coin entity's update method it prints the correct value.

However if later on I fetch the Coin and print out the relationship's length its invalid and it varies each time i re-sync

Any help is appreciated and thanks for the amazing library

Originally created by @lepunk on GitHub (Dec 10, 2017). Hi, this is driving me crazy. Not sure if its a bug in CoreStore or I'm doing something wrong (most likely its me) I have 2 entities: Coin and Exchange. Coin has an "exchanges" relationship to many Exchange My json looks something like this: ``` { "coins": [{ "name": "Aircoin", "symbol": "AIR", "exchanges": [{ "id": 26, "rank": 34, "name": "Yobit" }, { "id": 66, "rank": 75, "name": "Novaexchange" }], "id": 3072 }] } ``` I have the following ImportableUniqueObject extensions ``` extension Coin: ImportableUniqueObject { public typealias UniqueIDType = Int32 public typealias ImportSource = JSON public static var uniqueIDKeyPath: String { return #keyPath(Coin.id) } public static func uniqueID(from source: JSON, in transaction: BaseDataTransaction) throws -> Int32? { return source["id"].int32! } public func update(from source: JSON, in transaction: BaseDataTransaction) throws { self.id = source["id"].int32! self.symbol = source["symbol"].string! self.exchanges = try! NSSet(array: transaction.importUniqueObjects(Into<Exchange>(), sourceArray: source["exchanges"].array!)) } } ``` and ``` extension Exchange: ImportableUniqueObject { public typealias UniqueIDType = Int32 public typealias ImportSource = JSON public static var uniqueIDKeyPath: String { return #keyPath(Exchange.id) } public static func uniqueID(from source: JSON, in transaction: BaseDataTransaction) throws -> Int32? { return source["id"].int32! } public func update(from source: JSON, in transaction: BaseDataTransaction) throws { self.id = source["id"].int32! self.name = source["name"].string! } } ``` And finally my import code is ``` let json = try JSON(data: r.content!) if let coins = json["coins"].array { CoreStore.perform( asynchronous: { (transaction) -> Void in let _ = try! transaction.importUniqueObjects( Into<Coin>(), sourceArray: coins // make sure this is of type Array<MyPersonEntity.ImportSource> ) }, completion: { _ in print(self.getCoinCount()) print(self.getExchangeCount()) NotificationCenter.default.post(name: Notification.Name("coins_refreshed"), object: nil) } ) } ``` ...where JSON is a SwiftyJSON object My problem is that this code is not importing relationships correctly. If I print out the exchanges length in the Coin entity's update method it prints the correct value. However if later on I fetch the Coin and print out the relationship's length its invalid and it varies each time i re-sync Any help is appreciated and thanks for the amazing library

adam closed this issue 2025-12-29 15:26:29 +01:00

adam commented 2025-12-29 15:26:29 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Dec 10, 2017):

@lepunk Just a hunch, but have you checked that your relationships have the inverse relationship set on both entities?

@JohnEstropia commented on GitHub (Dec 10, 2017): @lepunk Just a hunch, but have you checked that your relationships have the inverse relationship set on both entities?

adam commented 2025-12-29 15:26:29 +01:00

Author

Owner

Copy Link

@lepunk commented on GitHub (Dec 10, 2017):

@JohnEstropia you are my hero. spent most of my weekend figuring it out. can't believe the solution was this easy. thanks a bunch

@lepunk commented on GitHub (Dec 10, 2017): @JohnEstropia you are my hero. spent most of my weekend figuring it out. can't believe the solution was this easy. thanks a bunch

adam commented 2025-12-29 15:26:29 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Dec 10, 2017):

Wow, lucky guess :D Cheers!

@JohnEstropia commented on GitHub (Dec 10, 2017): Wow, lucky guess :D Cheers!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#195