Crash on iOS9 after refetch on sectioned listMonitor #185

New Issue

Closed

opened 2025-12-29 15:26:21 +01:00 by adam · 7 comments

adam commented 2025-12-29 15:26:21 +01:00

Owner

Copy Link

Copy Source

Originally created by @zalogatomek on GitHub (Nov 8, 2017).

So, I've added simple sectioned monitor to StackSetupDemoViewController like this:

class StackSetupDemoViewController: UITableViewController, ListObserver {
    
    let monitor = Static.facebookStack.monitorSectionedList(From<UserAccount>(), SectionBy("accountType"), OrderBy(.ascending("name")))

    @IBAction func refetch() {
        monitor.refetch(OrderBy(.ascending("name")))
    }

    typealias ListEntityType = UserAccount

    func listMonitorDidChange(_ monitor: ListMonitor<UserAccount>) {
        print("did change")
    }

    func listMonitorDidRefetch(_ monitor: ListMonitor<UserAccount>) {
        print("did refetch")
    }

I also added a UIBarButtonItem in Storyboard which performs refetch action.

Lastly, in viewWillAppear:

monitor.addObserver(self)

Now, every refetch fails with EXC_BAD_ACCESS:

I didn't try it on iOS10, but on iOS11 works ok.

Originally created by @zalogatomek on GitHub (Nov 8, 2017). So, I've added simple sectioned monitor to `StackSetupDemoViewController` like this: ```swift class StackSetupDemoViewController: UITableViewController, ListObserver { let monitor = Static.facebookStack.monitorSectionedList(From<UserAccount>(), SectionBy("accountType"), OrderBy(.ascending("name"))) @IBAction func refetch() { monitor.refetch(OrderBy(.ascending("name"))) } typealias ListEntityType = UserAccount func listMonitorDidChange(_ monitor: ListMonitor<UserAccount>) { print("did change") } func listMonitorDidRefetch(_ monitor: ListMonitor<UserAccount>) { print("did refetch") } ``` I also added a `UIBarButtonItem` in Storyboard which performs `refetch` action. Lastly, in `viewWillAppear`: ```swift monitor.addObserver(self) ``` Now, every refetch fails with `EXC_BAD_ACCESS`:  I didn't try it on iOS10, but on iOS11 works ok.

adam added the fixed label 2025-12-29 15:26:21 +01:00

adam closed this issue 2025-12-29 15:26:21 +01:00

adam commented 2025-12-29 15:26:22 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 9, 2017):

@zalogatomek Does this still happen if you add a monitor.removeObserver(self) from the observer's deinit?

@JohnEstropia commented on GitHub (Nov 9, 2017): @zalogatomek Does this still happen if you add a `monitor.removeObserver(self)` from the observer's `deinit`?

adam commented 2025-12-29 15:26:23 +01:00

Author

Owner

Copy Link

Copy Source

@zalogatomek commented on GitHub (Nov 9, 2017):

@JohnEstropia Yes, it does.

@zalogatomek commented on GitHub (Nov 9, 2017): @JohnEstropia Yes, it does.

adam commented 2025-12-29 15:26:23 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 9, 2017):

@zalogatomek Thanks, I'll investigate. Can you tell which CoreStore branch or version you are using?

@JohnEstropia commented on GitHub (Nov 9, 2017): @zalogatomek Thanks, I'll investigate. Can you tell which CoreStore branch or version you are using?

adam commented 2025-12-29 15:26:23 +01:00

Author

Owner

Copy Link

Copy Source

@zalogatomek commented on GitHub (Nov 9, 2017):

@JohnEstropia I'm on master, 4.2.2. I have also checked prototype/Swift_4_0 in some other project.

In my observation: this does not happen when using CoreStoreObject. In particular List Observer Demo uses CoreStoreObject with sectioned ListMonitor, but it works fine on iOS9.

But I can't (at least at the moment) check CoreStoreObject in mentioned project.

@zalogatomek commented on GitHub (Nov 9, 2017): @JohnEstropia I'm on `master`, `4.2.2`. I have also checked `prototype/Swift_4_0` in some other project. In my observation: this does not happen when using `CoreStoreObject`. In particular List Observer Demo uses `CoreStoreObject` with sectioned `ListMonitor`, but it works fine on iOS9. But I can't (at least at the moment) check `CoreStoreObject` in mentioned project.

adam commented 2025-12-29 15:26:23 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 9, 2017):

@zalogatomek Fixed this in the latest 4.2.3 version (master). Let me know if it works for you

@JohnEstropia commented on GitHub (Nov 9, 2017): @zalogatomek Fixed this in the latest `4.2.3` version (master). Let me know if it works for you

adam commented 2025-12-29 15:26:24 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Nov 9, 2017):

For reference, this issue also had been haunting the prototype/Swift_4_0 branch. The commit above was also merged there and I have confirmed that the Swift 4 branch is also fixed now.

@JohnEstropia commented on GitHub (Nov 9, 2017): For reference, this issue also had been haunting the `prototype/Swift_4_0` branch. The commit above was also merged there and I have confirmed that the Swift 4 branch is also fixed now.

adam commented 2025-12-29 15:26:24 +01:00

Author

Owner

Copy Link

Copy Source

@zalogatomek commented on GitHub (Nov 10, 2017):

@JohnEstropia Works great, thanks

@zalogatomek commented on GitHub (Nov 10, 2017): @JohnEstropia Works great, thanks

adam referenced this issue 2025-12-29 15:32:28 +01:00

[PR #185] [CLOSED] fixed a compile issue #469

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels fixed

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#185