Compile error with Xcode9.0 beta5 #156

New Issue

Closed

opened 2025-12-29 15:25:51 +01:00 by adam · 12 comments

adam commented 2025-12-29 15:25:51 +01:00

Owner

Copy Link

Originally created by @laeroah on GitHub (Aug 9, 2017).

Tried to compile CoreStore using xcode9.0 beta5 and got a compile error in file DataStack+Migration.swift: private func computeMigrationFromStorage<T: LocalStorage>(_ storage: T, metadata: [String: Any]) -> [(sourceModel: NSManagedObjectModel, destinationModel: NSManagedObjectModel, mappingModel: NSMappingModel, migrationType: MigrationType)]?

A PR created: https://github.com/JohnEstropia/CoreStore/pull/185

Originally created by @laeroah on GitHub (Aug 9, 2017). Tried to compile CoreStore using xcode9.0 beta5 and got a compile error in file `DataStack+Migration.swift`: `private func computeMigrationFromStorage<T: LocalStorage>(_ storage: T, metadata: [String: Any]) -> [(sourceModel: NSManagedObjectModel, destinationModel: NSManagedObjectModel, mappingModel: NSMappingModel, migrationType: MigrationType)]?`  A PR created: https://github.com/JohnEstropia/CoreStore/pull/185

adam added the irreproducibleinvestigating labels 2025-12-29 15:25:51 +01:00

adam closed this issue 2025-12-29 15:25:51 +01:00

adam commented 2025-12-29 15:25:52 +01:00

Author

Owner

Copy Link

@sidmani commented on GitHub (Aug 9, 2017):

I'm using the swift-4 branch and I don't get any compile errors on Xcode 9 beta 5. Which branch are you on?

@sidmani commented on GitHub (Aug 9, 2017): I'm using the swift-4 branch and I don't get any compile errors on Xcode 9 beta 5. Which branch are you on?

adam commented 2025-12-29 15:25:52 +01:00

Author

Owner

Copy Link

@laeroah commented on GitHub (Aug 9, 2017):

hey @sidmani
I'm using prototype/Swift_4_0 branch. Which branch are you on?

@laeroah commented on GitHub (Aug 9, 2017): hey @sidmani I'm using `prototype/Swift_4_0` branch. Which branch are you on?

adam commented 2025-12-29 15:25:53 +01:00

Author

Owner

Copy Link

@sidmani commented on GitHub (Aug 9, 2017):

@laeroah prototype/Swift_4_0 as well. I'm installing via cocoapods like so:
pod 'CoreStore', :git => 'https://github.com/JohnEstropia/CoreStore.git', :branch => 'prototype/Swift_4_0'

@sidmani commented on GitHub (Aug 9, 2017): @laeroah `prototype/Swift_4_0` as well. I'm installing via cocoapods like so: `pod 'CoreStore', :git => 'https://github.com/JohnEstropia/CoreStore.git', :branch => 'prototype/Swift_4_0'`

adam commented 2025-12-29 15:25:53 +01:00

Author

Owner

Copy Link

@laeroah commented on GitHub (Aug 9, 2017):

yeah, that's exactly how I installed too. I just downloaded the CoreStore source code and it seems to be compiling fine. I guess the problem might be on my side. May I see your podfile please?

@laeroah commented on GitHub (Aug 9, 2017): yeah, that's exactly how I installed too. I just downloaded the CoreStore source code and it seems to be compiling fine. I guess the problem might be on my side. May I see your podfile please?

adam commented 2025-12-29 15:25:54 +01:00

Author

Owner

Copy Link

@sidmani commented on GitHub (Aug 9, 2017):

That's the only relevant part- the rest is just other pods for my project. It doesn't have any other configuration (except use_frameworks!)

@sidmani commented on GitHub (Aug 9, 2017): That's the only relevant part- the rest is just other pods for my project. It doesn't have any other configuration (except `use_frameworks!`)

adam commented 2025-12-29 15:25:54 +01:00

Author

Owner

Copy Link

@laeroah commented on GitHub (Aug 9, 2017):

so strange... I will spend some more time looking into this.
If i use 3_2 branch, there's no issue compiling.

@laeroah commented on GitHub (Aug 9, 2017): so strange... I will spend some more time looking into this. If i use 3_2 branch, there's no issue compiling.

adam commented 2025-12-29 15:25:54 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Aug 10, 2017):

@laeroah
That is weird. Looking at the PR, there must be something else going on as either code should work on both Swift 3.2 and 4.0.

Some hunches:

• Do you have multiple Swift toolchains installed?
• Do you have multiple Xcode versions open at the same time?
• Do you reopen your project when git-switching between the 3.2 and 4.0 branches?

@JohnEstropia commented on GitHub (Aug 10, 2017): @laeroah That is weird. Looking at the PR, there must be something else going on as either code should work on both Swift 3.2 and 4.0. Some hunches: - Do you have multiple Swift toolchains installed? - Do you have multiple Xcode versions open at the same time? - Do you reopen your project when git-switching between the 3.2 and 4.0 branches?

adam commented 2025-12-29 15:25:55 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Aug 17, 2017):

@laeroah I think I found the cause for this error. Are you using the CoreStore Swift 4 branch and building it into your project as a Swift 3.2?
I reproduced this problem when I used the Swift 4 branch but my podfile includes:

post_install do |installer|
    installer.pods_project.targets.each do |target|
        target.build_configurations.each do |config|
            config.build_settings['ENABLE_BITCODE'] = 'NO'
            config.build_settings['SWIFT_VERSION'] = '3.2'
        end
    end
end

which builds it as Swift 3.2.

@JohnEstropia commented on GitHub (Aug 17, 2017): @laeroah I think I found the cause for this error. Are you using the CoreStore Swift 4 branch and building it into your project as a Swift 3.2? I reproduced this problem when I used the Swift 4 branch but my podfile includes: ``` post_install do |installer| installer.pods_project.targets.each do |target| target.build_configurations.each do |config| config.build_settings['ENABLE_BITCODE'] = 'NO' config.build_settings['SWIFT_VERSION'] = '3.2' end end end ``` which builds it as Swift 3.2.

adam commented 2025-12-29 15:25:55 +01:00

Author

Owner

Copy Link

@laeroah commented on GitHub (Aug 17, 2017):

hey, I didn't add config.build_settings['SWIFT_VERSION'] = '3.2' in my Podfile, but it is very possible that this is the cause. There's no issue if I start a new project and import CoreStore, so the problem must be on my side. I'm going to make sure Xcode is using swift4 instead of 3.2 and try it again.
Thank you for looking into it! much appreciated!

@laeroah commented on GitHub (Aug 17, 2017): hey, I didn't add config.build_settings['SWIFT_VERSION'] = '3.2' in my Podfile, but it is very possible that this is the cause. There's no issue if I start a new project and import CoreStore, so the problem must be on my side. I'm going to make sure Xcode is using swift4 instead of 3.2 and try it again. Thank you for looking into it! much appreciated!

adam commented 2025-12-29 15:25:55 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Aug 23, 2017):

@laeroah Have you confirmed the cause on your side? I have already resolved this on my side by adding a conditional check (something like if target == CoreStore, swift_version = 4), but I want to make sure first if this is the same cause as yours.

@JohnEstropia commented on GitHub (Aug 23, 2017): @laeroah Have you confirmed the cause on your side? I have already resolved this on my side by adding a conditional check (something like `if target == CoreStore, swift_version = 4`), but I want to make sure first if this is the same cause as yours.

adam commented 2025-12-29 15:25:55 +01:00

Author

Owner

Copy Link

@laeroah commented on GitHub (Aug 23, 2017):

sry for delay. Yeah, I can confirm the issue is on my side. Thanks!

@laeroah commented on GitHub (Aug 23, 2017): sry for delay. Yeah, I can confirm the issue is on my side. Thanks!

adam commented 2025-12-29 15:25:56 +01:00

Author

Owner

Copy Link

@ruslanskorb commented on GitHub (Aug 24, 2017):

@laeroah Please open Pods project in Xcode, select CoreStore target and check Swift Language Version. Which value is selected?

@ruslanskorb commented on GitHub (Aug 24, 2017): @laeroah Please open **Pods** project in Xcode, select **CoreStore** target and check **Swift Language Version**. Which value is selected?

adam referenced this issue 2025-12-29 15:32:28 +01:00

[PR #156] [CLOSED] Get rid of `unsafeBitCast(_:to:)​​​`. #468

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label investigating irreproducible

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#156