CoreStore doesn't compile with Swift 3.1 #126

New Issue

Closed

opened 2025-12-29 15:24:58 +01:00 by adam · 5 comments

adam commented 2025-12-29 15:24:58 +01:00

Owner

Copy Link

Copy Source

Originally created by @ThibaultVlacich on GitHub (Jan 29, 2017).

Swift 3.1 is shipped with Xcode 8.3 beta (supposed to be source compatible with Swift 3), but CoreStore doesn't compile in Xcode 8.3.

Here are the errors I get:

CoreStore Group
Swift Compiler Error Group
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSAsynchronousDataTransaction.swift:167:1: Type 'AsynchronousDataTransaction' does not conform to protocol 'CoreStoreSwiftType'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:68:9: Protocol requires property 'bridgeToObjectiveC' with type 'AsynchronousDataTransaction.ObjectiveCType' (aka 'CSAsynchronousDataTransaction'); do you want to add a stub?
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:73:16: Candidate has non-matching type 'Self.ObjectiveCType'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSAsynchronousDataTransaction.swift:68:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:43:33: 'AsynchronousDataTransaction' is not convertible to 'BaseDataTransaction'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:61:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:75:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:90:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:43:33: 'AsynchronousDataTransaction' is not convertible to 'BaseDataTransaction'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:61:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:75:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:90:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSSynchronousDataTransaction.swift:166:1: Type 'SynchronousDataTransaction' does not conform to protocol 'CoreStoreSwiftType'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:68:9: Protocol requires property 'bridgeToObjectiveC' with type 'SynchronousDataTransaction.ObjectiveCType' (aka 'CSSynchronousDataTransaction'); do you want to add a stub?
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:73:16: Candidate has non-matching type 'Self.ObjectiveCType'
/Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSSynchronousDataTransaction.swift:68:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction'

Originally created by @ThibaultVlacich on GitHub (Jan 29, 2017). Swift 3.1 is shipped with Xcode 8.3 beta (supposed to be source compatible with Swift 3), but CoreStore doesn't compile in Xcode 8.3. Here are the errors I get: ``` CoreStore Group Swift Compiler Error Group /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSAsynchronousDataTransaction.swift:167:1: Type 'AsynchronousDataTransaction' does not conform to protocol 'CoreStoreSwiftType' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:68:9: Protocol requires property 'bridgeToObjectiveC' with type 'AsynchronousDataTransaction.ObjectiveCType' (aka 'CSAsynchronousDataTransaction'); do you want to add a stub? /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:73:16: Candidate has non-matching type 'Self.ObjectiveCType' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSAsynchronousDataTransaction.swift:68:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:43:33: 'AsynchronousDataTransaction' is not convertible to 'BaseDataTransaction' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:61:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:75:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSCoreStore+Transaction.swift:90:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:43:33: 'AsynchronousDataTransaction' is not convertible to 'BaseDataTransaction' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:61:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:75:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSDataStack+Transaction.swift:90:23: Cannot convert value of type '() -> UnsafeDataTransaction' to expected argument type '() -> _' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSSynchronousDataTransaction.swift:166:1: Type 'SynchronousDataTransaction' does not conform to protocol 'CoreStoreSwiftType' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:68:9: Protocol requires property 'bridgeToObjectiveC' with type 'SynchronousDataTransaction.ObjectiveCType' (aka 'CSSynchronousDataTransaction'); do you want to add a stub? /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CoreStoreBridge.swift:73:16: Candidate has non-matching type 'Self.ObjectiveCType' /Users/thibault/dev/iOS-Application/Pods/CoreStore/Sources/ObjectiveC/CSSynchronousDataTransaction.swift:68:37: 'SynchronousDataTransaction' is not convertible to 'BaseDataTransaction' ```

adam added the fixed label 2025-12-29 15:24:58 +01:00

adam closed this issue 2025-12-29 15:24:58 +01:00

adam commented 2025-12-29 15:24:59 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Jan 30, 2017):

Thanks for the report! I haven't tried it with 8.3 yet, will look into this.

@JohnEstropia commented on GitHub (Jan 30, 2017): Thanks for the report! I haven't tried it with 8.3 yet, will look into this.

adam commented 2025-12-29 15:24:59 +01:00

Author

Owner

Copy Link

Copy Source

@MosheBerman commented on GitHub (Feb 6, 2017):

Related: https://bugs.swift.org/browse/SR-3796

@MosheBerman commented on GitHub (Feb 6, 2017): Related: https://bugs.swift.org/browse/SR-3796

adam commented 2025-12-29 15:24:59 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Feb 7, 2017):

Sorry if I haven't touched this for a while.

@MosheBerman Thanks for that link! To the person who brought this to the Swift team, thanks as well!

The bridge() method in question is just an internal utility within CoreStore and should be omittable. I'll try to make a workaround by the end of the day.

@JohnEstropia commented on GitHub (Feb 7, 2017): Sorry if I haven't touched this for a while. @MosheBerman Thanks for that link! To the person who brought this to the Swift team, thanks as well! The `bridge()` method in question is just an internal utility within CoreStore and should be omittable. I'll try to make a workaround by the end of the day.

adam commented 2025-12-29 15:25:00 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Feb 7, 2017):

This is fixed in the latest 3.0.2 update (develop branch). Please tell if you find other problems, thanks!

Will push to the master branch and Cocoapods when Xcode 8.3 GM build is released.

@JohnEstropia commented on GitHub (Feb 7, 2017): This is fixed in the latest 3.0.2 update (develop branch). Please tell if you find other problems, thanks! Will push to the master branch and Cocoapods when Xcode 8.3 GM build is released.

adam commented 2025-12-29 15:25:00 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Feb 7, 2017):

For reference: https://github.com/JohnEstropia/CoreStore/commit/bdf6308d8fa236c1d0b97f590fa6c9e0c42badeb

@JohnEstropia commented on GitHub (Feb 7, 2017): For reference: https://github.com/JohnEstropia/CoreStore/commit/bdf6308d8fa236c1d0b97f590fa6c9e0c42badeb

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels fixed

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore#126