starred/CoreStore
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-03-24 02:11:26 +01:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

bandaid solution for over-deallocated sequences bug in swift (for now)

Browse Source
This commit is contained in:
John Estropia
2015-08-27 19:06:04 +09:00
parent c3ef8a4172
commit ea6b6f2c37
1 changed files with 140 additions and 158 deletions
Download Patch File Download Diff File Expand all files Collapse all files

298
CoreStore/Importing Data/BaseDataTransaction+Importing.swift
View File

@@ -86,17 +86,14 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
return try autoreleasepool { guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else { return nil
return nil
}
let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self)
return object
} }
let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self)
return object
} }
func importObjects<T where T: NSManagedObject, T: ImportableObject>( func importObjects<T where T: NSManagedObject, T: ImportableObject>(
@@ -108,20 +105,17 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
try autoreleasepool { for source in sourceArray {
for source in sourceArray { guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else { continue
}
continue
} try autoreleasepool {
try autoreleasepool { let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self)
let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self)
}
} }
} }
} }
@@ -136,26 +130,23 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
try autoreleasepool { var objects = [T]()
for source in sourceArray {
var objects = [T]() guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
for source in sourceArray {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else { continue
}
continue
} try autoreleasepool {
try autoreleasepool { let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self)
let object = self.create(into)
try object.didInsertFromImportSource(source, inTransaction: self) objects.append(object)
objects.append(object)
}
} }
postProcess(sorted: objects)
} }
postProcess(sorted: objects)
} }
func importUniqueObject<T where T: NSManagedObject, T: ImportableUniqueObject>( func importUniqueObject<T where T: NSManagedObject, T: ImportableUniqueObject>(
@@ -167,31 +158,28 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
return try autoreleasepool { let uniqueIDKeyPath = T.uniqueIDKeyPath
guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else {
let uniqueIDKeyPath = T.uniqueIDKeyPath return nil
guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else { }
if let object = self.fetchOne(From(T), Where(uniqueIDKeyPath, isEqualTo: uniqueIDValue)) {
try object.updateFromImportSource(source, inTransaction: self)
return object
}
else {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
return nil return nil
} }
if let object = self.fetchOne(From(T), Where(uniqueIDKeyPath, isEqualTo: uniqueIDValue)) { let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
try object.updateFromImportSource(source, inTransaction: self) try object.didInsertFromImportSource(source, inTransaction: self)
return object return object
}
else {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
return nil
}
let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
try object.didInsertFromImportSource(source, inTransaction: self)
return object
}
} }
} }
@@ -205,62 +193,59 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
try autoreleasepool { var mapping = Dictionary<T.UniqueIDType, T.ImportSource>()
for source in sourceArray {
var mapping = Dictionary<T.UniqueIDType, T.ImportSource>() try autoreleasepool {
for source in sourceArray {
try autoreleasepool { guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else {
guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else { return
}
mapping[uniqueIDValue] = source
}
}
var mappingCopy = mapping // bugfix: prevent deallocation of exhausted items when accessed lazily with .keys and .values
if let preProcess = preProcess {
try autoreleasepool {
try preProcess(mapping: &mappingCopy)
}
}
mapping = mappingCopy
var mappingCopyForKeys = mapping
for object in self.fetchAll(From(T), Where(T.uniqueIDKeyPath, isMemberOf: mappingCopyForKeys.keys)) ?? [] {
try autoreleasepool {
let uniqueIDValue = object.uniqueIDValue
guard let source = mapping.removeValueForKey(uniqueIDValue)
where T.shouldUpdateFromImportSource(source, inTransaction: self) else {
return return
}
mapping[uniqueIDValue] = source
} }
}
var mappingCopy = mapping // bugfix: prevent deallocation of exhausted items when accessed lazily with .keys and .values
if let preProcess = preProcess {
try autoreleasepool { try object.updateFromImportSource(source, inTransaction: self)
try preProcess(mapping: &mappingCopy)
}
} }
mapping = mappingCopy }
for (uniqueIDValue, source) in mapping {
var mappingCopyForKeys = mapping try autoreleasepool {
for object in self.fetchAll(From(T), Where(T.uniqueIDKeyPath, isMemberOf: mappingCopyForKeys.keys)) ?? [] {
try autoreleasepool { guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
let uniqueIDValue = object.uniqueIDValue return
guard let source = mapping.removeValueForKey(uniqueIDValue)
where T.shouldUpdateFromImportSource(source, inTransaction: self) else {
return
}
try object.updateFromImportSource(source, inTransaction: self)
} }
}
for (uniqueIDValue, source) in mapping {
try autoreleasepool { let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
guard T.shouldInsertFromImportSource(source, inTransaction: self) else { try object.didInsertFromImportSource(source, inTransaction: self)
return
}
let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
try object.didInsertFromImportSource(source, inTransaction: self)
}
} }
} }
} }
@@ -276,71 +261,68 @@ public extension BaseDataTransaction {
"Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue." "Attempted to import an object of type \(typeName(into.entityClass)) outside the transaction's designated queue."
) )
try autoreleasepool { var sortedIDs = Array<T.UniqueIDType>()
var mapping = Dictionary<T.UniqueIDType, T.ImportSource>()
for source in sourceArray {
var sortedIDs = Array<T.UniqueIDType>() try autoreleasepool {
var mapping = Dictionary<T.UniqueIDType, T.ImportSource>()
for source in sourceArray {
try autoreleasepool { guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else {
guard let uniqueIDValue = try T.uniqueIDFromImportSource(source, inTransaction: self) else { return
return
}
mapping[uniqueIDValue] = source
sortedIDs.append(uniqueIDValue)
} }
}
var mappingCopy = mapping // bugfix: prevent deallocation of exhausted items when accessed lazily with .keys and .values
if let preProcess = preProcess {
try autoreleasepool { mapping[uniqueIDValue] = source
sortedIDs.append(uniqueIDValue)
try preProcess(mapping: &mappingCopy)
}
} }
mapping = mappingCopy
var mappingCopyForKeys = mapping
var objects = Dictionary<T.UniqueIDType, T>()
for object in self.fetchAll(From(T), Where(T.uniqueIDKeyPath, isMemberOf: mappingCopyForKeys.keys)) ?? [] {
try autoreleasepool {
let uniqueIDValue = object.uniqueIDValue
guard let source = mapping.removeValueForKey(uniqueIDValue)
where T.shouldUpdateFromImportSource(source, inTransaction: self) else {
return
}
try object.updateFromImportSource(source, inTransaction: self)
objects[uniqueIDValue] = object
}
}
for (uniqueIDValue, source) in mapping {
try autoreleasepool {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
return
}
let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
try object.didInsertFromImportSource(source, inTransaction: self)
objects[uniqueIDValue] = object
}
}
postProcess(sorted: sortedIDs.flatMap { objects[$0] })
} }
var mappingCopy = mapping // bugfix: prevent deallocation of exhausted items when accessed lazily with .keys and .values
if let preProcess = preProcess {
try autoreleasepool {
try preProcess(mapping: &mappingCopy)
}
}
mapping = mappingCopy
var mappingCopyForKeys = mapping
var objects = Dictionary<T.UniqueIDType, T>()
for object in self.fetchAll(From(T), Where(T.uniqueIDKeyPath, isMemberOf: mappingCopyForKeys.keys)) ?? [] {
try autoreleasepool {
let uniqueIDValue = object.uniqueIDValue
guard let source = mapping.removeValueForKey(uniqueIDValue)
where T.shouldUpdateFromImportSource(source, inTransaction: self) else {
return
}
try object.updateFromImportSource(source, inTransaction: self)
objects[uniqueIDValue] = object
}
}
for (uniqueIDValue, source) in mapping {
try autoreleasepool {
guard T.shouldInsertFromImportSource(source, inTransaction: self) else {
return
}
let object = self.create(into)
object.uniqueIDValue = uniqueIDValue
try object.didInsertFromImportSource(source, inTransaction: self)
objects[uniqueIDValue] = object
}
}
postProcess(sorted: sortedIDs.flatMap { objects[$0] })
} }
} }