From df441c5d04eedc57d249d7cba99132869f2cc992 Mon Sep 17 00:00:00 2001 From: John Estropia Date: Fri, 11 Mar 2016 20:58:33 +0900 Subject: [PATCH 1/3] Update README.md --- README.md | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 3737846..6fea1c8 100644 --- a/README.md +++ b/README.md @@ -65,6 +65,9 @@ Unleashing the real power of Core Data with the elegance and safety of Swift - [Installation](#installation) - [Changesets](#changesets) - [Upgrading from v0.2.0 to 1.0.0](#upgrading-from-v020-to-100) +- [Contact](#contact) +- [Who uses CoreStore?](#who-uses-corestore) +- [License](#license) @@ -1214,11 +1217,17 @@ The protocols above had their methods renamed as well, to retain the natural lan - New migration utilities! (README still pending) Check out *DataStack+Migration.swift* and *CoreStore+Migration.swift* for the new methods, as well as *DataStack.swift* for its new initializer. -# Contributions -While CoreStore's design is pretty solid and the unit test and demo app work well, CoreStore is pretty much still in its early stage. With more exposure to production code usage and criticisms from the developer community, CoreStore hopes to mature as well. -Please feel free to report any issues, suggestions, or criticisms! -日本語で連絡していただいても構いません！ +# Contact +Questions? Suggestions? +Reach me at [Twitter @JohnEstropia](https://twitter.com/JohnEstropia) +or tag your Stackoverflow question with **corestore** +日本語の対応も可能なので是非！ -## License + +# Who uses CoreStore? +Did CoreStore serve you well? I'd love to hear about your app :) + + +# License CoreStore is released under an MIT license. See the LICENSE file for more information From 64ad7b3bfdd4d395d79e7dc2796757263733b667 Mon Sep 17 00:00:00 2001 From: John Estropia Date: Fri, 11 Mar 2016 20:59:52 +0900 Subject: [PATCH 2/3] Update README.md --- README.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 6fea1c8..c8635b9 100644 --- a/README.md +++ b/README.md @@ -1219,8 +1219,11 @@ The protocols above had their methods renamed as well, to retain the natural lan # Contact Questions? Suggestions? -Reach me at [Twitter @JohnEstropia](https://twitter.com/JohnEstropia) + +Reach me on Twitter [@JohnEstropia](https://twitter.com/JohnEstropia) + or tag your Stackoverflow question with **corestore** + 日本語の対応も可能なので是非！ From c323a28c195df8b2d10dd5ba90140b3e6ba5440c Mon Sep 17 00:00:00 2001 From: John Rommel Estropia Date: Sat, 12 Mar 2016 09:27:59 +0900 Subject: [PATCH 3/3] fix warnings in demo app --- .../FetchingAndQueryingDemoViewController.swift | 2 +- .../ObjectObserverDemoViewController.swift | 2 +- .../Stack Setup Demo/StackSetupDemoViewController.swift | 4 ++-- .../Transactions Demo/TransactionsDemoViewController.swift | 4 ++-- CoreStoreTests/CoreStoreTests.swift | 6 +++--- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CoreStoreDemo/CoreStoreDemo/Fetching and Querying Demo/FetchingAndQueryingDemoViewController.swift b/CoreStoreDemo/CoreStoreDemo/Fetching and Querying Demo/FetchingAndQueryingDemoViewController.swift index 365982f..5073683 100644 --- a/CoreStoreDemo/CoreStoreDemo/Fetching and Querying Demo/FetchingAndQueryingDemoViewController.swift +++ b/CoreStoreDemo/CoreStoreDemo/Fetching and Querying Demo/FetchingAndQueryingDemoViewController.swift @@ -37,7 +37,7 @@ private struct Static { cachedTimeZone.daylightSavingTimeOffset = rawTimeZone.daylightSavingTimeOffset } - transaction.commit() + transaction.commitAndWait() } return dataStack diff --git a/CoreStoreDemo/CoreStoreDemo/List and Object Observers Demo/ObjectObserverDemoViewController.swift b/CoreStoreDemo/CoreStoreDemo/List and Object Observers Demo/ObjectObserverDemoViewController.swift index a97e836..09145ec 100644 --- a/CoreStoreDemo/CoreStoreDemo/List and Object Observers Demo/ObjectObserverDemoViewController.swift +++ b/CoreStoreDemo/CoreStoreDemo/List and Object Observers Demo/ObjectObserverDemoViewController.swift @@ -61,7 +61,7 @@ class ObjectObserverDemoViewController: UIViewController, ObjectObserver { let palette = transaction.create(Into(Palette)) palette.setInitialValues() - transaction.commit() + transaction.commitAndWait() } let palette = CoreStore.fetchOne(From(Palette), OrderBy(.Ascending("hue")))! diff --git a/CoreStoreDemo/CoreStoreDemo/Stack Setup Demo/StackSetupDemoViewController.swift b/CoreStoreDemo/CoreStoreDemo/Stack Setup Demo/StackSetupDemoViewController.swift index 2c8fd6c..7cbd016 100644 --- a/CoreStoreDemo/CoreStoreDemo/Stack Setup Demo/StackSetupDemoViewController.swift +++ b/CoreStoreDemo/CoreStoreDemo/Stack Setup Demo/StackSetupDemoViewController.swift @@ -43,7 +43,7 @@ private struct Static { account2.name = "Jane Doe HCD" account2.friends = 314 - transaction.commit() + transaction.commitAndWait() } return dataStack @@ -77,7 +77,7 @@ private struct Static { account2.name = "#janedoe_hcd" account2.friends = 100 - transaction.commit() + transaction.commitAndWait() } return dataStack diff --git a/CoreStoreDemo/CoreStoreDemo/Transactions Demo/TransactionsDemoViewController.swift b/CoreStoreDemo/CoreStoreDemo/Transactions Demo/TransactionsDemoViewController.swift index 5c2f68d..755b46b 100644 --- a/CoreStoreDemo/CoreStoreDemo/Transactions Demo/TransactionsDemoViewController.swift +++ b/CoreStoreDemo/CoreStoreDemo/Transactions Demo/TransactionsDemoViewController.swift @@ -32,7 +32,7 @@ private struct Static { let place = transaction.create(Into(Place)) place.setInitialValues() - transaction.commit() + transaction.commitAndWait() } place = CoreStore.fetchOne(From(Place)) } @@ -178,7 +178,7 @@ class TransactionsDemoViewController: UIViewController, MKMapViewDelegate, Objec let place = transaction.edit(Static.placeController.object) place?.setInitialValues() - transaction.commit() + transaction.commitAndWait() } } diff --git a/CoreStoreTests/CoreStoreTests.swift b/CoreStoreTests/CoreStoreTests.swift index 6c83a2d..d6b0fc3 100644 --- a/CoreStoreTests/CoreStoreTests.swift +++ b/CoreStoreTests/CoreStoreTests.swift @@ -265,7 +265,7 @@ class CoreStoreTests: XCTestCase { ) XCTAssertTrue(numberOfDeletedObjects2 == 2, "numberOfDeletedObjects2 == 2 (actual: \(numberOfDeletedObjects2))") - transaction.commit() + transaction.commitAndWait() } CoreStore.beginSynchronous({ (transaction) -> Void in @@ -277,7 +277,7 @@ class CoreStoreTests: XCTestCase { obj.testEntityID = oldID } - transaction.commit() + transaction.commitAndWait() }) let objs1 = CoreStore.fetchAll(From(TestEntity1)) @@ -351,7 +351,7 @@ class CoreStoreTests: XCTestCase { let obj5 = transaction.edit(obj5) transaction.delete(obj5, obj6) - transaction.commit() + transaction.commitAndWait() } let count2 = CoreStore.queryValue(