remove persistentstores during DataStack deinitialization to prevent warnings in Unit tests during teardown

CoreStoreTests/BaseTestCase.swift

@@ -62,6 +62,9 @@ class BaseTestCase: XCTestCase {
             
             XCTFail(error.coreStoreDumpString)
         }
+        self.addTeardownBlock {
+            stack.unsafeRemoveAllPersistentStoresAndWait()
+        }
     }
     
     @nonobjc

CoreStoreTests/DynamicModelTests.swift

@@ -505,7 +505,12 @@ class DynamicModelTests: BaseTestDataTestCase {
                     XCTFail()
                 }
             )
-            self.waitAndCheckExpectations()
+        }
+        
+        self.waitForExpectations(timeout: 10, handler: { _ in })
+        
+        self.addTeardownBlock {
+            dataStack.unsafeRemoveAllPersistentStoresAndWait()
         }
     }
     

CoreStoreTests/FetchTests.swift

@@ -132,9 +132,9 @@ final class FetchTests: BaseTestDataTestCase {
                     }
                 )
             }
-        }
             self.waitAndCheckExpectations()
         }
+    }
     
     @objc
     dynamic func test_ThatDataStacksAndTransactions_CanFetchAllExisting() {
@@ -267,9 +267,9 @@ final class FetchTests: BaseTestDataTestCase {
                     }
                 )
             }
-        }
             self.waitAndCheckExpectations()
         }
+    }
     
     @objc
     dynamic func test_ThatDataStacks_CanFetchOneFromDefaultConfiguration() {

CoreStoreTests/ObjectPublisherTests.swift

@@ -144,6 +144,7 @@ class ObjectPublisherTests: BaseTestDataTestCase {
                     XCTFail()
                 }
             )
+            
             self.waitAndCheckExpectations()
 
             withExtendedLifetime(objectPublisher, {})

CoreStoreTests/TransactionTests.swift

@@ -622,9 +622,9 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
-        }
             self.waitAndCheckExpectations()
         }
+    }
     
     @objc
     dynamic func test_ThatAsynchronousTransactions_CanPerformCRUDsInCorrectConfiguration() {
@@ -755,9 +755,9 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
-        }
             self.waitAndCheckExpectations()
         }
+    }
     
     @objc
     dynamic func test_ThatAsynchronousTransactions_CanDiscardUncommittedChanges() {
@@ -896,9 +896,9 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
-        }
             self.waitAndCheckExpectations()
         }
+    }
     
     @objc
     dynamic func test_ThatUnsafeTransactions_CanPerformCRUDs() {

Sources/DataStack.swift

@@ -370,6 +370,44 @@ public final class DataStack: Equatable {
         }
     }
     
+    /**
+     Prepares deinitializing the `DataStack` by removing all persistent stores. This is not necessary, but can help silence SQLite warnings when actively releasing and recreating `DataStack`s.
+     - parameter completion: the closure to execute after all persistent stores are removed
+     */
+    public func unsafeRemoveAllPersistentStores(completion: @escaping () -> Void = {}) {
+        
+        let coordinator = self.coordinator
+        coordinator.performAsynchronously {
+            
+            withExtendedLifetime(coordinator) { coordinator in
+                
+                coordinator.persistentStores.forEach {
+                    
+                    _ = try? coordinator.remove($0)
+                }
+            }
+            DispatchQueue.main.async(execute: completion)
+        }
+    }
+    
+    /**
+     Prepares deinitializing the `DataStack` by removing all persistent stores. This is not necessary, but can help silence SQLite warnings when actively releasing and recreating `DataStack`s.
+     */
+    public func unsafeRemoveAllPersistentStoresAndWait() {
+        
+        let coordinator = self.coordinator
+        coordinator.performSynchronously {
+            
+            withExtendedLifetime(coordinator) { coordinator in
+                
+                coordinator.persistentStores.forEach {
+                    
+                    _ = try? coordinator.remove($0)
+                }
+            }
+        }
+    }
+    
     
     // MARK: 3rd Party Utilities
     
@@ -509,16 +547,6 @@ public final class DataStack: Equatable {
     
     deinit {
         
-        let coordinator = self.coordinator
+        self.unsafeRemoveAllPersistentStores()
-        coordinator.performAsynchronously {
-            
-            withExtendedLifetime(coordinator) { coordinator in
-                
-                coordinator.persistentStores.forEach {
-                    
-                    _ = try? coordinator.remove($0)
-                }
-            }
-        }
     }
 }