remove persistentstores during DataStack deinitialization to prevent warnings in Unit tests during teardown

CoreStoreTests/BaseTestCase.swift

@@ -62,6 +62,9 @@ class BaseTestCase: XCTestCase {
             
             XCTFail(error.coreStoreDumpString)
         }
+        self.addTeardownBlock {
+            stack.unsafeRemoveAllPersistentStoresAndWait()
+        }
     }
     
     @nonobjc

CoreStoreTests/DynamicModelTests.swift

@@ -505,7 +505,12 @@ class DynamicModelTests: BaseTestDataTestCase {
                     XCTFail()
                 }
             )
-            self.waitAndCheckExpectations()
+        }
+        
+        self.waitForExpectations(timeout: 10, handler: { _ in })
+        
+        self.addTeardownBlock {
+            dataStack.unsafeRemoveAllPersistentStoresAndWait()
         }
     }
     

CoreStoreTests/FetchTests.swift

@@ -132,8 +132,8 @@ final class FetchTests: BaseTestDataTestCase {
                     }
                 )
             }
+            self.waitAndCheckExpectations()
         }
-        self.waitAndCheckExpectations()
     }
     
     @objc
@@ -267,8 +267,8 @@ final class FetchTests: BaseTestDataTestCase {
                     }
                 )
             }
+            self.waitAndCheckExpectations()
         }
-        self.waitAndCheckExpectations()
     }
     
     @objc

CoreStoreTests/ObjectPublisherTests.swift

@@ -144,6 +144,7 @@ class ObjectPublisherTests: BaseTestDataTestCase {
                     XCTFail()
                 }
             )
+            
             self.waitAndCheckExpectations()
 
             withExtendedLifetime(objectPublisher, {})

CoreStoreTests/TransactionTests.swift

@@ -622,8 +622,8 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
+            self.waitAndCheckExpectations()
         }
-        self.waitAndCheckExpectations()
     }
     
     @objc
@@ -755,8 +755,8 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
+            self.waitAndCheckExpectations()
         }
-        self.waitAndCheckExpectations()
     }
     
     @objc
@@ -896,8 +896,8 @@ final class TransactionTests: BaseTestCase {
                     }
                 )
             }
+            self.waitAndCheckExpectations()
         }
-        self.waitAndCheckExpectations()
     }
     
     @objc