[PR #210] [CLOSED] Prototype/swift 4 0 #476

New Issue

Closed

opened 2025-12-29 18:27:12 +01:00 by adam · 0 comments

adam commented 2025-12-29 18:27:12 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/210
Author: @WCharysz-ALTEN
Created: 10/12/2017
Status: ❌ Closed

Base: prototype/Swift_4_0 ← Head: prototype/Swift_4_0

---

📝 Commits (8)

• 130943a Changing internal transactionQueue to open
• d23d895 Update schemes
• 4ce2b88 Going back to Xcode 8
• b3a7b30 Reverse
• 00f1566 Reverse
• a39a784 Reverse
• c54184c Reverse
• 9c8d7e5 Reverse

📊 Changes

8 files changed (+34 additions, -8 deletions)

View changed files

📝 CoreStore.xcodeproj/project.pbxproj (+6 -2)
📝 CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore OSX.xcscheme (+3 -1)
📝 CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore iOS.xcscheme (+3 -1)
📝 CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore tvOS.xcscheme (+3 -1)
📝 CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore watchOS.xcscheme (+3 -1)
📝 CoreStoreDemo/CoreStoreDemo.xcodeproj/project.pbxproj (+12 -0)
📝 CoreStoreDemo/CoreStoreDemo.xcodeproj/xcshareddata/xcschemes/CoreStoreDemo.xcscheme (+3 -1)
📝 Sources/BaseDataTransaction.swift (+1 -1)

📄 Description

I changed the property transactionQueue in BaseDataTransaction from internal to open. This way it will be available outside the framework and can be later passed to the Alamofire completionQueue. This will make possible to use asynchronous transactions in the Alamofire completion closures.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/210 **Author:** [@WCharysz-ALTEN](https://github.com/WCharysz-ALTEN) **Created:** 10/12/2017 **Status:** ❌ Closed **Base:** `prototype/Swift_4_0` ← **Head:** `prototype/Swift_4_0` --- ### 📝 Commits (8) - [`130943a`](https://github.com/JohnEstropia/CoreStore/commit/130943acd3a54c457fdc0c3723bf06fce1b3f06d) Changing internal transactionQueue to open - [`d23d895`](https://github.com/JohnEstropia/CoreStore/commit/d23d895e5b74a03c5e7129e1ce5cc686c87dbe3b) Update schemes - [`4ce2b88`](https://github.com/JohnEstropia/CoreStore/commit/4ce2b883520b655b2b4758d2c83aab9dd3190f89) Going back to Xcode 8 - [`b3a7b30`](https://github.com/JohnEstropia/CoreStore/commit/b3a7b30ca044f4acac0155aece771a4b9d3a78aa) Reverse - [`00f1566`](https://github.com/JohnEstropia/CoreStore/commit/00f15662a9d4c4f999b4ff94906504b8b0c6532a) Reverse - [`a39a784`](https://github.com/JohnEstropia/CoreStore/commit/a39a78411d0bcfebb58d56a4eaf6d18c37d145a2) Reverse - [`c54184c`](https://github.com/JohnEstropia/CoreStore/commit/c54184c85f13f1c09105ee7ace3de5b8f42013d6) Reverse - [`9c8d7e5`](https://github.com/JohnEstropia/CoreStore/commit/9c8d7e5bc0208f1bfad51ec65ee6475b1b5f42a1) Reverse ### 📊 Changes **8 files changed** (+34 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `CoreStore.xcodeproj/project.pbxproj` (+6 -2) 📝 `CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore OSX.xcscheme` (+3 -1) 📝 `CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore iOS.xcscheme` (+3 -1) 📝 `CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore tvOS.xcscheme` (+3 -1) 📝 `CoreStore.xcodeproj/xcshareddata/xcschemes/CoreStore watchOS.xcscheme` (+3 -1) 📝 `CoreStoreDemo/CoreStoreDemo.xcodeproj/project.pbxproj` (+12 -0) 📝 `CoreStoreDemo/CoreStoreDemo.xcodeproj/xcshareddata/xcschemes/CoreStoreDemo.xcscheme` (+3 -1) 📝 `Sources/BaseDataTransaction.swift` (+1 -1) </details> ### 📄 Description I changed the property transactionQueue in BaseDataTransaction from internal to open. This way it will be available outside the framework and can be later passed to the Alamofire completionQueue. This will make possible to use asynchronous transactions in the Alamofire completion closures. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 18:27:12 +01:00

adam closed this issue 2025-12-29 18:27:12 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#476