[PR #141] [CLOSED] [Importing] Convert shouldUpdate(from:in:) method to an instance method. #466

New Issue

Closed

opened 2025-12-29 18:27:09 +01:00 by adam · 0 comments

adam commented 2025-12-29 18:27:09 +01:00

Owner

Copy Link

📋 Pull Request Information

Original PR: https://github.com/JohnEstropia/CoreStore/pull/141
Author: @ruslanskorb
Created: 1/2/2017
Status: ❌ Closed

Base: swift3_develop ← Head: convert-shouldUpdate-method-to-instance-method

---

📝 Commits (1)

• d3846bc [Importing] Convert shouldUpdate(from:in:) method to an instance method.

📊 Changes

2 files changed (+7 additions, -7 deletions)

View changed files

📝 Sources/Importing/BaseDataTransaction+Importing.swift (+2 -2)
📝 Sources/Importing/ImportableUniqueObject.swift (+5 -5)

📄 Description

This allows the user not to fetch the object again to check if it should be updated.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/JohnEstropia/CoreStore/pull/141 **Author:** [@ruslanskorb](https://github.com/ruslanskorb) **Created:** 1/2/2017 **Status:** ❌ Closed **Base:** `swift3_develop` ← **Head:** `convert-shouldUpdate-method-to-instance-method` --- ### 📝 Commits (1) - [`d3846bc`](https://github.com/JohnEstropia/CoreStore/commit/d3846bc1b1681cf2d3f15feb2f352395b4ba8ae1) [Importing] Convert `shouldUpdate(from:in:)` method to an instance method. ### 📊 Changes **2 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `Sources/Importing/BaseDataTransaction+Importing.swift` (+2 -2) 📝 `Sources/Importing/ImportableUniqueObject.swift` (+5 -5) </details> ### 📄 Description This allows the user not to fetch the object again to check if it should be updated. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 18:27:09 +01:00

adam closed this issue 2025-12-29 18:27:09 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#466