App crash on receiving notification using datastack #435

@imrobbyrc commented on GitHub (Jul 2, 2024):

i got 3 variant of that crash

here's crashlytics trace
crashlytics.zip

@imrobbyrc commented on GitHub (Jul 2, 2024): i got 3 variant of that crash <img width="1104" alt="Screenshot 2024-07-02 at 20 01 44" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/44524fd2-fab7-48ee-baca-ee79fde5a552"> here's crashlytics trace [crashlytics.zip](https://github.com/user-attachments/files/16068656/crashlytics.zip)

adam commented

@JohnEstropia commented on GitHub (Jul 3, 2024):

The problem is this line:

Since your DataStack is initialized asynchronously, publishList() is trying to start a fetch before your addStorage()'s completion is called. I would recommend that you defer initializing any publishers on the DataStack before addStorage has completed. That said, I wouldn't recommend converting it to a synchronous version (addStorageAndWait()) either, as eventually you will have to handle migrations and convert them back to asynchronous again.

@JohnEstropia commented on GitHub (Jul 3, 2024): The problem is this line: <img width="802" alt="Screenshot 2024-07-03 at 9 46 15" src="https://github.com/JohnEstropia/CoreStore/assets/3029684/fa726ba4-b74f-40ff-bf8b-e5940452590f"> Since your `DataStack` is initialized asynchronously, `publishList()` is trying to start a fetch before your `addStorage()`'s completion is called. I would recommend that you defer initializing any publishers on the `DataStack` before `addStorage` has completed. That said, I wouldn't recommend converting it to a synchronous version (`addStorageAndWait()`) either, as eventually you will have to handle migrations and convert them back to asynchronous again.

adam commented

@imrobbyrc commented on GitHub (Jul 3, 2024):

The problem is this line:

Since your DataStack is initialized asynchronously, publishList() is trying to start a fetch before your addStorage()'s completion is called. I would recommend that you defer initializing any publishers on the DataStack before addStorage has completed. That said, I wouldn't recommend converting it to a synchronous version (addStorageAndWait()) either, as eventually you will have to handle migrations and convert them back to asynchronous again.

hmm i think i already handle it in OnboardingViewController.

let dispatchGroup = DispatchGroup()

dispatchGroup.enter()
Stamps.createDataStack {
   dispatchGroup.leave()
}

dispatchGroup.enter()
Omni.createDataStack {
   dispatchGroup.leave()
}

dispatchGroup.notify(queue: .main) {

   guard dataStack != nil || Omni.dataStack != nil else {
       print("Error: dataStack is not initialized")
       return
   }

   let storyboard = UIStoryboard(name: "Main", bundle: nil)
   let mainTabBarController = storyboard.instantiateViewController(identifier: "MarugameTabbarViewController")
   (UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate)?.changeRootViewController(mainTabBarController)
}

@imrobbyrc commented on GitHub (Jul 3, 2024): > The problem is this line: <img alt="Screenshot 2024-07-03 at 9 46 15" width="802" src="https://private-user-images.githubusercontent.com/3029684/345243604-fa726ba4-b74f-40ff-bf8b-e5940452590f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk5NzI0MjQsIm5iZiI6MTcxOTk3MjEyNCwicGF0aCI6Ii8zMDI5Njg0LzM0NTI0MzYwNC1mYTcyNmJhNC1iNzRmLTQwZmYtYmY4Yi1lNTk0MDQ1MjU5MGYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDNUMDIwMjA0WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9Njc5ZDZmMGE0ZGJlODFjZjRkM2MxYjExN2FiZGRmYjBjM2FjY2EwNDFjMDEzOTdiNmUyYWY1YzAxZTI5OWVkMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.TpCbP0re_VhaXY3OvCbReCK8hrHOv0V339O-yQ5TUCI"> > > Since your `DataStack` is initialized asynchronously, `publishList()` is trying to start a fetch before your `addStorage()`'s completion is called. I would recommend that you defer initializing any publishers on the `DataStack` before `addStorage` has completed. That said, I wouldn't recommend converting it to a synchronous version (`addStorageAndWait()`) either, as eventually you will have to handle migrations and convert them back to asynchronous again. hmm i think i already handle it in `OnboardingViewController`. ``` swift let dispatchGroup = DispatchGroup() dispatchGroup.enter() Stamps.createDataStack { dispatchGroup.leave() } dispatchGroup.enter() Omni.createDataStack { dispatchGroup.leave() } dispatchGroup.notify(queue: .main) { guard dataStack != nil || Omni.dataStack != nil else { print("Error: dataStack is not initialized") return } let storyboard = UIStoryboard(name: "Main", bundle: nil) let mainTabBarController = storyboard.instantiateViewController(identifier: "MarugameTabbarViewController") (UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate)?.changeRootViewController(mainTabBarController) }

adam commented

@JohnEstropia commented on GitHub (Jul 3, 2024):

I'm not sure when that OnboardingViewController code is getting called, but your crash is from HomeViewController → UserViewModel initialization. Try putting breakpoints and check whether the publishList calls are called ahead of your addStorage completion. Note that if you have an Storyboard set as an "Initial View Controller", that View Controller is likely to get initialized even before applicationDidFinishLaunching

@JohnEstropia commented on GitHub (Jul 3, 2024): I'm not sure when that `OnboardingViewController` code is getting called, but your crash is from `HomeViewController` → `UserViewModel` initialization. Try putting breakpoints and check whether the `publishList` calls are called ahead of your `addStorage` completion. Note that if you have an Storyboard set as an "Initial View Controller", that View Controller is likely to get initialized even before `applicationDidFinishLaunching`

adam commented

@imrobbyrc commented on GitHub (Jul 3, 2024):

I'm not sure when that OnboardingViewController code is getting called, but your crash is from HomeViewController → UserViewModel initialization. Try putting breakpoints and check whether the publishList calls are called ahead of your addStorage completion. Note that if you have an Storyboard set as an "Initial View Controller", that View Controller is likely to get initialized even before applicationDidFinishLaunching

try to breakpoint in publishList with print in appdelete and scene delete, it called after my print statement. do you have idea how i can handle addStorage ? i use OnboardingViewController to handle addStorage

@imrobbyrc commented on GitHub (Jul 3, 2024): > I'm not sure when that `OnboardingViewController` code is getting called, but your crash is from `HomeViewController` → `UserViewModel` initialization. Try putting breakpoints and check whether the `publishList` calls are called ahead of your `addStorage` completion. Note that if you have an Storyboard set as an "Initial View Controller", that View Controller is likely to get initialized even before `applicationDidFinishLaunching` try to breakpoint in `publishList ` with print in appdelete and scene delete, it called after my print statement. do you have idea how i can handle `addStorage` ? i use `OnboardingViewController` to handle `addStorage`

adam commented

@imrobbyrc commented on GitHub (Jul 4, 2024):

hi @JohnEstropia , i got a reason why it crash, the initialize dataStack is complete but persistentStore is empty, you can see this log, do you know why it still empty? it's crash when the device in lock state

(lldb) po dataStack.txt

@imrobbyrc commented on GitHub (Jul 4, 2024): hi @JohnEstropia , i got a reason why it crash, the initialize dataStack is complete but persistentStore is empty, you can see this log, do you know why it still empty? it's crash when the device in lock state ![Screenshot 2024-07-04 at 16 09 54](https://github.com/JohnEstropia/CoreStore/assets/25898417/a8293ce3-73f4-4051-9328-c7fd36f14d93) [(lldb) po dataStack.txt](https://github.com/user-attachments/files/16096301/lldb.po.dataStack.txt)

adam commented

@JohnEstropia commented on GitHub (Jul 4, 2024):

do you know why it still empty?

It's empty because addStorage() is not complete yet.

Add a breakpoint on the onComplete() line here:

Anything that accesses dataStack.* methods before that onComplete() runs is your culprit.

@JohnEstropia commented on GitHub (Jul 4, 2024): > do you know why it still empty? It's empty because `addStorage()` is not complete yet. Add a breakpoint on the `onComplete()` line here: <img width="521" alt="Screenshot 2024-07-04 at 18 35 33" src="https://github.com/JohnEstropia/CoreStore/assets/3029684/1d047591-7c1b-4dfc-b212-434cfcdec023"> Anything that accesses `dataStack.*` methods before that `onComplete()` runs is your culprit.

adam commented

@imrobbyrc commented on GitHub (Jul 4, 2024):

do you know why it still empty?

It's empty because addStorage() is not complete yet.

Add a breakpoint on the onComplete() line here:

Anything that accesses dataStack.* methods before that onComplete() runs is your culprit.

thanks for reply @JohnEstropia, but i use DispatchGroup() to handle the flow

        let dispatchGroup = DispatchGroup()

        dispatchGroup.enter()
        Omni.createDataStack {
            dispatchGroup.leave()
        }

        dispatchGroup.enter()
        Stamps.createDataStack {
            dispatchGroup.leave()
        }

        dispatchGroup.notify(queue: .main) {
            let storyboard = UIStoryboard(name: "Main", bundle: nil)
            let mainTabBarController = storyboard.instantiateViewController(identifier: "MarugameTabbarViewController")
            (UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate)?.changeRootViewController(mainTabBarController)
            if Membership.isAuthenticated, !Defaults.deviceToken.isEmpty {
                registerPushNotificationKey()
            }
            Session.setCrashlyticsData()
            UIApplication.shared.registerForRemoteNotifications()
        }
    }

onComplete() metho should call dispatchGroup.leave() and will notify dispatchGroup, right?

@imrobbyrc commented on GitHub (Jul 4, 2024): > > do you know why it still empty? > > It's empty because `addStorage()` is not complete yet. > > Add a breakpoint on the `onComplete()` line here: <img alt="Screenshot 2024-07-04 at 18 35 33" width="521" src="https://private-user-images.githubusercontent.com/3029684/345778103-1d047591-7c1b-4dfc-b212-434cfcdec023.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjAwODY3OTEsIm5iZiI6MTcyMDA4NjQ5MSwicGF0aCI6Ii8zMDI5Njg0LzM0NTc3ODEwMy0xZDA0NzU5MS03YzFiLTRkZmMtYjIxMi00MzRjZmNkZWMwMjMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDcwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA3MDRUMDk0ODExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NjlkNTdjZTg5OTk1MzlkMjE0MDhiN2Q2MWM3OTE3NDkyOTJkNzZmMDcwNDA5YjA3NTYwNmRmNWQ5OTAyNDBkNyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.2qINmQBySJ5TQrmm3fSb07zGVU21GVXh1h5GGg9ZAns"> > > Anything that accesses `dataStack.*` methods before that `onComplete()` runs is your culprit. thanks for reply @JohnEstropia, but i use `DispatchGroup()` to handle the flow ``` swift let dispatchGroup = DispatchGroup() dispatchGroup.enter() Omni.createDataStack { dispatchGroup.leave() } dispatchGroup.enter() Stamps.createDataStack { dispatchGroup.leave() } dispatchGroup.notify(queue: .main) { let storyboard = UIStoryboard(name: "Main", bundle: nil) let mainTabBarController = storyboard.instantiateViewController(identifier: "MarugameTabbarViewController") (UIApplication.shared.connectedScenes.first?.delegate as? SceneDelegate)?.changeRootViewController(mainTabBarController) if Membership.isAuthenticated, !Defaults.deviceToken.isEmpty { registerPushNotificationKey() } Session.setCrashlyticsData() UIApplication.shared.registerForRemoteNotifications() } } ``` `onComplete()` metho should call `dispatchGroup.leave()` and will notify `dispatchGroup`, right?

adam commented

@imrobbyrc commented on GitHub (Jul 4, 2024):

i got this error on corestore callback @JohnEstropia

@imrobbyrc commented on GitHub (Jul 4, 2024): i got this error on corestore callback @JohnEstropia <img width="1440" alt="Screenshot 2024-07-04 at 17 36 41" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/7c37eeaf-6630-4f50-b451-aa2b4d4cc680">

adam commented

@JohnEstropia commented on GitHub (Jul 5, 2024):

Sorry if I wasn't clear. The breakpoints are to find the order of events happening in your app. You'd need to compare which of the following is hit first:

addStorage() method's onComplete() callback
HomeViewController.promotionPublisher let stored property (I'm assuming Omni.dataStack is the same as the global var dataStack declared in DataStack.swift)
UserViewModel.init(), specifically let userPublisher and let cartPublisher
Anything else that is calling methods on the dataStack that happens right after launch

@JohnEstropia commented on GitHub (Jul 5, 2024): Sorry if I wasn't clear. The breakpoints are to find the order of events happening in your app. You'd need to compare which of the following is hit first: - `addStorage()` method's `onComplete()` callback - `HomeViewController.promotionPublisher` `let` stored property (I'm assuming `Omni.dataStack` is the same as the global `var dataStack` declared in `DataStack.swift`) - `UserViewModel.init()`, specifically `let userPublisher` and `let cartPublisher` - Anything else that is calling methods on the `dataStack` that happens right after launch

adam commented

@JohnEstropia commented on GitHub (Jul 5, 2024):

Sorry, scratch that. I just noticed your error in the last screenshot is in the completion closure itself. The error code 259 implies the file already exists. Do you know where/when this file is being created?

@JohnEstropia commented on GitHub (Jul 5, 2024): Sorry, scratch that. I just noticed your error in the last screenshot is in the `completion` closure itself. The error code `259` implies the file already exists. Do you know where/when this file is being created?

adam commented

@imrobbyrc commented on GitHub (Jul 5, 2024):

Sorry, scratch that. I just noticed your error in the last screenshot is in the completion closure itself. The error code 259 implies the file already exists. Do you know where/when this file is being created?

the file should be exists because if i open the apps normaly it will be fine, the problem is when the apps backgroundly launched by push notification in locked state

@imrobbyrc commented on GitHub (Jul 5, 2024): > Sorry, scratch that. I just noticed your error in the last screenshot is in the `completion` closure itself. The error code `259` implies the file already exists. Do you know where/when this file is being created? the file should be exists because if i open the apps normaly it will be fine, the problem is when the apps backgroundly launched by push notification in locked state

adam commented

@JohnEstropia commented on GitHub (Jul 5, 2024):

I see. CoreStore doesn't set any NSFileProtectionKey or NSPersistentStoreFileProtectionKey explicitly, so the default will be NSFileProtectionCompleteUntilFirstUserAuthentication. Does the same issue happen if the notifications arrive in the lockscreen AFTER the first device passcode entry?

@JohnEstropia commented on GitHub (Jul 5, 2024): I see. CoreStore doesn't set any `NSFileProtectionKey` or `NSPersistentStoreFileProtectionKey` explicitly, so the default will be `NSFileProtectionCompleteUntilFirstUserAuthentication`. Does the same issue happen if the notifications arrive in the lockscreen AFTER the first device passcode entry?

adam commented

@imrobbyrc commented on GitHub (Jul 5, 2024):

I see. CoreStore doesn't set any NSFileProtectionKey or NSPersistentStoreFileProtectionKey explicitly, so the default will be NSFileProtectionCompleteUntilFirstUserAuthentication. Does the same issue happen if the notifications arrive in the lockscreen AFTER the first device passcode entry?

yes, as long as the device is locked it will be fail to initiate datastack

@imrobbyrc commented on GitHub (Jul 5, 2024): > I see. CoreStore doesn't set any `NSFileProtectionKey` or `NSPersistentStoreFileProtectionKey` explicitly, so the default will be `NSFileProtectionCompleteUntilFirstUserAuthentication`. Does the same issue happen if the notifications arrive in the lockscreen AFTER the first device passcode entry? yes, as long as the device is locked it will be fail to initiate datastack

adam commented

@imrobbyrc commented on GitHub (Jul 5, 2024):

how i can set data NSPersistentStoreFileProtectionKey and NSFileProtectionKey ? i see in source code it only let variable

@imrobbyrc commented on GitHub (Jul 5, 2024): how i can set data `NSPersistentStoreFileProtectionKey` and `NSFileProtectionKey` ? i see in source code it only let variable <img width="609" alt="Screenshot 2024-07-05 at 09 43 50" src="https://github.com/JohnEstropia/CoreStore/assets/25898417/6796e7f5-2afa-4d28-806f-5d566fb51c5b">

adam commented

@JohnEstropia commented on GitHub (Jul 5, 2024):

I'll add a way to set these flags. In the meantime, if you need it sooner you might want to fork CoreStore temporarily and add the necessary flags in the code you screenshot above

@JohnEstropia commented on GitHub (Jul 5, 2024): I'll add a way to set these flags. In the meantime, if you need it sooner you might want to fork CoreStore temporarily and add the necessary flags in the code you screenshot above

adam commented

@imrobbyrc commented on GitHub (Jul 5, 2024):

I'll add a way to set these flags. In the meantime, if you need it sooner you might want to fork CoreStore temporarily and add the necessary flags in the code you screenshot above

yes i need it sooner as my crashlytics going down 😅 thankyou for your help @JohnEstropia

@imrobbyrc commented on GitHub (Jul 5, 2024): > I'll add a way to set these flags. In the meantime, if you need it sooner you might want to fork CoreStore temporarily and add the necessary flags in the code you screenshot above yes i need it sooner as my crashlytics going down 😅 thankyou for your help @JohnEstropia

adam commented