mirror of
https://github.com/JohnEstropia/CoreStore.git
synced 2026-01-14 07:33:28 +01:00
operator redeclaration make verification fail of swiftinterface #412
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JCSooHwanCho on GitHub (Jun 14, 2023).
in addition to #480 , operator redeclaration made verification fail of .swiftinterface file. It can be resolved with only one declaration in module.
@JohnEstropia commented on GitHub (Jun 15, 2023):
Interesting. Can you tell me how (SPM, Cocoapods, etc.) you are importing CoreStore into your dependencies?
@JCSooHwanCho commented on GitHub (Jun 15, 2023):
I made it as static .xcframework using bazel.
In fact, there is a workaround. That is giving an
no-verify-emitted-module-interfaceoption to compiler. But I think it should be not user's concern.@JohnEstropia commented on GitHub (Jun 15, 2023):
I'm not very familiar with Bezel, but I'm not sure there is a way library authors can specify compiler directives when the code is compiled as a static library. The formally supported installation modes build frameworks instead of a static lib, so I think this should be handled on the API users' side.
On that note, the specific issue on operators can be avoided at least, since CoreStore can just declare it once for the whole module. I'll push something later just to avoid this case, but I'd warn that this fix is local to CoreStore. If an external static library declares their own
.=and.==operators it's likely you will have this same issue anyway.@JCSooHwanCho commented on GitHub (Jun 15, 2023):
Conflicting with other module is just potential problem, but conflicting within module is present problem. How about focusing on present problem?
@JohnEstropia commented on GitHub (Jun 15, 2023):
Yes, I mentioned here:
Feel free to make a PR ahead, if you have time.
@JCSooHwanCho commented on GitHub (Jun 15, 2023):
I'll make it. Thanks for quick reply!