starred/CoreStore-JohnEstropia
1
0
Fork 0
mirror of https://github.com/JohnEstropia/CoreStore.git synced 2026-08-29 22:57:23 +02:00
Code Issues 95 Packages Projects Releases 10 Wiki Activity

.beginAsynchronous will check for main thread #4

New Issue
Closed
opened 2025-12-29 18:21:18 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:21:18 +01:00
Owner
Copy Link
Copy Source

Originally created by @SteveKChiu on GitHub (Jul 9, 2015).

I am not sure why this assert is needed, as the code show it immediately jump to different queue.

This is what I am doing, I fetch json from server in different queue; upon completion I call .beginAsynchronous to start transaction to store the object, and at that time the queue is NOT main queue.

So my question is whether it is absolutely necessary to call .beginAsynchronous in the main thread? Or we can remove this assertion?

Originally created by @SteveKChiu on GitHub (Jul 9, 2015). I am not sure why this assert is needed, as the code show it immediately jump to different queue. This is what I am doing, I fetch json from server in different queue; upon completion I call .beginAsynchronous to start transaction to store the object, and at that time the queue is _NOT_ main queue. So my question is whether it is absolutely necessary to call .beginAsynchronous in the main thread? Or we can remove this assertion?
adam added the enhancementfixed labels 2025-12-29 18:21:18 +01:00
adam closed this issue 2025-12-29 18:21:18 +01:00
adam commented 2025-12-29 18:21:19 +01:00
Author
Owner
Copy Link
Copy Source

@JohnEstropia commented on GitHub (Jul 9, 2015):

@SteveKChiu You're right, they are completely unnecessary and should be thread-safe without them. There's probably a couple more places where thread checks are overprotective, but I'll remove the ones from the beginXXXX() methods. Thanks!

@JohnEstropia commented on GitHub (Jul 9, 2015): @SteveKChiu You're right, they are completely unnecessary and should be thread-safe without them. There's probably a couple more places where thread checks are overprotective, but I'll remove the ones from the `beginXXXX()` methods. Thanks!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
abandoned
corestore bug
discussion
duplicate
enhancement
fixed
fixed
help wanted
in progress
investigating
ios/compiler bug
irreproducible
looking for workarounds
not a bug
pending
pending docs update
pull-request
Mirrored from GitHub Pull Request
 question
regression
user bug
wontfix
No labels enhancement fixed
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#4