fetchLimit is not working with ListPublisher #296

New Issue

Closed

opened 2025-12-29 18:25:24 +01:00 by adam · 3 comments

adam commented 2025-12-29 18:25:24 +01:00

Owner

Copy Link

Originally created by @EricSKCheng on GitHub (Nov 13, 2019).

First I create a ListPublisher

CoreStoreDefaults.dataStack.publishList(From<Article>()
            .orderBy(.descending(\.publishDate))
            .tweak { $0.fetchLimit = 10 })

and add a addObserver

addObserver(self) { [weak self] (listPublisher) in
            
        }

however if I add a new article to the corestore, the observer will return more than 10 items.

Originally created by @EricSKCheng on GitHub (Nov 13, 2019). First I create a ListPublisher ``` CoreStoreDefaults.dataStack.publishList(From<Article>() .orderBy(.descending(\.publishDate)) .tweak { $0.fetchLimit = 10 }) ``` and add a addObserver ``` addObserver(self) { [weak self] (listPublisher) in } ``` however if I add a new article to the corestore, the observer will return more than 10 items.

adam closed this issue 2025-12-29 18:25:24 +01:00

adam commented 2025-12-29 18:25:25 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Nov 13, 2019):

This is a limitation of NSFetchedResultsController which also affects ListMonitor.

Fortunately, ListPublishers use diffing instead of relying on FRC update methods, so we can easily simulate the fetch limit by hand.(i.e. just truncate the unwanted items from the snapshot)

I'll post an update soon.

@JohnEstropia commented on GitHub (Nov 13, 2019): This is a limitation of `NSFetchedResultsController` which also affects `ListMonitor`. Fortunately, `ListPublisher`s use diffing instead of relying on FRC update methods, so we can easily simulate the fetch limit by hand.(i.e. just truncate the unwanted items from the snapshot) I'll post an update soon.

adam commented 2025-12-29 18:25:25 +01:00

Author

Owner

Copy Link

@EricSKCheng commented on GitHub (Nov 13, 2019):

Thx.

@EricSKCheng commented on GitHub (Nov 13, 2019): Thx.

adam commented 2025-12-29 18:25:25 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Nov 14, 2019):

Implemented in develop branch 👍

@JohnEstropia commented on GitHub (Nov 14, 2019): Implemented in `develop` branch 👍

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#296