ListSectionOberserver not called on insert or delete #289

New Issue

Closed

opened 2025-12-29 18:25:21 +01:00 by adam · 3 comments

adam commented 2025-12-29 18:25:21 +01:00

Owner

Copy Link

Originally created by @timfraedrich on GitHub (Oct 3, 2019).

CoreStore: 6.3.1
Swift: 5.1
Xcode: 11.0
Simulator: Xr iOS 13.0

I'm migrating all CoreData related code and models in my project to CoreStore right now, because it just seemed more convenient to me. But while replacing an NSFetchedResultsController with a sectioned list Monitor and ListSectionObserver I encountered the issue that the list does not get refreshed after an object is inserted, removed or dealt with in any other manner, because the functions of the Observer do not get called. That ultimately leads to the list being incomplete and wrong objects getting returned when clicking on a cell or - in the case of deletion - to a crash.

Here is the code I wrote:

struct DataManager {

    static let monitor = CoreStore.monitorSectionedList(
        From<MyCoreStoreObject>()
            .sectionBy(\.dayIdentifier)
            .orderBy(.descending(\.startDate))
    )

}

class ViewController: UITableViewController, ListSectionObserver {
    
    typealias ListEntityType = MyCoreStoreObject

    override func viewDidLoad() {
        DataManager.monitor.addObserver(self)
        
        super.viewDidLoad()
    }
    
    deinit {
        DataManager.monitor.removeObserver(self)
    }

    // MARK: TableView
    
    override func numberOfSections(in tableView: UITableView) -> Int {
        return DataManager.monitor.numberOfSections()
    }

    override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int {
        guard let sectionCount = DataManager.monitor.numberOfObjects(safelyIn: section) else {
            return 0
        }
        return sectionCount
    }

    override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell {
        let object = DataManager.monitor.objects(in: indexPath.section)[indexPath.row]
        let cell = ObjectCell(object: object)
        return cell
    }
    
    override func tableView(_ tableView: UITableView, viewForHeaderInSection section: Int) -> UIView? {
        let dayIdentifier = DataManager.monitor.sectionIndexTitles()[section]
        let header = ListHeader(dayIdentifier: dayIdentifier)
        return header
    }
    
    override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
        
        let workout = DataManager.monitor.objects(in: indexPath.section)[indexPath.row]
        
        // display view controller
        
    }
    
    // MARK: ListObserver
    
    func listMonitorWillChange(_ monitor: ListMonitor<MyCoreStoreObject>) {
        self.tableView.beginUpdates()
    }
    
    func listMonitorDidChange(_ monitor: ListMonitor<MyCoreStoreObject>) {
        self.tableView.endUpdates()
    }
    
    func listMonitorWillRefetch(_ monitor: ListMonitor<MyCoreStoreObject>) {
        
    }
    
    func listMonitorDidRefetch(_ monitor: ListMonitor<MyCoreStoreObject>) {
        self.tableView.reloadData()
    }
    
    // MARK: ListObjectObserver
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didInsertObject object: MyCoreStoreObject, toIndexPath indexPath: NSIndexPath) {
        let indexPath = indexPath as IndexPath
        self.tableView.insertRows(at: [indexPath], with: .fade)
    }
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didDeleteObject object: MyCoreStoreObject, fromIndexPath indexPath: NSIndexPath) {
        let indexPath = indexPath as IndexPath
        self.tableView.deleteRows(at: [indexPath], with: .fade)
    }
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didUpdateObject object: MyCoreStoreObject, atIndexPath indexPath: NSIndexPath) {
        let indexPath = indexPath as IndexPath
        if let cell = self.tableView.cellForRow(at: indexPath) as? ObjectCell {
            cell.object = object
            cell.setup()
        }
    }
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didMoveObject object: MyCoreStoreObject, fromIndexPath: NSIndexPath, toIndexPath: NSIndexPath) {
        let fromIndexPath = fromIndexPath as IndexPath
        self.tableView.deleteRows(at: [fromIndexPath], with: .fade)
        let toIndexPath = toIndexPath as IndexPath
        self.tableView.insertRows(at: [toIndexPath], with: .fade)
    }
    
    // MARK: ListSectionObserver
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didInsertSection sectionInfo: NSFetchedResultsSectionInfo, toSectionIndex sectionIndex: Int) {
        self.tableView.insertSections(IndexSet(arrayLiteral: sectionIndex), with: .fade)
    }
    
    func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didDeleteSection sectionInfo: NSFetchedResultsSectionInfo, fromSectionIndex sectionIndex: Int) {
        self.tableView.deleteSections(IndexSet(arrayLiteral: sectionIndex), with: .fade)
    }
    
}

I would greatly appreciate any help, maybe I'm just forgetting something really obvious.

Originally created by @timfraedrich on GitHub (Oct 3, 2019). CoreStore: 6.3.1 Swift: 5.1 Xcode: 11.0 Simulator: Xr iOS 13.0 I'm migrating all CoreData related code and models in my project to CoreStore right now, because it just seemed more convenient to me. But while replacing an NSFetchedResultsController with a sectioned list Monitor and ListSectionObserver I encountered the issue that the list does not get refreshed after an object is inserted, removed or dealt with in any other manner, because the functions of the Observer do not get called. That ultimately leads to the list being incomplete and wrong objects getting returned when clicking on a cell or - in the case of deletion - to a crash. Here is the code I wrote: ```swift struct DataManager { static let monitor = CoreStore.monitorSectionedList( From<MyCoreStoreObject>() .sectionBy(\.dayIdentifier) .orderBy(.descending(\.startDate)) ) } class ViewController: UITableViewController, ListSectionObserver { typealias ListEntityType = MyCoreStoreObject override func viewDidLoad() { DataManager.monitor.addObserver(self) super.viewDidLoad() } deinit { DataManager.monitor.removeObserver(self) } // MARK: TableView override func numberOfSections(in tableView: UITableView) -> Int { return DataManager.monitor.numberOfSections() } override func tableView(_ tableView: UITableView, numberOfRowsInSection section: Int) -> Int { guard let sectionCount = DataManager.monitor.numberOfObjects(safelyIn: section) else { return 0 } return sectionCount } override func tableView(_ tableView: UITableView, cellForRowAt indexPath: IndexPath) -> UITableViewCell { let object = DataManager.monitor.objects(in: indexPath.section)[indexPath.row] let cell = ObjectCell(object: object) return cell } override func tableView(_ tableView: UITableView, viewForHeaderInSection section: Int) -> UIView? { let dayIdentifier = DataManager.monitor.sectionIndexTitles()[section] let header = ListHeader(dayIdentifier: dayIdentifier) return header } override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) { let workout = DataManager.monitor.objects(in: indexPath.section)[indexPath.row] // display view controller } // MARK: ListObserver func listMonitorWillChange(_ monitor: ListMonitor<MyCoreStoreObject>) { self.tableView.beginUpdates() } func listMonitorDidChange(_ monitor: ListMonitor<MyCoreStoreObject>) { self.tableView.endUpdates() } func listMonitorWillRefetch(_ monitor: ListMonitor<MyCoreStoreObject>) { } func listMonitorDidRefetch(_ monitor: ListMonitor<MyCoreStoreObject>) { self.tableView.reloadData() } // MARK: ListObjectObserver func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didInsertObject object: MyCoreStoreObject, toIndexPath indexPath: NSIndexPath) { let indexPath = indexPath as IndexPath self.tableView.insertRows(at: [indexPath], with: .fade) } func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didDeleteObject object: MyCoreStoreObject, fromIndexPath indexPath: NSIndexPath) { let indexPath = indexPath as IndexPath self.tableView.deleteRows(at: [indexPath], with: .fade) } func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didUpdateObject object: MyCoreStoreObject, atIndexPath indexPath: NSIndexPath) { let indexPath = indexPath as IndexPath if let cell = self.tableView.cellForRow(at: indexPath) as? ObjectCell { cell.object = object cell.setup() } } func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didMoveObject object: MyCoreStoreObject, fromIndexPath: NSIndexPath, toIndexPath: NSIndexPath) { let fromIndexPath = fromIndexPath as IndexPath self.tableView.deleteRows(at: [fromIndexPath], with: .fade) let toIndexPath = toIndexPath as IndexPath self.tableView.insertRows(at: [toIndexPath], with: .fade) } // MARK: ListSectionObserver func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didInsertSection sectionInfo: NSFetchedResultsSectionInfo, toSectionIndex sectionIndex: Int) { self.tableView.insertSections(IndexSet(arrayLiteral: sectionIndex), with: .fade) } func listMonitor(_ monitor: ListMonitor<MyCoreStoreObject>, didDeleteSection sectionInfo: NSFetchedResultsSectionInfo, fromSectionIndex sectionIndex: Int) { self.tableView.deleteSections(IndexSet(arrayLiteral: sectionIndex), with: .fade) } } ``` I would greatly appreciate any help, maybe I'm just forgetting something really obvious.

adam closed this issue 2025-12-29 18:25:21 +01:00

adam commented 2025-12-29 18:25:22 +01:00

Author

Owner

Copy Link

@JohnEstropia commented on GitHub (Oct 3, 2019):

How does your transaction insert those objects? Can you show some code from the transactions side?

@JohnEstropia commented on GitHub (Oct 3, 2019): How does your transaction insert those objects? Can you show some code from the transactions side?

adam commented 2025-12-29 18:25:22 +01:00

Author

Owner

Copy Link

@timfraedrich commented on GitHub (Oct 3, 2019):

Can you show some code from the transaction

Yes of course:

static func saveObject(..., completion: @escaping (Bool, Error?, MyCoreStoreObject?) -> Void) {
        
    CoreStore.perform(asynchronous: { (transaction) -> MyCoreStoreObject in
        let object = transaction.create(Into<MyCoreStoreObject>())
        object. ...

        for data in dataArray {
            let dataObject = transaction.create(Into<DataObject>())
            dataObject. ...
            dataObject.object .= object
        }

        return object

    }) { (result) in
        switch result {
        case .success(let object):
            completion(true, nil, object)
        case .failure(let error):
            completion(false, error, nil)
        }
    }
}

I did try to insert it in other ways though (with unsafe and synchronous transactions) and that did not do anything different. The object is also there after I restart the app. The Observer is just not notified of a change.

@timfraedrich commented on GitHub (Oct 3, 2019): > Can you show some code from the transaction Yes of course: ```swift static func saveObject(..., completion: @escaping (Bool, Error?, MyCoreStoreObject?) -> Void) { CoreStore.perform(asynchronous: { (transaction) -> MyCoreStoreObject in let object = transaction.create(Into<MyCoreStoreObject>()) object. ... for data in dataArray { let dataObject = transaction.create(Into<DataObject>()) dataObject. ... dataObject.object .= object } return object }) { (result) in switch result { case .success(let object): completion(true, nil, object) case .failure(let error): completion(false, error, nil) } } } ``` I did try to insert it in other ways though (with unsafe and synchronous transactions) and that did not do anything different. The object is also there after I restart the app. The Observer is just not notified of a change.

adam commented 2025-12-29 18:25:22 +01:00

Author

Owner

Copy Link

@timfraedrich commented on GitHub (Oct 4, 2019):

Okay I found the solution: It turns out one should not blindly copy code from the documentation. It seems that it is not accurate anymore, since the NSIndexPath changed to IndexPath. The Observer now gets called with no issues.

@timfraedrich commented on GitHub (Oct 4, 2019): Okay I found the solution: It turns out one should not blindly copy code from the documentation. It seems that it is not accurate anymore, since the NSIndexPath changed to IndexPath. The Observer now gets called with no issues.

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

adam

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#289