"<Class> does not conform to protocol 'ImportableUniqueObject'" when updating to CoreStore 3.1.0 #132

New Issue

Closed

opened 2025-12-29 18:23:24 +01:00 by adam · 2 comments

adam commented 2025-12-29 18:23:24 +01:00

Owner

Copy Link

Copy Source

Originally created by @wbuchner on GitHub (Mar 29, 2017).

Im updating from Swift 2 -> 3.1.0 and run across an issue I need some help with.
My class is below. It works beautifully in Swift 2.0 and I haven't had any issues. I am experiencing an issue with some warnings, and the Xcode telling me that I am not fully complying with the protocol. I can't see anything missing.
Can you please see what I cannot? I would appreciate it.

This is the warning I am getting

public class Contact: SEManagedObject, ImportableUniqueObject {

    public typealias ImportSource = [String:AnyObject]
    public typealias UniqueIDType = NSObject

    /**
     Description
     
     - parameter data: the dictionary with the data to save
     - returns
     */
    class func storeContact(
        data: [NSDictionary],
        success: @escaping (SaveResult) -> Void,
        failure: @escaping (SaveResult) -> Void) {

        //  swiftlint:disable:next identifier_name
        CoreStore.beginAsynchronous { (AsynchronousDataTransaction) in
           let result = try! AsynchronousDataTransaction.importUniqueObjects(
                Into(Contact.self), sourceArray: (data as? [[String:AnyObject]])!
            )
        }
    }
    public func update(from source: Contact.ImportSource, in transaction: BaseDataTransaction) throws {

    }

    //  swiftlint:disable:next function_body_length
    public static func shouldUpdate(from source: Contact.ImportSource,
                                    in transaction: BaseDataTransaction) -> Bool {
        // all insert code here
        return true
    }

    public static func shouldInsert(from source: Contact.ImportSource,
                                    in transaction: BaseDataTransaction) -> Bool {
        return true
    }

    public var uniqueIDValue: NSObject {
        get { return self.identification! as NSObject }
        set {
            self.identification = (newValue as? String)!
        }
    }

    public func didInsert(from source: Contact.ImportSource, in transaction: BaseDataTransaction) throws {
        
    }
    public static var uniqueIDKeyPath: String {
        return "identification"
    }
 
   public static func uniqueID(from source: Contact.ImportSource,
                         in transaction: BaseDataTransaction) throws -> Contact.UniqueIDType? {
        let contact = source["contact"]
        return contact!["Id"] as? NSString
    }
}

Originally created by @wbuchner on GitHub (Mar 29, 2017). Im updating from Swift 2 -> 3.1.0 and run across an issue I need some help with. My class is below. It works beautifully in Swift 2.0 and I haven't had any issues. I am experiencing an issue with some warnings, and the Xcode telling me that I am not fully complying with the protocol. I can't see anything missing. Can you please see what I cannot? I would appreciate it. This is the warning I am getting  ```swift public class Contact: SEManagedObject, ImportableUniqueObject { public typealias ImportSource = [String:AnyObject] public typealias UniqueIDType = NSObject /** Description - parameter data: the dictionary with the data to save - returns */ class func storeContact( data: [NSDictionary], success: @escaping (SaveResult) -> Void, failure: @escaping (SaveResult) -> Void) { // swiftlint:disable:next identifier_name CoreStore.beginAsynchronous { (AsynchronousDataTransaction) in let result = try! AsynchronousDataTransaction.importUniqueObjects( Into(Contact.self), sourceArray: (data as? [[String:AnyObject]])! ) } } public func update(from source: Contact.ImportSource, in transaction: BaseDataTransaction) throws { } // swiftlint:disable:next function_body_length public static func shouldUpdate(from source: Contact.ImportSource, in transaction: BaseDataTransaction) -> Bool { // all insert code here return true } public static func shouldInsert(from source: Contact.ImportSource, in transaction: BaseDataTransaction) -> Bool { return true } public var uniqueIDValue: NSObject { get { return self.identification! as NSObject } set { self.identification = (newValue as? String)! } } public func didInsert(from source: Contact.ImportSource, in transaction: BaseDataTransaction) throws { } public static var uniqueIDKeyPath: String { return "identification" } public static func uniqueID(from source: Contact.ImportSource, in transaction: BaseDataTransaction) throws -> Contact.UniqueIDType? { let contact = source["contact"] return contact!["Id"] as? NSString } } ```

adam added the question label 2025-12-29 18:23:24 +01:00

adam closed this issue 2025-12-29 18:23:24 +01:00

adam commented 2025-12-29 18:23:25 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Mar 29, 2017):

@wbuchner Hi, starting CoreStore 3.0.3 the ImportSource does not need to be NSObject.
You can use typealias UniqueIDType = String or NSString directly.

Also, var uniqueIDValue now has a default protocol implementation (you can remove it completely from your code) as long as you specify the var uniqueIDKeyPath correctly.

Please check ImportableUniqueObject.swift for the actual changes and ImportableAttributeType.swift for a list of supported UniqueIDType types.

@JohnEstropia commented on GitHub (Mar 29, 2017): @wbuchner Hi, starting CoreStore 3.0.3 the `ImportSource` does not need to be `NSObject`. You can use `typealias UniqueIDType = String` or `NSString` directly. Also, `var uniqueIDValue` now has a default protocol implementation (you can remove it completely from your code) as long as you specify the `var uniqueIDKeyPath` correctly. Please check ImportableUniqueObject.swift for the actual changes and ImportableAttributeType.swift for a list of supported `UniqueIDType` types.

adam commented 2025-12-29 18:23:25 +01:00

Author

Owner

Copy Link

Copy Source

@wbuchner commented on GitHub (Mar 29, 2017):

Thank you John!

@wbuchner commented on GitHub (Mar 29, 2017): Thank you John!

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels question

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#132