Add ability to pass persistent store options as parameter #11

New Issue

Closed

opened 2025-12-29 18:21:22 +01:00 by adam · 1 comment

adam commented 2025-12-29 18:21:22 +01:00

Owner

Copy Link

Copy Source

Originally created by @sidlatau on GitHub (Sep 28, 2015).

I was unable to enable automatic migrations without modifying CoreStore code (to enable NSMigratePersistentStoresAutomaticallyOption and NSInferMappingModelAutomaticallyOption flags).

I added additional parameter to addSQLiteStoreAndWait method for passing options.

    try dataStack.addSQLiteStoreAndWait(
        fileURL: sqliteFileURL, // set the target file URL for the sqlite file
        storeOptions: [NSSQLitePragmasOption: ["journal_mode": "WAL"], NSMigratePersistentStoresAutomaticallyOption: true, NSInferMappingModelAutomaticallyOption: true]
    )

Is there a better way to enable automatic migrations without this modification?

Originally created by @sidlatau on GitHub (Sep 28, 2015). I was unable to enable automatic migrations without modifying CoreStore code (to enable NSMigratePersistentStoresAutomaticallyOption and NSInferMappingModelAutomaticallyOption flags). I added additional parameter to addSQLiteStoreAndWait method for passing options. ``` try dataStack.addSQLiteStoreAndWait( fileURL: sqliteFileURL, // set the target file URL for the sqlite file storeOptions: [NSSQLitePragmasOption: ["journal_mode": "WAL"], NSMigratePersistentStoresAutomaticallyOption: true, NSInferMappingModelAutomaticallyOption: true] ) ``` Is there a better way to enable automatic migrations without this modification?

adam added the question label 2025-12-29 18:21:22 +01:00

adam closed this issue 2025-12-29 18:21:22 +01:00

adam commented 2025-12-29 18:21:23 +01:00

Author

Owner

Copy Link

Copy Source

@JohnEstropia commented on GitHub (Sep 28, 2015):

@sidlatau Thanks for the feedback!
The DataStack already sets ["journal_mode": "WAL"] for you! If you search the code for "journal_mode": "WAL" you'll see that it's being set inside addSQLiteStoreAndWait(...).

As for NSMigratePersistentStoresAutomaticallyOption, and NSInferMappingModelAutomaticallyOption, CoreStore is smart enough to do the same migration introspection without setting these flags. But, CoreStore does not allow migrations when you use addSQLiteStoreAndWait(...) because this is a blocking method and migrations may take time. To support migrations, you have to use the asynchronous methods of the form addSQLiteStore(... completion:) instead.

It will help you a lot if you read the README on migrations for more details. Feel free to ask any other questions!

@JohnEstropia commented on GitHub (Sep 28, 2015): @sidlatau Thanks for the feedback! The `DataStack` already sets `["journal_mode": "WAL"]` for you! If you search the code for **"journal_mode": "WAL"** you'll see that it's being set inside `addSQLiteStoreAndWait(...)`. As for `NSMigratePersistentStoresAutomaticallyOption`, and `NSInferMappingModelAutomaticallyOption`, CoreStore is smart enough to do the same migration introspection without setting these flags. But, CoreStore does not allow migrations when you use `addSQLiteStoreAndWait(...)` because this is a blocking method and migrations may take time. To support migrations, you have to use the asynchronous methods of the form `addSQLiteStore(... completion:)` instead. It will help you a lot if you read the README on [migrations](https://github.com/JohnEstropia/CoreStore#migrations) for more details. Feel free to ask any other questions!

adam referenced this issue 2025-12-29 18:22:34 +01:00

Main Thread Deadlock #84

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

develop

prototype/swift6

master

prototype/concurrency

minIOS13

prototype/containers

transactionSourceTracking

prototype/swiftui

minIOS11

swift5_3

prototype/propertyWrapperFields

prototype/propertyWrappers

prototype/propertyWrapper

Swift5

throwables

prototype/Swift_4_1

prototype/Swift_4_0

prototype/Swift_3_2

prototype/queryBuilders

temp/develop

corestore4_develop

prototype/mainContextToPSC

master_ios_7_to_9

swift_2_3

gh-pages

_corespotlight-test

9.3.0

9.2.0

9.1.0

9.0.0

8.1.0

8.0.1

8.0.0

7.3.1

7.3.0

7.2.0

7.1.0

7.0.4

7.0.3

7.0.2

7.0.1

7.0.0

6.3.2

6.3.1

6.3.0

6.2.1

6.2.0

6.1.0

6.0.0

5.3.1

5.3.0

5.2.0

5.1.1

5.1.0

5.0.0

4.2.4

4.2.3

4.2.2

4.2.1

4.2.0

4.1.4

4.1.3

4.1.1

4.1.0

4.0.5

4.0.4

4.0.3

4.0.2

4.0.1

4.0.0

4.0.0-beta3

4.0.0-beta2

4.0.0-beta

3.1.1

3.1.0

3.0.3

3.0.2

3.0.1

3.0.0

2.1.3

2.1.2

2.1.1

2.1.0

2.0.6

2.0.5

2.0.4

2.0.3

2.0.2

2.0.1

2.0.0

1.6.10

1.6.9

1.6.8

1.6.7

1.6.6

1.6.5

1.6.4

1.6.3

1.6.2

1.6.1

1.6.0

1.5.4

1.5.3

1.5.2

1.5.1

1.5.0

1.4.4

1.4.3

1.4.2

1.4.1

1.4.0

1.3.6

1.3.5

1.3.4

1.3.3

1.3.2

1.3.1

1.3.0

1.2.1

1.2.0

1.0.2

1.0.1

1.0.0

0.2.1

0.2.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

abandoned

corestore bug

discussion

duplicate

enhancement

fixed

fixed

help wanted

in progress

investigating

ios/compiler bug

irreproducible

looking for workarounds

not a bug

pending

pending docs update

pull-request

Mirrored from GitHub Pull Request

question

regression

user bug

wontfix

No labels question

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/CoreStore-JohnEstropia#11