[PR #33] [MERGED] Fix localization by getting the framework bundle #97

New Issue

Closed

opened 2025-12-29 18:29:03 +01:00 by adam · 0 comments

adam commented 2025-12-29 18:29:03 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/33
Author: @phimage
Created: 12/11/2015
Status: ✅ Merged
Merged: 12/14/2015
Merged by: @coneybeare

Base: master ← Head: patch-1

---

📝 Commits (1)

• ce4d4a4 Fix localization by getting the framework bundle

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 Source/Armchair.swift (+1 -1)

📄 Description

I use compiled framework (with cocoapod or carthage)
Localization does'nt work because main bundle is used (there is no .bundle)
So the fix allow to use the correct framework bundle

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/33 **Author:** [@phimage](https://github.com/phimage) **Created:** 12/11/2015 **Status:** ✅ Merged **Merged:** 12/14/2015 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`ce4d4a4`](https://github.com/UrbanApps/Armchair/commit/ce4d4a42ff62dcffec56fd7980e8d61ad1814f6e) Fix localization by getting the framework bundle ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `Source/Armchair.swift` (+1 -1) </details> ### 📄 Description I use compiled framework (with cocoapod or carthage) Localization does'nt work because main bundle is used (there is no .bundle) So the fix allow to use the correct framework bundle --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-29 18:29:03 +01:00

adam closed this issue 2025-12-29 18:29:03 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

master

swift3

assets

0.3.7

0.3.6

0.3.5

0.3.3

0.3.2

0.3.0

0.1.2

0.1.1

0.1.0

Labels

Clear labels

enhancement

pull-request

Mirrored from GitHub Pull Request

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Armchair#97