Incorrect calculation in "RemindMeLater" code #80

New Issue

adam · 2025-12-29T18:28:57+01:00

adam commented

2025-12-29 18:28:57 +01:00

Originally created by @jeromeDefReputation on GitHub (Jun 25, 2019).

// If the user wanted to be reminded later, has enough time passed?
        let timeIntervalOfReminder = userDefaultsObject?.doubleForKey(keyForArmchairKeyType(ArmchairKey.ReminderRequestDate))
        if let timeInterval = timeIntervalOfReminder {
            let reminderRequestDate = Date(timeIntervalSince1970: timeInterval)
            let timeSinceReminderRequest = Date().timeIntervalSince(reminderRequestDate)
            let timeUntilReminder: TimeInterval = 60 * 60 * 24 * Double(daysBeforeReminding)
            if timeSinceReminderRequest < timeUntilReminder {
                return false
            }
        } else {
            return false
        }

If the amount of time since the current timestamp and the request timestamp is greater than 0, return true if by 'true' is we can show prompt.

Originally created by @jeromeDefReputation on GitHub (Jun 25, 2019). ``` // If the user wanted to be reminded later, has enough time passed? let timeIntervalOfReminder = userDefaultsObject?.doubleForKey(keyForArmchairKeyType(ArmchairKey.ReminderRequestDate)) if let timeInterval = timeIntervalOfReminder { let reminderRequestDate = Date(timeIntervalSince1970: timeInterval) let timeSinceReminderRequest = Date().timeIntervalSince(reminderRequestDate) let timeUntilReminder: TimeInterval = 60 * 60 * 24 * Double(daysBeforeReminding) if timeSinceReminderRequest < timeUntilReminder { return false } } else { return false } ``` If the amount of time since the current timestamp and the request timestamp is greater than 0, return true if by 'true' is we can show prompt.

adam referenced this issue

2025-12-29 18:29:09 +01:00

[PR #80] [MERGED] Update check for iOS Simulator #117

adam referenced this issue

2025-12-29 18:29:10 +01:00

[PR #86] [MERGED] Swift3 #121

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Armchair#80