Mac Version doesn't compile #73

New Issue

adam · 2025-12-29T18:28:55+01:00

adam commented

2025-12-29 18:28:55 +01:00

Originally created by @Vithanco on GitHub (Feb 4, 2018).

I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS.

#if os(iOS)
    public func useStoreKitReviewPrompt() -> Bool {
...

but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions.

    public var shouldTryStoreKitReviewPrompt : Bool {
        if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true }

Please review. Thanks for this great library.

Originally created by @Vithanco on GitHub (Feb 4, 2018). I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS. ``` #if os(iOS) public func useStoreKitReviewPrompt() -> Bool { ... ``` but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions. ``` public var shouldTryStoreKitReviewPrompt : Bool { if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true } ``` Please review. Thanks for this great library.

adam commented

2025-12-29 18:28:55 +01:00

@Vithanco commented on GitHub (Feb 4, 2018):

I don't think this issue was introduced with a8c1dfd.

@Vithanco commented on GitHub (Feb 4, 2018): I don't think this issue was introduced with a8c1dfd.

adam commented

2025-12-29 18:28:55 +01:00

@coneybeare commented on GitHub (Feb 28, 2018):

It was introduced on https://github.com/UrbanApps/Armchair/pull/112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.

@coneybeare commented on GitHub (Feb 28, 2018): It was introduced on https://github.com/UrbanApps/Armchair/pull/112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.

adam referenced this issue

2025-12-29 18:29:07 +01:00

[PR #73] [CLOSED] Migrate the project to Swift 3 #112

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Armchair#73