starred/Armchair
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-01-14 14:23:25 +01:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

Using the store kit review prompt will ask for reviews forever if the user taps "Not Now" #60

New Issue
Closed
opened 2025-12-29 18:28:48 +01:00 by adam · 1 comment
adam commented 2025-12-29 18:28:48 +01:00
Owner
Copy Link

Originally created by @ari3l on GitHub (May 9, 2017).

SKStoreReviewController doesn't have an API that tells us if the user submits a review, as a result, if rating conditions are met the library will constantly ask for a review.

I fixed this locally by setting UserDefaults to mark the current version as reviewed when calling requestReview(). This means that the user will see the review prompt once per version, regardless if the user rates or not.

I can submit a PR with the fix, but I'm not sure if that would be the correct approach. Let me know what you guys think!

Originally created by @ari3l on GitHub (May 9, 2017). [SKStoreReviewController](https://developer.apple.com/reference/storekit/skstorereviewcontroller) doesn't have an API that tells us if the user submits a review, as a result, if rating conditions are met the library will constantly ask for a review. I fixed this locally by setting UserDefaults to mark the current version as reviewed when calling `requestReview()`. This means that the user will see the review prompt once per version, regardless if the user rates or not. I can submit a PR with the fix, but I'm not sure if that would be the correct approach. Let me know what you guys think!
adam closed this issue 2025-12-29 18:28:48 +01:00
adam commented 2025-12-29 18:28:49 +01:00
Author
Owner
Copy Link

@coneybeare commented on GitHub (May 12, 2017):

I think your approach is reasonable. Thanks for catching that

@coneybeare commented on GitHub (May 12, 2017): I think your approach is reasonable. Thanks for catching that
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair#60
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?