iOS 10.3 API #57

Originally created by @jackcsk on GitHub (Feb 1, 2017).

Just writing to find out if Armchair plans to provide transparent support for iOS 10.3

i.e. call SKStoreReviewController's requestReview() method on iOS 10.3, and use current routine on iOS 10.2 or below

Originally created by @jackcsk on GitHub (Feb 1, 2017). Just writing to find out if Armchair plans to provide transparent support for iOS 10.3 i.e. call SKStoreReviewController's `requestReview()` method on iOS 10.3, and use current routine on iOS 10.2 or below

adam closed this issue

adam commented

@coneybeare commented on GitHub (Feb 10, 2017):

This is definitely something I will look into as more details emerge.

@coneybeare commented on GitHub (Feb 10, 2017): This is definitely something I will look into as more details emerge.

adam commented

@jlaws commented on GitHub (Mar 11, 2017):

+1

@jlaws commented on GitHub (Mar 11, 2017): +1

adam commented

@jlaws commented on GitHub (Mar 29, 2017):

10.3 is out
https://developer.apple.com/reference/storekit/skstorereviewcontroller

@jlaws commented on GitHub (Mar 29, 2017): 10.3 is out https://developer.apple.com/reference/storekit/skstorereviewcontroller

adam commented

@jlaws commented on GitHub (Mar 29, 2017):

For those that don't want to wait for the library to add support, you can do this where you setup Armchair:

Armchair.shouldPromptClosure { info -> Bool in
  if #available(iOS 10.3, *) {
    SKStoreReviewController.requestReview()
    return false
  } else {
    return true
  }
}

@jlaws commented on GitHub (Mar 29, 2017): For those that don't want to wait for the library to add support, you can do this where you setup Armchair: Armchair.shouldPromptClosure { info -> Bool in if #available(iOS 10.3, *) { SKStoreReviewController.requestReview() return false } else { return true } }

adam commented

@ari3l commented on GitHub (May 5, 2017):

Took a shot at implementing this.
Just made a PR based off @jlaws code.

@ari3l commented on GitHub (May 5, 2017): Took a shot at implementing this. Just made a [PR](https://github.com/UrbanApps/Armchair/pull/92) based off @jlaws code.

adam commented

@coneybeare commented on GitHub (May 7, 2017):

This needs to be opt-in, so previous expected behavior is not altered. Please add a public var to enable this logic and I will merge in.

@coneybeare commented on GitHub (May 7, 2017): This needs to be opt-in, so previous expected behavior is not altered. Please add a public var to enable this logic and I will merge in.

adam commented

@ari3l commented on GitHub (May 7, 2017):

@coneybeare
I don't understand. The feature is already opt-in. By default no behavior is altered. To use the new review prompt, simply do this:

        Armchair.appID("xxxxxxx")
        Armchair.useStoreKitReviewPrompt(true) // This alters the default behavior -- default is false

@ari3l commented on GitHub (May 7, 2017): @coneybeare I don't understand. The feature is already opt-in. By default no behavior is altered. To use the new review prompt, simply do this: ``` swift Armchair.appID("xxxxxxx") Armchair.useStoreKitReviewPrompt(true) // This alters the default behavior -- default is false ```

adam commented

@coneybeare commented on GitHub (May 8, 2017):

Yes you're right. Sorry, I misread your comment earlier as in future tense. I just reviewed your PR, looks great.

@coneybeare commented on GitHub (May 8, 2017): Yes you're right. Sorry, I misread your comment earlier as in future tense. I just reviewed your PR, looks great.

adam commented

@umekun123 commented on GitHub (Sep 2, 2017):

I cannot see Armchair.useStoreKitReviewPrompt(true) on 4.4, is it disabled for some reason?

@umekun123 commented on GitHub (Sep 2, 2017): I cannot see Armchair.useStoreKitReviewPrompt(true) on 4.4, is it disabled for some reason?

adam commented

@coneybeare commented on GitHub (Sep 2, 2017):

We have no version 4.4, are you sure you are looking at the right pod?

@coneybeare commented on GitHub (Sep 2, 2017): We have no version 4.4, are you sure you are looking at the right pod?

adam commented