mirror of
https://github.com/UrbanApps/Armchair.git
synced 2026-07-23 21:18:40 +02:00
swift 3 #48
Assignees
adam (Adam Melkus)
Clear assignees
adam (Adam Melkus)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: starred/Armchair#48
Reference in New Issue
Block a user
Originally created by @kapellanos on GitHub (Aug 10, 2016).
any plan to migrate the pod to swift 3 syntax?
@coneybeare commented on GitHub (Aug 12, 2016):
Can't accept PR's until out of beta
@KyleMay commented on GitHub (Aug 21, 2016):
Why not have a separate Swift 3 branch until it's out of beta like a lot of other libraries do?
@kevinlieser commented on GitHub (Sep 11, 2016):
Whats the status?
@coneybeare commented on GitHub (Sep 11, 2016):
I made the swift3 branch shortly after the above comment, nobody has send me a pull request to it as requested. https://github.com/UrbanApps/Armchair/tree/swift3
@bjaskj commented on GitHub (Sep 19, 2016):
Status? Need this to work on xcode 8 with carthage.
@coneybeare commented on GitHub (Sep 19, 2016):
@bjaskj you can see the swift 3 branch here: https://github.com/UrbanApps/Armchair/tree/swift3 feel free to submit a pull request if it is not working for you.
@donpironet commented on GitHub (Sep 26, 2016):
Can you please update the project to Swift 3 so I can update via carthage?
@coneybeare commented on GitHub (Sep 26, 2016):
@donpironet There is a swift3 branch you can use here
@donpironet commented on GitHub (Sep 29, 2016):
Thanks. What do I need to specify to get it via carthage?
EDIT: it can be done via git "https://github.com/UrbanApps/Armchair.git" "swift3"
@codytwinton commented on GitHub (Oct 3, 2016):
Any update on merging the
swift3branch intomasterand issuing a release? Especially for Cocoapods?@donpironet commented on GitHub (Oct 12, 2016):
+1 for cocoapods request.
@jlaws commented on GitHub (Oct 22, 2016):
+1
@3adel commented on GitHub (Oct 30, 2016):
+1
@makoni commented on GitHub (Oct 31, 2016):
Is there any good alternative? Swift 3.0.1 released and there's still nothing happened
@coneybeare commented on GitHub (Oct 31, 2016):
I haven't had time to resolve the merge conflicts in the other PR's that update to the swift 3 branch. If somebody wants to submit a PR with the appropriate edits to the master branch, I will take a look and merge if all is good.
@andrewschreiber commented on GitHub (Feb 7, 2017):
Meanwhile for swift 3 projects, put this in your Podfile:
Works fine with Swift 3.0.1
@Jeehut commented on GitHub (Apr 28, 2017):
I just wanted to use this library but it seems it's not being maintained any more. @coneybeare clearly lost interest (it's more than half a year after the Swift 3 release and still no native Swift 3 support!) so I'm unstar-ing this and opting for Appirater instead which is written in Objective-C (which I wanted to prevent) but at least it's actively maintained and maps well to Swift.
In the future there will probably be a completely different approach to this issue anyway as Apple has introduced the new in-app review APIs. See the Human Interface Guidelines for it here. We just need to wait until iOS 10.3 is far more distributed amongst users ...