starred/Armchair
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-01-14 14:23:25 +01:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

Remind button always shows if remindButtonTitle is set #28

New Issue
Closed
opened 2025-12-29 18:28:23 +01:00 by adam · 2 comments
adam commented 2025-12-29 18:28:23 +01:00
Owner
Copy Link

Originally created by @JagCesar on GitHub (Apr 19, 2016).

Hey!

Let me start of by thanking you for writing this. Much love.

I ran across a bug and wanted to report it, not sure if I'm missing something. If it's a bug I'll gladly fix it and send a PR.

If daysBeforeReminding is set to zero and remindButtonTitle is set, the remind Button appears in the rate pop up. The bug seems to be in showsRemindButton()

showsRemindButton() should return false if daysBeforeReminding is set to zero.

Originally created by @JagCesar on GitHub (Apr 19, 2016). Hey! Let me start of by thanking you for writing this. Much love. I ran across a bug and wanted to report it, not sure if I'm missing something. If it's a bug I'll gladly fix it and send a PR. If `daysBeforeReminding` is set to zero and `remindButtonTitle` is set, the remind Button appears in the rate pop up. The bug seems to be in [showsRemindButton()](https://github.com/UrbanApps/Armchair/blob/master/Source/Armchair.swift#L1136) `showsRemindButton()` should return false if `daysBeforeReminding` is set to zero.
adam closed this issue 2025-12-29 18:28:23 +01:00
adam commented 2025-12-29 18:28:24 +01:00
Author
Owner
Copy Link

@coneybeare commented on GitHub (Apr 21, 2016):

I agree, that looks like an oversight, considering we do a similar check here. I would entertain a pull request fixing it.

@coneybeare commented on GitHub (Apr 21, 2016): I agree, that looks like an oversight, considering we do a similar check [here](https://github.com/UrbanApps/Armchair/blob/master/Source/Armchair.swift#L765). I would entertain a pull request fixing it.
adam commented 2025-12-29 18:28:24 +01:00
Author
Owner
Copy Link

@JagCesar commented on GitHub (Apr 22, 2016):

Sweet. I'm on it.

@JagCesar commented on GitHub (Apr 22, 2016): Sweet. I'm on it.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair#28
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?