mirror of
https://github.com/UrbanApps/Armchair.git
synced 2026-01-14 14:23:25 +01:00
UIAlertView is deprecated #24
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jlaws on GitHub (Dec 15, 2015).
You should use UIAlertController instead.
@coneybeare commented on GitHub (Dec 15, 2015):
I will entertain a pull request that maintains backwards compatibility.
@phimage commented on GitHub (Dec 15, 2015):
@jlaws just set
usesAlertControllerto true for the moment@coneybeare Maybe we could change the default value of
usesAlertControllertotrue? or (according to iOS version > 9)@coneybeare commented on GitHub (Dec 15, 2015):
I like that idea of setting the default to true based on
operatingSystemVersion@jlaws commented on GitHub (Apr 17, 2016):
Finally got around to looking at this thread again. My concern was the build warning:
Armchair-Swift.h:130:20: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert insteadConsidering that 95% or 97.5% of devices are running iOS 8+ it is probably safe to make the min target for the library iOS 8 and use alert controllers exclusively. Just create a fork and leave the old cocoapods for people who want to target earlier versions.
Another option is to suppress the warning inside the library.
@tbaranes commented on GitHub (Apr 17, 2016):
I agree with @jlaws solution. If you really don't want to target only iOS8+, you should suppress that warning directly in the library.
@coneybeare commented on GitHub (Apr 17, 2016):
I'd consider a pull request of that warning suppression
@virl commented on GitHub (Jun 23, 2016):
Please fix that warning. Also iOS8+ only is fine.
@KMessina1 commented on GitHub (Jul 14, 2016):
This really needs to be fixed, every time I do a clean build it gives me the warning. At this point, its pretty annoying. I moved to this library so that it would be modern and a Swift solution to Appirater.
@coneybeare commented on GitHub (Jul 14, 2016):
@KMessina1 I will entertain any pull request surpassing the warning, please feel free to contribute.
@vazra commented on GitHub (Nov 28, 2017):
@coneybeare @jlaws any update on this? It's still the same.
@coneybeare commented on GitHub (Nov 28, 2017):
UIAlertView has already been completely removed from source in master.