starred/Armchair
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-07-25 14:08:44 +02:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

UIAlertView is deprecated #24

New Issue
Closed
opened 2025-12-29 18:28:12 +01:00 by adam · 11 comments
adam commented 2025-12-29 18:28:12 +01:00
Owner
Copy Link
Copy Source

Originally created by @jlaws on GitHub (Dec 15, 2015).

You should use UIAlertController instead.

Originally created by @jlaws on GitHub (Dec 15, 2015). You should use UIAlertController instead.
adam closed this issue 2025-12-29 18:28:12 +01:00
adam commented 2025-12-29 18:28:13 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Dec 15, 2015):

I will entertain a pull request that maintains backwards compatibility.

@coneybeare commented on GitHub (Dec 15, 2015): I will entertain a pull request that maintains backwards compatibility.
adam commented 2025-12-29 18:28:13 +01:00
Author
Owner
Copy Link
Copy Source

@phimage commented on GitHub (Dec 15, 2015):

@jlaws just set usesAlertController to true for the moment

@coneybeare Maybe we could change the default value of usesAlertController to true? or (according to iOS version > 9)

@phimage commented on GitHub (Dec 15, 2015): @jlaws just set `usesAlertController` to true for the moment @coneybeare Maybe we could change the default value of `usesAlertController` to `true`? or (according to iOS version > 9)
adam commented 2025-12-29 18:28:13 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Dec 15, 2015):

I like that idea of setting the default to true based on operatingSystemVersion

@coneybeare commented on GitHub (Dec 15, 2015): I like that idea of setting the default to true based on `operatingSystemVersion`
adam commented 2025-12-29 18:28:13 +01:00
Author
Owner
Copy Link
Copy Source

@jlaws commented on GitHub (Apr 17, 2016):

Finally got around to looking at this thread again. My concern was the build warning:

Armchair-Swift.h:130:20: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead

Considering that 95% or 97.5% of devices are running iOS 8+ it is probably safe to make the min target for the library iOS 8 and use alert controllers exclusively. Just create a fork and leave the old cocoapods for people who want to target earlier versions.

Another option is to suppress the warning inside the library.

@jlaws commented on GitHub (Apr 17, 2016): Finally got around to looking at this thread again. My concern was the build warning: `Armchair-Swift.h:130:20: 'UIAlertView' is deprecated: first deprecated in iOS 9.0 - UIAlertView is deprecated. Use UIAlertController with a preferredStyle of UIAlertControllerStyleAlert instead` Considering that [95%](https://developer.apple.com/support/app-store/) or [97.5%](https://mixpanel.com/trends/#report/ios_9) of devices are running iOS 8+ it is probably safe to make the min target for the library iOS 8 and use alert controllers exclusively. Just create a fork and leave the old cocoapods for people who want to target earlier versions. Another option is to suppress the warning inside the library.
adam commented 2025-12-29 18:28:14 +01:00
Author
Owner
Copy Link
Copy Source

@tbaranes commented on GitHub (Apr 17, 2016):

I agree with @jlaws solution. If you really don't want to target only iOS8+, you should suppress that warning directly in the library.

@tbaranes commented on GitHub (Apr 17, 2016): I agree with @jlaws solution. If you really don't want to target only iOS8+, you should suppress that warning directly in the library.
adam commented 2025-12-29 18:28:15 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Apr 17, 2016):

I'd consider a pull request of that warning suppression

@coneybeare commented on GitHub (Apr 17, 2016): I'd consider a pull request of that warning suppression
adam commented 2025-12-29 18:28:15 +01:00
Author
Owner
Copy Link
Copy Source

@virl commented on GitHub (Jun 23, 2016):

Please fix that warning. Also iOS8+ only is fine.

@virl commented on GitHub (Jun 23, 2016): Please fix that warning. Also iOS8+ only is fine.
adam commented 2025-12-29 18:28:16 +01:00
Author
Owner
Copy Link
Copy Source

@KMessina1 commented on GitHub (Jul 14, 2016):

This really needs to be fixed, every time I do a clean build it gives me the warning. At this point, its pretty annoying. I moved to this library so that it would be modern and a Swift solution to Appirater.

@KMessina1 commented on GitHub (Jul 14, 2016): This really needs to be fixed, every time I do a clean build it gives me the warning. At this point, its pretty annoying. I moved to this library so that it would be modern and a Swift solution to Appirater.
adam commented 2025-12-29 18:28:16 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Jul 14, 2016):

@KMessina1 I will entertain any pull request surpassing the warning, please feel free to contribute.

@coneybeare commented on GitHub (Jul 14, 2016): @KMessina1 I will entertain any pull request surpassing the warning, please feel free to contribute.
adam commented 2025-12-29 18:28:17 +01:00
Author
Owner
Copy Link
Copy Source

@vazra commented on GitHub (Nov 28, 2017):

@coneybeare @jlaws any update on this? It's still the same.

@vazra commented on GitHub (Nov 28, 2017): @coneybeare @jlaws any update on this? It's still the same.
adam commented 2025-12-29 18:28:17 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Nov 28, 2017):

UIAlertView has already been completely removed from source in master.

@coneybeare commented on GitHub (Nov 28, 2017): UIAlertView has already been completely removed from source in master.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair#24