[PR #135] [MERGED] Update to Swift 5 #139

New Issue

adam · 2025-12-29T18:29:15+01:00

adam commented

2025-12-29 18:29:15 +01:00

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/135
Author: @weakfl
Created: 9/19/2019
Status: ✅ Merged
Merged: 10/25/2019
Merged by: @coneybeare

Base: master ← Head: swift5

📝 Commits (2)

b22a605 update projects to recommended settings
51eca2a Conversion to Swift 5

📊 Changes

13 files changed (+87 additions, -46 deletions)

View changed files

📝 .swift-version (+1 -1)
📝 Armchair.podspec (+2 -2)
📝 Armchair.xcodeproj/project.pbxproj (+11 -8)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme (+10 -14)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme (+1 -5)
➕ Armchair.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist (+8 -0)
📝 Example/AppDelegate.swift (+1 -1)
📝 Example/Base.lproj/LaunchScreen.storyboard (+0 -0)
📝 Example/Base.lproj/Main.storyboard (+0 -0)
📝 Example/Images.xcassets/AppIcon.appiconset/Contents.json (+30 -0)
📝 Mac Example.xcodeproj/project.pbxproj (+9 -2)
📝 Source/Armchair.swift (+2 -2)
📝 iOS Example.xcodeproj/project.pbxproj (+12 -11)

📄 Description

convert all targets to Swift 5
bump .swift-version
update podspec
fix warnings
update projects to recommended settings

% pod lib lint

 -> Armchair (0.3.6)
    - NOTE  | xcodebuild:  note: Using new build system
    - NOTE  | xcodebuild:  note: Planning build
    - NOTE  | xcodebuild:  note: Constructing build description
    - NOTE  | [iOS] xcodebuild:  warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App')

Armchair passed validation.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/135 **Author:** [@weakfl](https://github.com/weakfl) **Created:** 9/19/2019 **Status:** ✅ Merged **Merged:** 10/25/2019 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `swift5` --- ### 📝 Commits (2) - [`b22a605`](https://github.com/UrbanApps/Armchair/commit/b22a605285836fb02203e4ac4ce2088e07c8d839) update projects to recommended settings - [`51eca2a`](https://github.com/UrbanApps/Armchair/commit/51eca2a9311b5862f9cf50ac24c8b52adbbe0687) Conversion to Swift 5 ### 📊 Changes **13 files changed** (+87 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `.swift-version` (+1 -1) 📝 `Armchair.podspec` (+2 -2) 📝 `Armchair.xcodeproj/project.pbxproj` (+11 -8) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme` (+10 -14) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme` (+1 -5) ➕ `Armchair.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist` (+8 -0) 📝 `Example/AppDelegate.swift` (+1 -1) 📝 `Example/Base.lproj/LaunchScreen.storyboard` (+0 -0) 📝 `Example/Base.lproj/Main.storyboard` (+0 -0) 📝 `Example/Images.xcassets/AppIcon.appiconset/Contents.json` (+30 -0) 📝 `Mac Example.xcodeproj/project.pbxproj` (+9 -2) 📝 `Source/Armchair.swift` (+2 -2) 📝 `iOS Example.xcodeproj/project.pbxproj` (+12 -11) </details> ### 📄 Description - convert all targets to Swift 5 - bump `.swift-version` - update podspec - fix warnings - update projects to recommended settings ``` % pod lib lint -> Armchair (0.3.6) - NOTE | xcodebuild: note: Using new build system - NOTE | xcodebuild: note: Planning build - NOTE | xcodebuild: note: Constructing build description - NOTE | [iOS] xcodebuild: warning: Skipping code signing because the target does not have an Info.plist file and one is not being generated automatically. (in target 'App' from project 'App') Armchair passed validation. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 18:29:15 +01:00

adam closed this issue

2025-12-29 18:29:15 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Armchair#139