[PR #102] [MERGED] Improve iOS 10.3 review dialog support, cut iOS8 support #124

Closed
opened 2025-12-29 18:29:11 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/102
Author: @apptekstudios
Created: 7/31/2017
Status: Merged
Merged: 11/10/2017
Merged by: @coneybeare

Base: masterHead: master


📝 Commits (4)

  • 068c4b9 Remove ios < 9 support [Alertview]
  • ea3ab5e Merge remote-tracking branch 'UrbanApps/master'
  • dddaa62 Changes
  • adc0a0d Update iOS 10.3 review dialog support

📊 Changes

1 file changed (+55 additions, -59 deletions)

View changed files

📝 Source/Armchair.swift (+55 -59)

📄 Description

Improved support of the iOS 10.3 review dialog. Also ensured it works for anyone using the custom dialog closures.

Removed legacy iOS8 alertview support


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/102 **Author:** [@apptekstudios](https://github.com/apptekstudios) **Created:** 7/31/2017 **Status:** ✅ Merged **Merged:** 11/10/2017 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (4) - [`068c4b9`](https://github.com/UrbanApps/Armchair/commit/068c4b92c1e05752325e16e77f5bf971e22b3ad2) Remove ios < 9 support [Alertview] - [`ea3ab5e`](https://github.com/UrbanApps/Armchair/commit/ea3ab5ed28393e3172c04e05360aff239e5855a4) Merge remote-tracking branch 'UrbanApps/master' - [`dddaa62`](https://github.com/UrbanApps/Armchair/commit/dddaa62c2564e5007102742d1f61fc01311e9b5b) Changes - [`adc0a0d`](https://github.com/UrbanApps/Armchair/commit/adc0a0d580f011715eeef7efe9ac9592d40f0cd0) Update iOS 10.3 review dialog support ### 📊 Changes **1 file changed** (+55 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `Source/Armchair.swift` (+55 -59) </details> ### 📄 Description Improved support of the iOS 10.3 review dialog. Also ensured it works for anyone using the custom dialog closures. Removed legacy iOS8 alertview support --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 18:29:11 +01:00
adam closed this issue 2025-12-29 18:29:11 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair#124