starred/Armchair
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-01-15 06:43:24 +01:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

[PR #89] [MERGED] Fixed issue with Carthage building project using the wrong toolchain #118

New Issue
Closed
opened 2025-12-29 18:29:09 +01:00 by adam · 0 comments
adam commented 2025-12-29 18:29:09 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/89
Author: @masgharneya
Created: 3/16/2017
Status: ✅ Merged
Merged: 3/17/2017
Merged by: @coneybeare

Base: master ← Head: bugfix/useSwift3ToolchainOnRelease

📝 Commits (1)

  • 14c89be Fixed issue with Carthage building project using the wrong toolchain

📊 Changes

1 file changed (+1 additions, -2 deletions)

View changed files

📝 Armchair.xcodeproj/project.pbxproj (+1 -2)

📄 Description

When building through Carthage, the Release config is being used and fails to build using the Swift 2.3 toolchain.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/89 **Author:** [@masgharneya](https://github.com/masgharneya) **Created:** 3/16/2017 **Status:** ✅ Merged **Merged:** 3/17/2017 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `bugfix/useSwift3ToolchainOnRelease` --- ### 📝 Commits (1) - [`14c89be`](https://github.com/UrbanApps/Armchair/commit/14c89be4b9d4fd835836ff1da76cae40374e83bc) Fixed issue with Carthage building project using the wrong toolchain ### 📊 Changes **1 file changed** (+1 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `Armchair.xcodeproj/project.pbxproj` (+1 -2) </details> ### 📄 Description When building through Carthage, the Release config is being used and fails to build using the Swift 2.3 toolchain. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 18:29:09 +01:00
adam closed this issue 2025-12-29 18:29:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair#118
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?