[PR #74] [MERGED] Updates project so it builds with Swift 2.3 #113

New Issue

adam · 2025-12-29T18:29:08+01:00

adam commented

2025-12-29 18:29:08 +01:00

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/74
Author: @JagCesar
Created: 9/8/2016
Status: ✅ Merged
Merged: 9/16/2016
Merged by: @coneybeare

Base: master ← Head: feature/swift2.3

📝 Commits (1)

96f70c8 Updates project so it builds with Swift 2.3

📊 Changes

5 files changed (+44 additions, -30 deletions)

View changed files

📝 Armchair.xcodeproj/project.pbxproj (+21 -3)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme (+1 -1)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme (+1 -1)
📝 Source/Armchair.swift (+6 -5)
📝 iOS Example.xcodeproj/project.pbxproj (+15 -20)

📄 Description

I've seen there are Pull Requests that updates so this code runs Swift 3. I would say it's dangerous to refactor to Swift 3 without having any unit tests.

The fix needed so the project builds with Swift 2.3 is a lot smaller, which means it's a smaller chance of something breaking.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/74 **Author:** [@JagCesar](https://github.com/JagCesar) **Created:** 9/8/2016 **Status:** ✅ Merged **Merged:** 9/16/2016 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `feature/swift2.3` --- ### 📝 Commits (1) - [`96f70c8`](https://github.com/UrbanApps/Armchair/commit/96f70c8bdff2320e62aaed0d0aa68cdeb7e2a9fc) Updates project so it builds with Swift 2.3 ### 📊 Changes **5 files changed** (+44 additions, -30 deletions) <details> <summary>View changed files</summary> 📝 `Armchair.xcodeproj/project.pbxproj` (+21 -3) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme` (+1 -1) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme` (+1 -1) 📝 `Source/Armchair.swift` (+6 -5) 📝 `iOS Example.xcodeproj/project.pbxproj` (+15 -20) </details> ### 📄 Description I've seen there are Pull Requests that updates so this code runs Swift 3. I would say it's dangerous to refactor to Swift 3 without having any unit tests. The fix needed so the project builds with Swift 2.3 is a lot smaller, which means it's a smaller chance of something breaking. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 18:29:08 +01:00

adam closed this issue

2025-12-29 18:29:08 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Armchair#113