starred/Armchair-UrbanApps
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-09-05 17:37:14 +02:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

Mac Version doesn't compile #74

New Issue
Open
opened 2025-12-30 00:27:57 +01:00 by adam · 2 comments
adam commented 2025-12-30 00:27:57 +01:00
Owner
Copy Link
Copy Source

Originally created by @Vithanco on GitHub (Feb 4, 2018).

I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS.

#if os(iOS)
    public func useStoreKitReviewPrompt() -> Bool {
...

but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions.

    public var shouldTryStoreKitReviewPrompt : Bool {
        if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true }

Please review. Thanks for this great library.

Originally created by @Vithanco on GitHub (Feb 4, 2018). I might overlook something, but the a8c1dfd version doesn't seem to compile on a Mac. UseStoreKitReviewPrompt seems to be missing. It is only declared for iOS. ``` #if os(iOS) public func useStoreKitReviewPrompt() -> Bool { ... ``` but it is needed elsewhere, like in shouldTryStoreKitReviewPrompt, where it says function is available for all macOS versions. ``` public var shouldTryStoreKitReviewPrompt : Bool { if #available(iOS 10.3, *), useStoreKitReviewPrompt { return true } ``` Please review. Thanks for this great library.
adam commented 2025-12-30 00:27:58 +01:00
Author
Owner
Copy Link
Copy Source

@Vithanco commented on GitHub (Feb 4, 2018):

I don't think this issue was introduced with a8c1dfd.

@Vithanco commented on GitHub (Feb 4, 2018): I don't think this issue was introduced with a8c1dfd.
adam commented 2025-12-30 00:27:58 +01:00
Author
Owner
Copy Link
Copy Source

@coneybeare commented on GitHub (Feb 28, 2018):

It was introduced on https://github.com/UrbanApps/Armchair/pull/112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.

@coneybeare commented on GitHub (Feb 28, 2018): It was introduced on https://github.com/UrbanApps/Armchair/pull/112 by @MartinMoizard, but I haven't had time to revert it. Pulls welcome.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair-UrbanApps#74