starred/Armchair-UrbanApps
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-08-25 05:04:09 +02:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

[PR #119] [MERGED] Xcode 9.3 swift 4.1 fixes #131

New Issue
Closed
opened 2025-12-30 00:28:31 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:28:31 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/119
Author: @mabidakun
Created: 3/30/2018
Status: ✅ Merged
Merged: 4/9/2018
Merged by: @coneybeare

Base: master ← Head: Xcode-9.3-Swift-4.1-Fixes

📝 Commits (3)

  • ffd05b1 Fixes a compile-time failure caused by referening to the useStoreKitReviewPrompt method, which is no included for macOS.
  • ead9ec4 Replaces code for checking the platform and OS version, with a simplified call that meets the original intent.
  • de6e53d Applies Xcode-9.3. Fix-it which adds compile time warnings for the implicit retention of self.

📊 Changes

6 files changed (+27 additions, -12 deletions)

View changed files

📝 Armchair.xcodeproj/project.pbxproj (+5 -1)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme (+1 -3)
📝 Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme (+1 -3)
📝 Mac Example.xcodeproj/project.pbxproj (+5 -1)
📝 Source/Armchair.swift (+10 -3)
📝 iOS Example.xcodeproj/project.pbxproj (+5 -1)

📄 Description

Contains a few minor modifications to resolve an error and a few warnings under Xcode-9.3/Swift-4.1

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/119 **Author:** [@mabidakun](https://github.com/mabidakun) **Created:** 3/30/2018 **Status:** ✅ Merged **Merged:** 4/9/2018 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `Xcode-9.3-Swift-4.1-Fixes` --- ### 📝 Commits (3) - [`ffd05b1`](https://github.com/UrbanApps/Armchair/commit/ffd05b16a59927b616471e6fd1b1ae0ef72f209b) Fixes a compile-time failure caused by referening to the useStoreKitReviewPrompt method, which is no included for macOS. - [`ead9ec4`](https://github.com/UrbanApps/Armchair/commit/ead9ec4656105151750a3d9283fdb739693724fe) Replaces code for checking the platform and OS version, with a simplified call that meets the original intent. - [`de6e53d`](https://github.com/UrbanApps/Armchair/commit/de6e53da445d893af193061799d5f96e9a6ea54c) Applies Xcode-9.3. Fix-it which adds compile time warnings for the implicit retention of self. ### 📊 Changes **6 files changed** (+27 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `Armchair.xcodeproj/project.pbxproj` (+5 -1) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/Armchair.xcscheme` (+1 -3) 📝 `Armchair.xcodeproj/xcshareddata/xcschemes/ArmchairMac.xcscheme` (+1 -3) 📝 `Mac Example.xcodeproj/project.pbxproj` (+5 -1) 📝 `Source/Armchair.swift` (+10 -3) 📝 `iOS Example.xcodeproj/project.pbxproj` (+5 -1) </details> ### 📄 Description Contains a few minor modifications to resolve an error and a few warnings under Xcode-9.3/Swift-4.1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:28:31 +01:00
adam closed this issue 2025-12-30 00:28:31 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair-UrbanApps#131