starred/Armchair-UrbanApps
1
0
Fork 0
mirror of https://github.com/UrbanApps/Armchair.git synced 2026-08-31 16:07:24 +02:00
Code Issues 36 Packages Projects Releases 3 Wiki Activity

[PR #58] [MERGED] Fallback to localizable.strings #110

New Issue
Closed
opened 2025-12-30 00:28:17 +01:00 by adam · 0 comments
adam commented 2025-12-30 00:28:17 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/UrbanApps/Armchair/pull/58
Author: @fotiDim
Created: 5/30/2016
Status: ✅ Merged
Merged: 6/2/2016
Merged by: @coneybeare

Base: master ← Head: fallback-to-localizable.strings

📝 Commits (2)

  • cc3706c Falling back to Localizable.strings
  • 0ea672f Updated README to include localization changes

📊 Changes

2 files changed (+16 additions, -6 deletions)

View changed files

📝 README.md (+1 -1)
📝 Source/Armchair.swift (+15 -5)

📄 Description

  • ArmchairLocalizable.strings wasn't documented in the Readme so one wouldn't know where to put the translation strings.
  • Many projects use the standard Localizable.strings file so this should be included in the defaults.

In order not to break functionality for existing installations I have included a fallback from ArmchairLocalizable.strings to Localizable.strings.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/UrbanApps/Armchair/pull/58 **Author:** [@fotiDim](https://github.com/fotiDim) **Created:** 5/30/2016 **Status:** ✅ Merged **Merged:** 6/2/2016 **Merged by:** [@coneybeare](https://github.com/coneybeare) **Base:** `master` ← **Head:** `fallback-to-localizable.strings` --- ### 📝 Commits (2) - [`cc3706c`](https://github.com/UrbanApps/Armchair/commit/cc3706ca07b5ca78b952c90bf989346fc213017d) Falling back to Localizable.strings - [`0ea672f`](https://github.com/UrbanApps/Armchair/commit/0ea672f4d508caa27718214c7dfae39264747106) Updated README to include localization changes ### 📊 Changes **2 files changed** (+16 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `Source/Armchair.swift` (+15 -5) </details> ### 📄 Description - `ArmchairLocalizable.strings` wasn't documented in the Readme so one wouldn't know where to put the translation strings. - Many projects use the standard `Localizable.strings` file so this should be included in the defaults. In order not to break functionality for existing installations I have included a fallback from `ArmchairLocalizable.strings` to `Localizable.strings`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 00:28:17 +01:00
adam closed this issue 2025-12-30 00:28:17 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
enhancement
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/Armchair-UrbanApps#110