[PR #36] [MERGED] Feature/styling #39

New Issue

adam · 2025-12-30T01:29:46+01:00

adam commented

2025-12-30 01:29:46 +01:00

📋 Pull Request Information

Original PR: https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/36
Author: @melihaksoy
Created: 9/13/2019
Status: ✅ Merged
Merged: 9/13/2019
Merged by: @melihaksoy

Base: master ← Head: feature/styling

📝 Commits (3)

ef43e9b Working with material styles
3f2a474 Replaced deprecated ViewModelProviders.of and applied base styles with material components
aaaeb2a Various code style fixes and styles.xml improvements

📊 Changes

58 files changed (+531 additions, -472 deletions)

View changed files

📝 README.md (+3 -3)
📝 app/build.gradle (+1 -2)
📝 app/src/main/kotlin/com/melih/rocketscience/MainActivity.kt (+3 -5)
📝 app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt (+4 -2)
📝 app/src/main/res/layout/activity_main.xml (+19 -24)
📝 build.gradle (+2 -2)
📝 core/build.gradle (+1 -1)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseDaggerFragment.kt (+5 -5)
📝 core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt (+10 -7)
📝 core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt (+6 -6)
📝 core/src/main/kotlin/com/melih/core/base/paging/BasePagingFactory.kt (+6 -6)
📝 core/src/main/kotlin/com/melih/core/base/recycler/BasePagingListAdapter.kt (+9 -0)
📝 core/src/main/kotlin/com/melih/core/base/viewmodel/BasePagingViewModel.kt (+9 -9)
📝 core/src/main/kotlin/com/melih/core/base/viewmodel/BaseViewModel.kt (+6 -6)
➕ core/src/main/kotlin/com/melih/core/extensions/DiffUtilHelper.kt (+27 -0)
📝 core/src/main/kotlin/com/melih/core/extensions/LifecycleExtensions.kt (+0 -13)
➖ core/src/main/kotlin/com/melih/core/extensions/RecyclerExtensions.kt (+0 -14)
📝 core/src/main/res/values/colors.xml (+8 -4)
📝 core/src/main/res/values/dimens.xml (+2 -0)
📝 core/src/main/res/values/styles.xml (+37 -32)

...and 38 more files

📄 Description

Introduces improvements both for code style & styles.xml.
Closes #35
Closes #8

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/pull/36 **Author:** [@melihaksoy](https://github.com/melihaksoy) **Created:** 9/13/2019 **Status:** ✅ Merged **Merged:** 9/13/2019 **Merged by:** [@melihaksoy](https://github.com/melihaksoy) **Base:** `master` ← **Head:** `feature/styling` --- ### 📝 Commits (3) - [`ef43e9b`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/ef43e9bf79d6eb6aa595e91d8dd5f722611623db) Working with material styles - [`3f2a474`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/3f2a474f014ff518ee6f81f6e4805bf9c7009ae3) Replaced deprecated ViewModelProviders.of and applied base styles with material components - [`aaaeb2a`](https://github.com/melihaksoy/Android-Kotlin-Modulerized-CleanArchitecture/commit/aaaeb2ab29d21afb77a27ab5db3f41b36ce016f0) Various code style fixes and styles.xml improvements ### 📊 Changes **58 files changed** (+531 additions, -472 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+3 -3) 📝 `app/build.gradle` (+1 -2) 📝 `app/src/main/kotlin/com/melih/rocketscience/MainActivity.kt` (+3 -5) 📝 `app/src/main/kotlin/com/melih/rocketscience/di/AppComponent.kt` (+4 -2) 📝 `app/src/main/res/layout/activity_main.xml` (+19 -24) 📝 `build.gradle` (+2 -2) 📝 `core/build.gradle` (+1 -1) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseDaggerFragment.kt` (+5 -5) 📝 `core/src/main/kotlin/com/melih/core/base/lifecycle/BaseFragment.kt` (+10 -7) 📝 `core/src/main/kotlin/com/melih/core/base/paging/BasePagingDataSource.kt` (+6 -6) 📝 `core/src/main/kotlin/com/melih/core/base/paging/BasePagingFactory.kt` (+6 -6) 📝 `core/src/main/kotlin/com/melih/core/base/recycler/BasePagingListAdapter.kt` (+9 -0) 📝 `core/src/main/kotlin/com/melih/core/base/viewmodel/BasePagingViewModel.kt` (+9 -9) 📝 `core/src/main/kotlin/com/melih/core/base/viewmodel/BaseViewModel.kt` (+6 -6) ➕ `core/src/main/kotlin/com/melih/core/extensions/DiffUtilHelper.kt` (+27 -0) 📝 `core/src/main/kotlin/com/melih/core/extensions/LifecycleExtensions.kt` (+0 -13) ➖ `core/src/main/kotlin/com/melih/core/extensions/RecyclerExtensions.kt` (+0 -14) 📝 `core/src/main/res/values/colors.xml` (+8 -4) 📝 `core/src/main/res/values/dimens.xml` (+2 -0) 📝 `core/src/main/res/values/styles.xml` (+37 -32) _...and 38 more files_ </details> ### 📄 Description Introduces improvements both for code style & styles.xml. Closes #35 Closes #8 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:29:46 +01:00

adam referenced this issue

2025-12-30 01:29:46 +01:00

[PR #39] [MERGED] Updated fastlane version #40

adam closed this issue

2025-12-30 01:29:46 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/Android-Kotlin-Modulerized-CleanArchitecture#39